- 17 8月, 2020 1 次提交
-
-
由 Ryuta Kamizono 提交于
Fix preloader to associate preloaded records by default
-
- 16 8月, 2020 3 次提交
-
-
由 Ryuta Kamizono 提交于
Someone had relied on the behavior that preloading with a given scope, but the behavior has lost in #35496 to fix the minor bug that unloading through association. Basically we don't guarantee the internal behavior, but the bugfix can be achieved without any breaking change, so I've restored the lost functionality. Fixes #36638. Fixes #37720.
-
由 Daniel Colson 提交于
fix(guides): Update AWDwR book link in Releasing Rails guide [ci skip]
-
由 Eugene Kenny 提交于
Use superclass name in inspect of anonymous ActionView::Base subclass
-
- 15 8月, 2020 9 次提交
-
-
由 Petrik 提交于
When rendering views an anonymous subclass is created by calling ActionView::Base.with_empty_template_cache. This causes inspect to return an unhelpful description when calling inspect: `#<#<Class:0x012345012345>:<0x012345012345>`. This can be confusing when exceptions are raised because it's hard to figure out where to look. For example calling an undefined method in a template would raise the following exception: undefined method `undefined' for #<#<Class:0x012345012345>:<0x012345012345> Instead we can return the non-anonymous superclass name. undefined method `undefined' for #<ActionView::Base:0x01234502345> The anonymous class is created in ActionView::Base.with_empty_template_cache. See f9bea630 This seems to be done for performance reasons only, without expecting a change to calling `inspect`.
-
由 Jonathan Hefner 提交于
Remove double negative in testing docs [ci-skip]
-
由 Michael Hagar 提交于
Update guides/source/testing.md Co-authored-by: NJonathan Hefner <jonathan@hefner.pro>
-
由 Ryuta Kamizono 提交于
Fix incorrect result when eager loading with duplicated through association with join scope Part 2
-
由 Jonathan Hefner 提交于
Fix spelling of DigitalOcean in docs [ci-skip]
-
由 Ben Tranter 提交于
Fixes the spelling of DigitalOcean in the ActiveStorage guide.
-
由 Eileen M. Uchitelle 提交于
Remove unnecessary `compact`
-
由 eileencodes 提交于
Looking at the history this is holdover from the pre-pool manager and changes made by Shopify. The tests pass without it and we've had enough changes that it doesn't appear necessary anymore. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Eileen M. Uchitelle 提交于
Merge pull request #40048 from eileencodes/fix-incorrect-removal-of-current_shard-from-establish_connection Fix incorrect removal of current_shard in establish_connection
-
- 14 8月, 2020 5 次提交
-
-
由 eileencodes 提交于
If we enter a `connected_to` block and call `establish_connection` like the test added here we need to ensure that `shard: current_shard` is passed to the handler, otherwise the connection will be established on `default` not on `shard_one`. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Eileen M. Uchitelle 提交于
Rename test models for inclusivity
-
由 Daniel Colson 提交于
After renaming `Man` to `Human` the variable letter `m` in these tests ends up being pretty confusing. Rather than rename it to `h`, this commit replaces it with the full word `human`. Since I was already renaming things, I also went ahead and replaced `f` with `face`, `i` with `interest`, and `a` with `author`.
-
由 Daniel Colson 提交于
The commit replaces the `Man` model used in tests with a `Human` model. It also replaces the existing `Human` model with a `SuperHuman` model inheriting from `Human`. While this may seem like a cosmetic change, I see it as more of an inclusivity change. I think it makes sense for a number of reasons: * Prior to this commit the `Human` model inherited from `Man`. At best this makes no sense (it should be the other way around). At worst it is offensive and harmful to the community. * It doesn't seem inclusive to me to have exclusively male-gendered examples in the codebase. * There is no particular reason for these examples to be gendered. * `man` is hard to grep for, since it also matches `many, manager, manual, etc` For the most part this is a simple search and replace. The one exception to that is that I had to add the table name to the model so we could use "humans" instead of "humen".
-
由 Ryuta Kamizono 提交于
Follow up of #40000. In #40000, `eager_load(:general_categorizations, :general_posts)` works, but `eager_load(:general_posts, :general_categorizations)` doesn't work yet. This implements the deduplication for the case of reversed eager loading order.
-
- 13 8月, 2020 4 次提交
-
-
由 Jonathan Hefner 提交于
Follow-up to #40013. Newly created `Blob`s may not be uploaded yet, so do not try to update their service metadata.
-
由 KapilSachdev 提交于
-
由 Jonathan Hefner 提交于
Adds documentation for habtm association always being optional: true [ci skip]
-
由 Sandip Mane 提交于
parent f4471fc7 author Sandip Mane <sandip.mane@bigbinary.com> 1593247595 +0530 committer Sandip Mane <sandip2490@gmail.com> 1597253412 +0530 Adds doc for habtm association for always optional: true Added docs line under definition of habtm with a text containing habtm refers to zero or more associations Added docs line under definition of habtm with a text containing it refers to zero or more associations Updated the sentence to include declaring association for habtm relation
-
- 12 8月, 2020 9 次提交
-
-
由 Jonathan Hefner 提交于
Add baseline defaults section [ci skip]
-
由 Jonathan Hefner 提交于
[ci skip] Add clarity on protect_from_forgery documentation
-
由 Ryuta Kamizono 提交于
Address `ArgumentError: Missing host to link to! Please provide the :host parameter, set default_url_options[:host], or set :only_path to true`
-
由 Yasuo Honda 提交于
Address `ArgumentError: Missing host to link to! Please provide the :host parameter, set default_url_options[:host], or set :only_path to true` This pull request fixes #38697 It is caused by `@controller.singleton_class.include @routes.url_helpers` when `@controller` is nil in `ActionController::TestCase`. * Without this commit ```ruby % cd actionview % PARALLEL_WORKERS=1 bin/test test/actionpack/controller/layout_test.rb test/template/url_helper_test.rb --seed 16702 -n "/^(?:LayoutSetInResponseTest#(?:test_layout_symbol_set_in_controller_returning_nil_falls_back_to_default)|UrlHelperTest#(?:test_url_for_with_array_and_only_path_set_to_false))$/" Run options: --seed 16702 -n "/^(?:LayoutSetInResponseTest#(?:test_layout_symbol_set_in_controller_returning_nil_falls_back_to_default)|UrlHelperTest#(?:test_url_for_with_array_and_only_path_set_to_false))$/" .E Error: UrlHelperTest#test_url_for_with_array_and_only_path_set_to_false: ArgumentError: Missing host to link to! Please provide the :host parameter, set default_url_options[:host], or set :only_path to true /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/http/url.rb:64:in `full_url_for' /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/http/url.rb:54:in `url_for' /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/route_set.rb:333:in `block in <class:RouteSet>' /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/route_set.rb:838:in `url_for' /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/route_set.rb:270:in `call' /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/route_set.rb:213:in `call' /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/route_set.rb:326:in `block in define_url_helper' /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/polymorphic_routes.rb:233:in `polymorphic_method' /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/polymorphic_routes.rb:116:in `polymorphic_url' /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/routing_url_for.rb:104:in `url_for' /Users/yahonda/src/github.com/rails/rails/actionview/test/template/url_helper_test.rb:102:in `test_url_for_with_array_and_only_path_set_to_false' bin/test test/template/url_helper_test.rb:100 Finished in 0.042275s, 47.3093 runs/s, 47.3093 assertions/s. 2 runs, 2 assertions, 0 failures, 1 errors, 0 skips % ```
-
由 Yu Ming 提交于
Update security.md to note that CSRF security token is included in requests automatically when `config.action_controller.default_protect_from_forgery` is set to `true`, which is the default for newly created Rails applications.
-
由 Ryuta Kamizono 提交于
fix: warning: instance variable @controller not initialized Co-authored-by: NSamuel Williams <samuel.williams@oriontransfer.co.nz>
-
由 Jonathan Hefner 提交于
An Active Storage `Blob` must be identified before it can be reliably validated. For direct uploads, a `Blob` is identified when it is attached, rather than when it is created. Before this commit, the sequence of events when attaching a `Blob` was: 1. Find the `Blob`. 2. Assign the `Blob` to an `Attachment`. 3. Save the owner record. 4. Save the `Attachment`. 5. Identify the `Blob`'s true `content_type` from its file. 6. Save the `Blob`. This meant that the owner record's validations might not see the `Blob`'s true `content_type`. After this commit, the sequence of events will be: 1. Find the `Blob`. 2. Identify the `Blob`'s true `content_type` from its file. 3. Assign the `Blob` to an `Attachment`. 4. Save the owner record. 5. Save the `Attachment`. 6. Save the `Blob`. Thus the `Blob`'s true `content_type` will be available when running the owner record's validations.
-
由 Jonathan Hefner 提交于
Document dbconsole command for multiple database [ci skip]
-
由 Abhay Nikam 提交于
-
- 11 8月, 2020 5 次提交
-
-
由 KapilSachdev 提交于
Fixes #39937
-
由 Gannon McGibbon 提交于
Fix `assert_recognizes` on mounted root routes.
-
由 Eileen M. Uchitelle 提交于
Fix missed establish_connection
-
由 Gannon McGibbon 提交于
Allow `assert_recognizes` routing assertions to work on mounted root routes.
-
由 eileencodes 提交于
In `connected_to` one of the deprecated arguments wasn't well tested so the incorrect methods signature wasn't caught by the tests. This change updates the caller when `connected_to` uses the database key. I've also cleaned up a few arguments that weren't necessary. Since the handler methods set defaults for the `shard` key, we don't need to pass that in `establish_connection` when not using the sharding API.
-
- 10 8月, 2020 4 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add helper method for resetting connection handlers in tests
-
由 eileencodes 提交于
This change makes a helper method for resetting connection handlers in the Active Record tests. The change here is relatively small and may seem unnecessary. The reason we're pushing this change is for upcoming refactoring to connection management. This change will mean that we can update one location instead of 9+ files to reset connections. It will reduce the diff of our refactoring and make reusing this code easier in the future. The method name chosen is purposefully `clean_up_connection_handler` over `clean_up_connection_handlers` because in the future there will only be one handler. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Eileen M. Uchitelle 提交于
Rename `pool_key` to `shard` and use kwargs for connection methods
-
由 Ryuta Kamizono 提交于
Fix incorrect result when eager loading with duplicated through association with join scope
-