- 08 8月, 2019 16 次提交
-
-
由 Ryuta Kamizono 提交于
Actually, `first` taking non-deterministic result is considered a bug to me. But changing the behavior should not be happened in rc2. I've restored the behavior for 6.0, and then will deprecate that in 6.1. Fixes #36802.
-
由 yuuji.yaginuma 提交于
Because `FeaturePolicy::Middleware` is not loaded in API only apps. Ref: https://github.com/rails/rails/blob/646dd8c51fc438bf935d4192ba0479e439c1ec54/railties/lib/rails/application/default_middleware_stack.rb#L69-L72
-
由 John Hawthorn 提交于
Fix test schema loading for multi-db
-
由 John Hawthorn 提交于
Raise TypeError instead of infinite loop in resolve_connection
-
由 Richard Schneeman 提交于
Updated to add Derailed link
-
由 Gannon McGibbon 提交于
Pass optional record in blob finder methods
-
由 Gannon McGibbon 提交于
Ensure custom PK types are casted in through reflection queries
-
由 Jesse Waites 提交于
-
由 Gannon McGibbon 提交于
Make sure primary keys with non-integer types can be correctly type casted in through reflections.
-
由 Rafael França 提交于
Correct the assertion argument order
-
由 Gannon McGibbon 提交于
Allow record to be optionally passed to blob finders to make sharding easier.
-
由 Abhay Nikam 提交于
-
由 Eileen M. Uchitelle 提交于
Add CHANGELOG entry for ActiveJob change
-
由 John Crepezzi 提交于
In #36864 we made a change to an ActiveJob test helper to add a new parameter for testing jobs delayed into the future. This commit adds a CHANGELOG entry for that change as well as fixing a circular argument error.
-
由 John Hawthorn 提交于
Previously we weren't passing in the spec_name, so this wasn't able to pick up the alternate schema names when using multiple databases.
-
由 Carlos Antonio da Silva 提交于
-
- 07 8月, 2019 17 次提交
-
-
由 Rafael França 提交于
Fixed cache_store name used in adding other modules section of api app documentation guide. [ci skip]
-
由 Akshay Mohite 提交于
- Using `mem_cached_store` results in an exception as lib/active_support/cache.rb:106:in `rescue in retrieve_store_class': Could not find cache store adapter for mem_cached_store (cannot load such file -- active_support/cache/mem_cached_store) (RuntimeError) - Changed the name of cache_store as `mem_cache_store` instead of `mem_cached_store`
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Fix GROUP BY aggregation alias to not duplicate "_" chars
-
由 Vipul A M 提交于
Fix typo in autoloading constants guide [ci skip]
-
由 Michael Herold 提交于
Allow passing a block to the create_inbound_email_from_mail and receive_inbound_email_from_mail test helper methods. When you wanted to test a multipart email -- for example, an email that has both a plaintext part and an HTML part -- there wasn't a way to easily build one without a pre-made fixture. By allowing you to pass a block to these methods, we unlock the power of Mail.new to easily create a variety of emails, from multi-part emails, to emails with attachments, and beyond.
-
由 blaedj 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
c9e4c848 has one performance optimization for `aggregate_alias` to early returning by `aggregate_alias.match?(/\A\w+\z/)`, but it is caused a regression that failing deduplication for non word chars #36867. I've quited the optimization and add a test to prevent a future regression. Fixes #36867.
-
由 John Hawthorn 提交于
Sync test DB from schema using its SHA1
-
由 George Claghorn 提交于
Update azure-storage gem to latest version
-
由 Peter Zhu 提交于
-
由 Eileen M. Uchitelle 提交于
Fix thread safety of prevent_writes
-
由 John Hawthorn 提交于
Previously, we used the migration status to determine whether the test database(s) needed to be reloaded from the schema. This worked in most cases, but if a schema.rb was modified outside of migrations or if a migration was rolled back, it would require a manual db:test:prepare. This commit updates load_schema to record the SHA1 of the loaded schema file inside of the ar_internal_metadata table. We can then use this SHA to determine whether we should reload the schema. This ensures that the test DB stays exactly in sync with the schema file, including rollbacks which fixes a test marked TODO.
-
由 Eileen M. Uchitelle 提交于
Fix Gemfile.lock
-
由 eileencodes 提交于
The PR #36860 changed ActionView's required version of rails-html-sanitizer, but I missed that we needed to run bundle, otherwise we end up with changes every time.
-
由 Eileen M. Uchitelle 提交于
Add at option to perform_enqueued_jobs test helper
-
由 eileencodes 提交于
As demonstrated in the test added and in #36830 the code that prevents writes wasn't thread safe. If one thread does a read, then another does a write, and then another does a read the second read will cause the first write to be unwriteable. This change removes the instance variable and instead uses a getter/setter on Thread.current[:prevent_writes] for the connection handler to set whether writes are allowed. Fixes #36830
-
- 06 8月, 2019 5 次提交
-
-
由 John Crepezzi 提交于
Currently, the `perform_enqueued_jobs` helpers will also immediately perform jobs that are scheduled via `set(wait:)` to run in the future. This commit adds a new argument to `perform_enqueued_jobs` to make it only run jobs scheduled at or before the passed in `Time`. This allows testing the side effects of immediate job execution separate of jobs delayed in the future.
-
由 Ryuta Kamizono 提交于
[ci skip] Mention `context` option of save in documentation
-
由 OKURA Masafumi 提交于
`ActiveRecord::Validations#save` takes `context` option which can change validation context. This fact should be mentioned in the documentation.
-
由 Eileen M. Uchitelle 提交于
Update rails-html-sanitizer to 1.1.0 in actionview.gemspec
-
由 Cliff Pruitt 提交于
Commit https://github.com/rails/rails/commit/52f0b050e25cac6d9571d71c9f74ea583d8aa2b0 replaces `white_list_sanitizer` with `safe_list_sanitizer`. This is a breaking change unless the installed version of `rails-html-sanitizer` is `>= 1.1.0`. This commit updates the minimum version in `actionview/actionview.gemspec` to `1.1.0`.
-
- 05 8月, 2019 2 次提交
-
-
由 Eileen M. Uchitelle 提交于
Added multiple database Active Record guide entry to the release notes
-
由 Vipul A M 提交于
Corrected config option path in release notes for deprecation release notes of Rails 6 [ci skip]
-