1. 26 10月, 2016 1 次提交
  2. 25 10月, 2016 2 次提交
  3. 24 10月, 2016 1 次提交
  4. 23 10月, 2016 4 次提交
  5. 22 10月, 2016 3 次提交
  6. 21 10月, 2016 1 次提交
    • A
      Use old typecasting method if no type casted binds are passed in · 13455110
      Aaron Patterson 提交于
      Query cache doesn't type cast bind parameters since it isn't
      actually querying the database, so it can't pass those values in.  Type
      casting in the query cache method would cause the values to be type cast
      twice in the case that there is a cache miss (since the methods it calls
      will type cast *again*).  If logging is disabled, then adding the type
      cast code to the query cache method will needlessly typecast the values
      (since the only reason those values are type cast is for display in the
      logs).
      
      Fixes #26828.
      13455110
  7. 20 10月, 2016 2 次提交
  8. 19 10月, 2016 1 次提交
  9. 14 10月, 2016 2 次提交
  10. 12 10月, 2016 1 次提交
    • R
      Fix `warning: ambiguous first argument` · f53f69bd
      Ryuta Kamizono 提交于
      ```
      test/cases/adapters/postgresql/case_insensitive_test.rb:12: warning: ambiguous first argument; put parentheses or a space even after `/' operator
      test/cases/adapters/postgresql/case_insensitive_test.rb:16: warning: ambiguous first argument; put parentheses or a space even after `/' operator
      test/cases/adapters/postgresql/case_insensitive_test.rb:20: warning: ambiguous first argument; put parentheses or a space even after `/' operator
      test/cases/adapters/postgresql/case_insensitive_test.rb:24: warning: ambiguous first argument; put parentheses or a space even after `/' operator
      ```
      f53f69bd
  11. 11 10月, 2016 2 次提交
  12. 10 10月, 2016 2 次提交
    • R
      `name` is not a column option · 24a1a6a8
      Ryuta Kamizono 提交于
      `migration_keys` includes `name` but `name` is not a column option.
      24a1a6a8
    • R
      Dump index options to pretty format · 5025fd3a
      Ryuta Kamizono 提交于
      ```ruby
        # Before
        t.index ["firm_id", "type", "rating"], name: "company_index", order: {"rating"=>:desc}, using: :btree
      
        # After
        t.index ["firm_id", "type", "rating"], name: "company_index", order: { rating: :desc }, using: :btree
      ```
      5025fd3a
  13. 08 10月, 2016 4 次提交
  14. 07 10月, 2016 1 次提交
  15. 04 10月, 2016 1 次提交
  16. 03 10月, 2016 3 次提交
  17. 01 10月, 2016 2 次提交
    • L
      Add missing require for zlib · c16a70a4
      Lars Kanis 提交于
      Zlib is used to generate the advisory lock since commit 2c2a8755 .
      
      Using the Migrator fails since then, when it is called without the rails context:
      
          NameError: uninitialized constant ActiveRecord::Migrator::Zlib
      
      This patch fixes the above error.
      c16a70a4
    • M
      Make PG deadlock error more deterministic · eabff0da
      Matthew Draper 提交于
      We've seen occasional Travis failures mentioning deadlocks. I think
      they're escaping from this test.
      eabff0da
  18. 30 9月, 2016 1 次提交
    • S
      Don't skip in-memory insertion of associations when loaded in validate · 268a5bb0
      Sean Griffin 提交于
      This was caused by 6d0d83a3. While the
      bug it's trying to fix is handled if the association is loaded in an
      after_(create|save) callback, it doesn't handle any cases that load the
      association before the persistence takes place (validation, or before_*
      filters). Instead of caring about the timing of persistence, we can just
      ensure that we're not double adding the record instead.
      
      The test from that commit actually broke, but it was not because the bug
      has been re-introduced. It was because `Bulb` in our test suite is doing
      funky things that look like STI but isn't STI, so equality comparison
      didn't happen as the loaded model was of a different class.
      
      Fixes #26661.
      268a5bb0
  19. 29 9月, 2016 1 次提交
  20. 27 9月, 2016 3 次提交
  21. 26 9月, 2016 2 次提交
    • S
      Use xor to avoid allocations in `AR::Core#hash` · a6da7938
      Sean Griffin 提交于
      This is not as good a solution as actually hashing both values, but Ruby
      doesn't expose that capability other than allocating the array. Unless we were
      to do something silly like have a thread local array that is re-used, I don't
      see any other way to do this without allocation. This solution may not be
      perfect, but it should reasonably avoid collisions to the extent that we need.
      a6da7938
    • A
      [ci skip] Update PG adapter documentation · 7caaee93
      Alex Kitchens 提交于
      Per discussion in pull request #26622:
      
      "Let's change it to PG::Error. The more specific classes mentioned are
      subclasses, and the fact the raised exception is a PG::UndefinedColumn
      doesn't change the fact that it's also a PG::Error." - matthewd
      7caaee93