- 13 2月, 2019 10 次提交
-
-
由 Ryuta Kamizono 提交于
This reverts commit eec3e28a, reversing changes made to 5588fb48. Reason: Marking as loaded without actual loading is too greedy optimization. See more context #35239. Closes #35239. [Edouard CHIN & Ryuta Kamizono]
-
由 Matthew Draper 提交于
-
由 Eileen M. Uchitelle 提交于
Add Worker Pool section to Action Cable configuration docs
-
由 Kasper Timm Hansen 提交于
Action Cable: allow multiple instances of Server::Base with different configs
-
由 Vladimir Dementyev 提交于
That allows us to create a separate, isolated Action Cable server instance within the same app.
-
由 Ryuta Kamizono 提交于
Fixed the CI failure https://travis-ci.org/rails/rails/jobs/492291248#L1185-L1191.
-
由 Eileen M. Uchitelle 提交于
Fix DatabaseSelector test that fails sometimes
-
由 Ryuta Kamizono 提交于
Currently custom attributes are always qualified by the table name in the generated SQL wrongly even if the table doesn't have the named column, it would cause an invalid SQL error. Custom attributes should only be qualified if the table has the same named column.
-
由 Xavier Noria 提交于
Zeitwerk integration
-
由 eileencodes 提交于
On CI we've seen a few test failures when the DatabaseSelectorTest runs before the ConnectionHandlersMultiDbTest. This is because it's creating 2 handlers but not properly tearing them down. Example failure: ``` Failure: ActiveRecord::ConnectionAdapters::ConnectionHandlersMultiDbTest#test_connects_to_with_single_configuration [/rails/activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:241]: Expected: 1 Actual: 2 ```
-
- 12 2月, 2019 14 次提交
-
-
由 Guillermo Iguaran 提交于
Support testing of non-ActionDispatch-routed apps.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Yuji Yaginuma 提交于
If generate application without specified options,`actioncable` and `activestorage` loads by default.
-
由 Aaron Patterson 提交于
use ProxyPattern to match for ActiveSupport::Notifications fanout/unsubscribe
-
由 zvkemp 提交于
-
由 Rafael França 提交于
Document queue_as block arguments and their use
-
由 Olivier Lacan 提交于
Currently, we only document the use case for ActiveJob's `queue_as` block arguments in [Rails Guides][1]. It seems necessary to document them in the API docs as well considering how useful and powerful this option is. [1]: https://edgeguides.rubyonrails.org/active_job_basics.html#queues [ci skip]
-
由 Ryuta Kamizono 提交于
The implicit delegation in the migration class is to be logged. It is not intended in the migration compatibility, so it should be avoided. Fixes #35224.
-
由 Gannon McGibbon 提交于
Allow deprecated non-symbol access to nested `config_for` hashes
-
由 Rafael França 提交于
Optimized namespaces_to_paths method.
-
由 Ufuk Kayserilioglu 提交于
The assertion from the previous PR had the expected and the actual values in the wrong order, so when a test failed the error message was confusing. This commit fixes the problem by switching the order.
-
由 Ufuk Kayserilioglu 提交于
A change to `Rails::Application.config_for` in https://github.com/rails/rails/pull/33815 and https://github.com/rails/rails/pull/33882 has altered the behaviour of the returned object in a breaking manner. Before that change, nested hashes returned from `config_for` could be accessed using non-symbol keys. After the change, all keys are recursively symbolized so non-symbol access fails to read the expected values. This is a breaking change for any app that might be relying on the nested hashes returned from `config_for` calls, and thus should be deprecated before being removed from the codebase. This commit introduces a temporary `NonSymbolAccessDeprecatedHash` class that recursively wraps any nested hashes inside the `OrderedOptions` object returned from `config_for` and issues a deprecation notice when a non-symbol based access is performed. This way, apps that are still relying on the ability to access these nested hashes using non-symbol keys will be able to observe the deprecation notices and have time to implement changes before non-symbol access is removed for good. A CHANGELOG entry is also added to note that non-symbol access to nested `config_for` hashes is deprecated.
-
由 alkesh26 提交于
-
- 11 2月, 2019 13 次提交
-
-
由 Gannon McGibbon 提交于
Clarify collection proxy docs
-
由 Ryuta Kamizono 提交于
This reverts commit b46601b5, reversing changes made to 4e6737f1.
-
由 Ryuta Kamizono 提交于
-
由 Eileen M. Uchitelle 提交于
Correct JavaScript guide example
-
由 Matthew Draper 提交于
Avoid extra package install
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
SQLite3: Implement `add_foreign_key` and `remove_foreign_key`
-
由 Ryuta Kamizono 提交于
This reverts commit 141f50ef, reversing changes made to 317efa5c. Reason: `add_foreign_key` and `remove_foreign_key` are implemented at #35212. [ci skip]
-
由 Ryuta Kamizono 提交于
I implemented Foreign key create in `create_table` for SQLite3 at #24743. This follows #24743 to implement `add_foreign_key` and `remove_foreign_key`. Unfortunately SQLite3 has one limitation that `PRAGMA foreign_key_list(table-name)` doesn't have constraint name. So we couldn't implement find/remove foreign key by name for now. Fixes #35207. Closes #31343.
-
由 Ryuta Kamizono 提交于
-
由 yuuji.yaginuma 提交于
Some tests are running yarn install during the test. The directory used for isolation test is not subject to yarn workspace, and it occurs because the required package is not installed. In order to avoid this, I fixed all necessary packages to be installed before run test and use symlink to `node_modules`. This is a bit complicated, as `yarn install` needs to be run in a specific directory before running the test. However, running `yarn install` every time run the test is expensive when testing locally and should be avoided.
-
由 Yuji Yaginuma 提交于
This reverts commit 38f9e41f, reversing changes made to 5e493c3b. Reason: The ajv@6.9.1 was released that fixes issue.
-
由 Charlie Jonas 提交于
Swap `#users` jQuery selector to correct position and prevent the escaping of HTML.
-
- 10 2月, 2019 3 次提交
-
-
由 Yuji Yaginuma 提交于
Avoid ajv@6.9.0 for now
-
由 yuuji.yaginuma 提交于
Because ajv@6.9.0 does not work with webpack. Ref: https://github.com/epoberezkin/ajv/issues/941
-