- 25 12月, 2014 9 次提交
-
-
由 claudiob 提交于
The methods in these modules are not used anywhere. They used to be invoked in polymorphic_routes.rb but their usage was removed in e8210450. What is your opinion about removing these methods? They do belong to the public API, but in reality their code has already been duplicated to ActionView::ModelNaming, since they are used by methods like `dom_id` and `dom_class` to associated records with DOM elements (in ActionView). Please tell me if you think that removing this module is a good idea and, in that case, if the PR is okay as it is, or you'd rather start by showing a deprecation message, and remove the module in Rails 5.1.
-
由 Zachary Scott 提交于
List the Active Support Instrumentation guide in the index (as WIP)
-
由 Zachary Scott 提交于
-
由 Zachary Scott 提交于
Fix grammar in Caching with Rails docs
-
由 Elaine Fang 提交于
-
由 Robin Dupret 提交于
-
由 Ivan Tkalin 提交于
-
由 Arun Agrawal 提交于
Fix bug in ActionMailer guide.
-
由 Dan Bernier 提交于
When setting a mailer's default from address, you have to pass a hash with a `:from` key; you can't pass just an email address.
-
- 24 12月, 2014 17 次提交
-
-
由 Sean Griffin 提交于
Add support for Reply-To field in mail_to helper
-
由 Sean Griffin 提交于
Removed unused parameter to cookie serialize method
-
由 Vipul A M 提交于
-
由 Sean Griffin 提交于
Describe full behaviour of Active Record's attribute query methods
-
由 Michael D.W. Prendergast 提交于
Clarify that query methods have a custom definition of whether a numeric value is present. [ci skip] The way Active Record query methods handle numeric values is a special case, and is not part of Rails's standard definition of present. This update attempts to make this more clear in the docs, so that people don't expect Object#present? to return false if used on a number that is zero.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
References #18148.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Sean Griffin 提交于
Remove unneeded special case to calculate size for has_many :through
-
由 Bogdan Gusiev 提交于
All cases are properly handled in CollectionAssociation for all subclasses of this association
-
由 Sean Griffin 提交于
[ci skip]
-
由 Sean Griffin 提交于
We were ignoring the `default_value?` escape clause in the serialized type, which caused the default value to always be treated as changed. Fixes #18169
-
由 Guo Xiang Tan 提交于
-
由 Sean Griffin 提交于
The code for `TableDefinition#references` and `SchemaStatements#add_reference` were almost identical both structurally, and in terms of domain knowledge. This removes that duplication into a common class, using the `Table` API as the expected interface of its collaborator.
-
由 Sean Griffin 提交于
This isn't Seattle.rb, @senny. ;)
-
- 23 12月, 2014 14 次提交
-
-
由 Sean Griffin 提交于
Fix connection leak when a thread checks in additional connections.
-
由 Sean Griffin 提交于
Remove block from super
-
由 Matt Jones 提交于
The code in `ConnectionPool#release` assumed that a single thread only ever holds a single connection, and thus that releasing a connection only requires the owning thread_id. There is a trivial counterexample to this assumption: code that checks out additional connections from the pool in the same thread. For instance: connection_1 = ActiveRecord::Base.connection connection_2 = ActiveRecord::Base.connection_pool.checkout ActiveRecord::Base.connection_pool.checkin(connection_2) connection_3 = ActiveRecord::Base.connection At this point, connection_1 has been removed from the `@reserved_connections` hash, causing a NEW connection to be returned as connection_3 and the loss of any tracking info on connection_1. As long as the thread in this example lives, connection_1 will be inaccessible and un-reapable. If this block of code runs more times than the size of the connection pool in a single thread, every subsequent connection attempt will timeout, as all of the available connections have been leaked. Reverts parts of 9e457a86 and essentially all of 4367d2f0
-
由 Jose Añasco 提交于
-
由 Sean Griffin 提交于
Here you go, @senny.
😁 -
由 Sean Griffin 提交于
Add information about "allow_destroy" requiring an ID. [ci skip]
-
由 Sean Griffin 提交于
Conflicts: activerecord/CHANGELOG.md
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-
由 George Millo 提交于
I just wasted an absurd amount of time trying to figure out why my model wasn't being deleted even though I was setting `_destroy` to true like the instructions said. Making the documentation a little bit clear so that someone like me doesn't waste their time in future.
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Fixing numeric attrs when set to same negative value
-
由 Yves Senn 提交于
fix typo in nodoc [ci skip]
-
由 yuuji.yaginuma 提交于
-