- 13 9月, 2012 7 次提交
-
-
由 Matt Jones 提交于
-
由 Thiago Pradi 提交于
-
由 Jon Leighton 提交于
In some circumstances engine was Arel::Table.engine which for separate reasons was an ActiveRecord::Model::DeprecationProxy, which caused a deprecation warning. In any case, we want the actual model class here, since we want to use it to infer information about associations.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
Previously the reflection would be looked up on the wrong class. However the test passed because the examples referred back to themselves.
-
由 Marc-Andre Lafortune 提交于
-
由 Robert Evans 提交于
single-table inheritance by overriding it in your ActiveRecord Model.
-
- 12 9月, 2012 5 次提交
-
-
由 Arun Agrawal 提交于
1. Unused variable 2. possibly useless use of a variable in void context
-
由 Grace Liu 提交于
- added tests to confirm establish_connection uses DATABASE_URL and Rails.env correctly even when no arguments are passed in. - updated rake db tasks to support DATABASE_URL, and added tests to confirm correct behavior for these rake tasks. (Removed establish_connection call from some tasks since in those cases the :environment task already made sure the function would be called) - updated Resolver so that when it resolves the database url, it removes hash values with empty strings from the config spec (e.g. to support connection to postgresql when no username is specified).
-
由 beerlington 提交于
Allows you to specify the model association key in a belongs_to relationship instead of the foreign key. The following queries are now equivalent: Post.where(:author_id => Author.first) Post.where(:author => Author.first) PriceEstimate.where(:estimate_of_type => 'Treasure', :estimate_of_id => treasure) PriceEstimate.where(:estimate_of => treasure)
-
由 kennyj 提交于
-
由 kennyj 提交于
-
- 11 9月, 2012 1 次提交
-
-
由 Jonathan Rochkind 提交于
As a result of different commits, ConnectionPool had become of two minds about exceptions, sometimes using PoolFullError and sometimes using ConnectionTimeoutError. In fact, it was using ConnectionTimeoutError internally, but then recueing and re-raising as a PoolFullError. There's no reason for this bifurcation, standardize on ConnectionTimeoutError, which is the rails2 name and still accurately describes semantics at this point. History In Rails2, ConnectionPool raises a ConnectionTimeoutError if it can't get a connection within timeout. Originally in master/rails3, @tenderlove had planned on removing wait/blocking in connectionpool entirely, at that point he changed exception to PoolFullError. But then later wait/blocking came back, but exception remained PoolFullError. Then in 02b23355 pmahoney introduced fair waiting logic, and brought back ConnectionTimeoutError, introducing the weird bifurcation. ConnectionTimeoutError accurately describes semantics as of this point, and is backwards compat with rails2, there's no reason for PoolFullError to be introduced, and no reason for two different exception types to be used internally, no reason to rescue one and re-raise as another. Unify!
-
- 10 9月, 2012 2 次提交
-
-
由 kennyj 提交于
-
由 Sebastian Korfmann 提交于
Exception message was misleading, as it is possible to have a polymorphic 'has_many :through' join model.
-
- 09 9月, 2012 4 次提交
-
-
由 Vijay Dev 提交于
-
由 Arun Agrawal 提交于
-
由 Ernie Miller 提交于
When calling a query method on an attribute that was not selected by an ActiveRecord query, an ActiveModel::MissingAttributeError is not raised. Instead, a nil value is returned, which will return false once cast to boolean. This is undesirable, as we should not give the impression that we know the attribute's boolean value when we haven't loaded the attribute's (possibly) non-boolean value from the database. This issue is present on versions going back as far as 2.3, at least.
-
由 Francesco Rodriguez 提交于
-
- 08 9月, 2012 4 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Konstantin Shabanov 提交于
-
由 Carlos Antonio da Silva 提交于
* There is no need to delete the primary key from cloned attributes, since it sets the same pk to nil afterwards. * Check for empty? instead of any? to run initialize callbacks.
-
由 Aaron Patterson 提交于
transaction.
-
- 07 9月, 2012 2 次提交
-
-
由 Jan Bernacki 提交于
move validation to AR
-
由 Yves Senn 提交于
-
- 06 9月, 2012 4 次提交
-
-
由 Dickson S. Guedes 提交于
This implements the support to encode/decode JSON data to/from database and creating columns of type JSON using a native type [1] supported by PostgreSQL from version 9.2. [1] http://www.postgresql.org/docs/9.2/static/datatype-json.html
-
由 Ian Lesperance 提交于
-
由 Andreas Loupasakis 提交于
-
由 Seamus Abshere 提交于
The previous implementation had the strange requirement that db/structure.sql contain only CREATE TABLE sql statements, one per table, separated by double newlines. SQLite3 and PostgreSQL database tasks, on the other hand, simply spawn 'sqlite3' and 'psql' binaries to load the file directly. The new implementation follows this and attempts to respect all current MySQL configuration settings.
-
- 05 9月, 2012 3 次提交
-
-
由 Matt Jones 提交于
-
由 Adam Meehan 提交于
The string_to_dummy_time method was blindly parsing the dummy time string with Date._parse which returns a hash for the date part regardless of whether the time part is an invalid time string.
-
由 Konstantin Shabanov 提交于
-
- 03 9月, 2012 2 次提交
-
-
由 Yves Senn 提交于
I had to create a new table because I needed an STI table, which does not have both a "type" and a "custom_type" the test fails with: 1) Error: test_alt_becomes_works_with_sti(InheritanceTest): NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber"> /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes' test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti' test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
-
由 Anuj Dutta 提交于
-
- 01 9月, 2012 1 次提交
-
-
由 Jon Leighton 提交于
This is purely a performance optimisation. See https://gist.github.com/3552829
-
- 31 8月, 2012 5 次提交
-
-
由 Jon Leighton 提交于
This is a performance/GC optimisation. In theory, this could be optimised by the implementation (last time I checked, this would have no effect on JRuby). But in practise, this make attribute access faster.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
We don't need separate @class_to_pool and @connection_pool hashes.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
* Loop rather than recurse in retrieve_connection_pool * Key the hash by class rather than class name. This avoids creating unnecessary strings.
-