1. 10 12月, 2019 5 次提交
    • J
      Database URL supports query value with equal sign · 43a6420e
      Joshua Flanagan 提交于
      A querystring value should be allowed to include an equal sign `=`.
      
      This is necessary to support passing `options` for a PostgresSQL connection.
      
      ```
      
      development:
        url: postgresql://localhost/railsdevapp_development?options=-cmysetting.debug=on
      ```
      
      Before this PR, attempting to start the rails process with that configuration would result in an error:
      
      ```
      > bundle exec rails console
      Traceback (most recent call last):
      	49: from bin/rails:4:in `<main>'
      	48: from bin/rails:4:in `require'
      ...
      	 1: from /rails/activerecord/lib/active_record/database_configurations/connection_url_resolver.rb:58:in `query_hash'
      /rails/activerecord/lib/active_record/database_configurations/connection_url_resolver.rb:58:in `[]': invalid number of elements (3 for 1..2) (ArgumentError)
      ```
      
      After this PR, rails can properly parse the configuration:
      
      ```
      > bundle exec rails console
      Loading development environment (Rails 6.1.0.alpha)
      2.6.5 :001 > ActiveRecord::Base.connection.select_all("show mysetting.debug").to_a
         (0.4ms)  show mysetting.debug
       => [{"mysetting.debug"=>"on"}]
      ```
      43a6420e
    • R
      Merge pull request #37798 from Edouard-chin/ec-sqlite3-connection-transaction · b4ab1f19
      Rafael França 提交于
      Added posibility to open a `read_uncommitted` transaction on SQLite:
      b4ab1f19
    • R
      Merge pull request #37827 from Edouard-chin/ec-activejob-enqueuing · 9926fd86
      Rafael França 提交于
      Don't run AJ after_enqueue / after_perform when chain is halted:
      9926fd86
    • E
      Don't run AJ after_enqueue / after_perform when chain is halted: · bbfab0b3
      Edouard CHIN 提交于
      - ### Problem
      
        ```ruby
          MyJob < ApplicationJob
            before_enqueue { throw(:abort) }
            after_enqueue { # enters here }
          end
        ```
        I find AJ behaviour on after_enqueue and after_perform callbacks
        weird as they get run even when the callback chain is halted.
        It's counter intuitive to run the after_enqueue callbacks even
        though the job wasn't event enqueued.
      
        ### Solution
      
        In Rails 6.2, I propose to make the new behaviour the default
        and stop running after callbacks when the chain is halted.
        For application that wants this behaviour now or in 6.1
        they can do so by adding the `config.active_job.skip_after_callbacks_if_terminated = true`
        in their configuration file.
      bbfab0b3
    • R
      Merge pull request #37830 from Edouard-chin/ec-activejob-enqueue-and-perform-log · 7f4d222c
      Rafael França 提交于
      Fix ActiveJob logging when callback chain is halted:
      7f4d222c
  2. 09 12月, 2019 8 次提交
  3. 08 12月, 2019 3 次提交
  4. 07 12月, 2019 10 次提交
  5. 06 12月, 2019 14 次提交