- 19 6月, 2018 4 次提交
-
-
由 Rafael França 提交于
Fix Ruby version in `.ruby-version`
-
由 bogdanvlviv 提交于
Since #30016 Rails generates `.ruby-version` file in order to help Ruby version manager tools like `rbenv`, `rvm` determine which Ruby version should be used for the current Rails project. Since #32649 Rails sets Ruby version to the file compatible with MRI/JRuby by default. Pull Request #31496 reports that `.ruby-version` doesn't match ruby version other than stable version and recommends to use `ENV["RBENV_VERSION"]`, and `ENV["rvm_ruby_string"]` in order to set correct Ruby version to the file that `rbenv` or `rvm` can understand. Also, there is another similar issue that reports the same case if use JRuby https://github.com/jruby/jruby/issues/5144. Closes #31496, https://github.com/jruby/jruby/issues/5144.
-
由 Eileen M. Uchitelle 提交于
Add test case for the `|` token in Journey scanner
-
由 vaidehijoshi 提交于
Journey's scanner tokenizes the `|` (:OR) operator when scanning route urls such as `"/:foo|*bar"`. However, the current scanner test does not have any test cases for the `|` operator. This commit adds a test case for this particular token.
-
- 18 6月, 2018 4 次提交
-
-
由 Ryuta Kamizono 提交于
Add docs for ActiveRecord::Migration#say, #say_with_time, #suppress_messages [ci skip]
-
由 Ryuta Kamizono 提交于
`touch` option was added to `increment!` (#27660) and `update_counters` (#26995). But that option behaves inconsistently with `Persistence#touch` method. If `touch` option is passed attribute names, it won't update update_at/on attributes unlike `Persistence#touch` method. Due to changed from `Persistence#touch` to `increment!` with `touch` option, #31405 has a regression that `counter_cache` with `touch` option which is passed attribute names won't update update_at/on attributes. I think that the inconsistency is not intended. To get back consistency, ensure that `touch` option updates update_at/on attributes.
-
由 Naoki Nishiguchi 提交于
-
由 yuuji.yaginuma 提交于
`optparse` is unused since #26977.
-
- 17 6月, 2018 1 次提交
-
- 16 6月, 2018 1 次提交
-
-
由 yuuji.yaginuma 提交于
It is necessary to specify a value to `config.active_storage`.
-
- 15 6月, 2018 4 次提交
-
-
由 Yuji Yaginuma 提交于
Fix rubocop violations
-
由 bogdanvlviv 提交于
https://codeclimate.com/github/rails/rails/issues `bundle exec rubocop -a` Related to e4e1b620
-
由 Rafael França 提交于
Update example for whitelisting arbitrary hashes
-
由 Michael Holroyd 提交于
Since the ability to whitelist arbitrary hashes was added (https://github.com/rails/rails/issues/9454 was resolved by https://github.com/rails/rails/commit/e86524c0c5a26ceec92895c830d1355ae47a7034), this example is no longer outside of what strong_params can do. Moved this specific example out of the "Outside the Scope" section and into the regular "Examples" section, but left the "Outside the Scope" section as it was since the advice is still relevant for weirder whitelisting situations (maybe someone wants to add a new example that can't be handled natively).
-
- 14 6月, 2018 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 13 6月, 2018 4 次提交
-
-
由 Ryuta Kamizono 提交于
Allow prefix/suffix options for store accessors
-
由 Ryuta Kamizono 提交于
Update "Active Support Core Extensions" Guide [ci skip]
-
由 bogdanvlviv 提交于
Remove general sentence that explains that all methods that Active Support brings to `Date` `Time`, `DateTime` are defined in `active_support/core_ext/date/calculations.rb` since it isn't true. Add a references to an appropriate file where methods are defined like it is done with the other methods in this guide. Context https://github.com/rails/rails/pull/32552#discussion_r181216246 Related to #32543, #32552 [ci skip]
-
由 Eileen Uchitelle 提交于
This may seem like an unnecessary refactoring but some apps want / need to configure the information passed to the query cache logger. In order to do that we can add a method here that can be easily overridden by the app itself, rather than hacking the query cache logger to include that information. To override apps can call ``` def cache_notifications_info super.merge(connected_host: "hostname") end ``` This will take what's already in the query cache logger and add `@something="yea"` to the object. At GitHub we use this to log the number of queries that are cached, the connection host and the connection url.
-
- 12 6月, 2018 19 次提交
-
-
由 Yukio Mizuta 提交于
-
由 Matthew Draper 提交于
Remove reference to session_store.rb initializer
-
由 Justin Searls 提交于
Rails no longer generates this file, but Google is still packed with results suggesting it should exist, so that the doc still pointed me to it threw me off (had I deleted it or something?). Probably be better to be vague and prompt the user to stick it in a config file they own. #33124
-
由 Ryuta Kamizono 提交于
Add comma to example in guides/source/active_storage_overview.md [ci skip]
-
由 Matt Sias 提交于
-
由 Ryuta Kamizono 提交于
Add changelog for #32956 [ci skip]
-
由 bogdanvlviv 提交于
Add mention about default value of `config.active_model.i18n_full_message`.
-
由 Ryuta Kamizono 提交于
Fix active_model/errors docs [ci skip]
-
由 bogdanvlviv 提交于
- Fix indentation. - Add a missing dot to the end of the sentence. Related to #32956
-
由 Xavier Noria 提交于
Remove backticks around proejct names
-
由 Rafael França 提交于
Fix bug with eager_load in development environment
-
由 utilum 提交于
[ci skip]
-
由 Dan Jensen 提交于
Modifies the routes simulator to allow for empty RouteSets, which are created when secondary Engines are loaded.
-
由 Rafael Mendonça França 提交于
Improve some DateAndTime calculations
-
由 Rafael França 提交于
Remove ineffective no-warnings flags from Contribute guide
-
由 Rafael França 提交于
Dev-Dep guide: mention AST third party requirements
-
由 Rafael Mendonça França 提交于
It mark the association as loaded and this can cause the object to be in an stale state.
-
由 Rafael França 提交于
Remove redundant accessors in AC test stub
-
由 Rafael Mendonça França 提交于
This also mark the association as loaded given we changed it in memory and avoid the next access to the reader to make a query to the databse.
-
- 11 6月, 2018 2 次提交
-
-
由 Rafael Mendonça França 提交于
Use hash lookup for deleting existing associations from `target`
-