- 03 11月, 2013 1 次提交
-
-
由 David Heinemeier Hansson 提交于
Revert "ActiveRecord::Base#<=> has been removed. Primary keys may not be in order," -- will be replaced with a check to ensure that the keys used for comparison are integers, and only fail if they are not. This reverts commit 6256734e. Conflicts: activerecord/CHANGELOG.md
-
- 31 10月, 2013 1 次提交
-
-
由 Yves Senn 提交于
-
- 25 10月, 2013 1 次提交
-
-
由 Yves Senn 提交于
-
- 30 9月, 2013 1 次提交
-
-
由 Yves Senn 提交于
marshalling between processes does not work with an in-memory db. This breaks the `test_sqlite3_mem` run (see stacktrace below). After that failure most tests start to fail randomly. ``` /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:512:in `table_structure': Could not find table 'posts' (ActiveRecord::StatementInvalid) from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:399:in `columns' from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:93:in `block in prepare_default_proc' from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:44:in `yield' from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:44:in `columns' from /Users/senny/Projects/rails/activerecord/lib/active_record/model_schema.rb:208:in `columns' from /Users/senny/Projects/rails/activerecord/lib/active_record/model_schema.rb:249:in `column_defaults' from /Users/senny/Projects/rails/activerecord/lib/active_record/locking/optimistic.rb:171:in `column_defaults' from /Users/senny/Projects/rails/activerecord/lib/active_record/core.rb:167:in `initialize' from /Users/senny/Projects/rails/activerecord/lib/active_record/inheritance.rb:27:in `new' from /Users/senny/Projects/rails/activerecord/lib/active_record/inheritance.rb:27:in `new' from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1368:in `block in test_marshal_between_processes' from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1366:in `fork' from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1366:in `test_marshal_between_processes' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:110:in `block (3 levels) in run' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:208:in `capture_exceptions' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:107:in `block (2 levels) in run' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:260:in `time_it' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:106:in `block in run' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:296:in `on_signal' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:280:in `with_info_handler' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:105:in `run' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:268:in `block (2 levels) in run' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:267:in `each' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:267:in `block in run' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:296:in `on_signal' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:285:in `with_info_handler' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:266:in `run' from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `block in __run' from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `map' from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `__run' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:115:in `run' from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:46:in `block in autorun' ``` /cc @tenderlove
-
- 28 9月, 2013 1 次提交
-
-
由 Marc Lennox 提交于
-
- 19 9月, 2013 4 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
or even be numbers, so sorting by id doesn't make sense. Please use `sort_by` and specify the attribute you wish to sort with. For example, change: Post.all.to_a.sort to: Post.all.to_a.sort_by(&:id)
-
由 Aaron Patterson 提交于
-
- 12 9月, 2013 1 次提交
-
-
由 Rafael Mendonça França 提交于
When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023
-
- 01 9月, 2013 4 次提交
-
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit baf5f47b. Reason: This is breaking the sqlite3 tests with a missing transacion. Could not investigate right now. cc @tenderlove
-
由 Rafael Mendonça França 提交于
The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023
-
- 31 8月, 2013 3 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 12 8月, 2013 1 次提交
-
-
由 Akira Matsuda 提交于
-
- 08 8月, 2013 2 次提交
-
-
由 Koichi Sasada 提交于
-
由 Aaron Patterson 提交于
-
- 07 8月, 2013 1 次提交
-
-
由 Yves Senn 提交于
This commit fixes the build but we need to further investigate the root cause, to see if it can be fixed. The test fails under `MysqlAdapter` with: ``` ActiveRecord::UnknownAttributeError: unknown attribute: なまえ ``` The root cause is that the returned column names from the adapter have the wrong encoding: ```ruby columns = Weird.columns_hash.keys columns # => ["id", "a$b", "\xE3\x81\xAA\xE3\x81\xBE\xE3\x81\x88", "from"] columns.map(&:encoding) # => [#<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>] columns.map {|c| c.dup.force_encoding "utf-8"} # => ["id", "a$b", "なまえ", "from"] ``` From what I can tell the MySQL variables are fine: ``` ActiveRecord::Base.connection.execute("show variables") ... character_set_client utf8 character_set_connection utf8 character_set_database utf8 character_set_filesystem binary character_set_results utf8 character_set_server utf8 character_set_system utf8 character_sets_dir /usr/local/Cellar/mysql/5.5.29/share/mysql/charsets/ collation_connection utf8_general_ci collation_database utf8_unicode_ci collation_server utf8_general_ci ... ```
-
- 06 8月, 2013 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 09 7月, 2013 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 02 6月, 2013 1 次提交
-
-
由 kennyj 提交于
-
- 01 6月, 2013 1 次提交
-
-
由 kennyj 提交于
-
- 22 5月, 2013 3 次提交
-
-
由 Takehiro Adachi 提交于
The method got extracted out from AR::Base in commit d916c62c, but the tests never did.
-
由 Takehiro Adachi 提交于
The method itself got extracted out from ActiveRecored::Base in commit ceb33f84, but the test code never did.
-
由 Takehiro Adachi 提交于
The methods got moved to core.rb in commit b2c9ce34, but the tests never did.
-
- 18 5月, 2013 1 次提交
-
-
由 Takehiro Adachi 提交于
Due to commit 0123c39f, column topic.unique_replies_count has been added, and these test started to fail since the tests depends on the topic tables column info.
-
- 02 5月, 2013 1 次提交
-
-
由 Takehiro Adachi 提交于
`AR::Base#to_param` and `AR::Base#cache_key` is defined at active_record/integration.rb, so tests for those methods should be at integration_test.rb
-
- 13 4月, 2013 1 次提交
-
-
由 Xavier Noria 提交于
Existing code was delegating to the instance with delegate macro calls, or invoking the instance method to reach the object and call its instance methods. But the point is to have a clean class-level interface where the thread local instance is hidden in the implementation. References #11c69738. References #10198.
-
- 10 4月, 2013 1 次提交
-
-
由 wangjohn 提交于
PerThreadRegistry module.
-
- 09 4月, 2013 1 次提交
-
-
由 wangjohn 提交于
current_scope and ignore_default_scope locals are brought together under a registry object.
-
- 04 4月, 2013 1 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
- 28 3月, 2013 1 次提交
-
-
由 Alexander Balashov 提交于
-
- 27 3月, 2013 1 次提交
-
-
由 Sam Saffron 提交于
-
- 26 3月, 2013 1 次提交
-
-
由 Martin Schürrer 提交于
-
- 22 3月, 2013 1 次提交
-
-
由 Vipul A M 提交于
Introduce test on Error#full_message for attribute with underscores; Fix some typos
-
- 20 3月, 2013 1 次提交
-
-
由 Josh Adams 提交于
Type a fixo.
-
- 18 3月, 2013 1 次提交
-
-
由 Takehiro Adachi 提交于
These tests should be in inheritance_test.rb since its testing a feature which is implemented in inheritance.rb
-