1. 03 11月, 2013 1 次提交
  2. 31 10月, 2013 1 次提交
  3. 25 10月, 2013 1 次提交
  4. 30 9月, 2013 1 次提交
    • Y
      fix `test_sqlite3_mem` test run. · 93899335
      Yves Senn 提交于
      marshalling between processes does not work with an in-memory db.
      This breaks the `test_sqlite3_mem` run (see stacktrace below).
      After that failure most tests start to fail randomly.
      
      ```
      /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:512:in `table_structure': Could not find table 'posts' (ActiveRecord::StatementInvalid)
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:399:in `columns'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:93:in `block in prepare_default_proc'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:44:in `yield'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/schema_cache.rb:44:in `columns'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/model_schema.rb:208:in `columns'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/model_schema.rb:249:in `column_defaults'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/locking/optimistic.rb:171:in `column_defaults'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/core.rb:167:in `initialize'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/inheritance.rb:27:in `new'
      	from /Users/senny/Projects/rails/activerecord/lib/active_record/inheritance.rb:27:in `new'
      	from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1368:in `block in test_marshal_between_processes'
      	from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1366:in `fork'
      	from /Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:1366:in `test_marshal_between_processes'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:110:in `block (3 levels) in run'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:208:in `capture_exceptions'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:107:in `block (2 levels) in run'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:260:in `time_it'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:106:in `block in run'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:296:in `on_signal'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:280:in `with_info_handler'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest/test.rb:105:in `run'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:268:in `block (2 levels) in run'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:267:in `each'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:267:in `block in run'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:296:in `on_signal'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:285:in `with_info_handler'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:266:in `run'
      	from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `block in __run'
      	from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `map'
      	from /Users/senny/Projects/rails/activesupport/lib/active_support/test_case.rb:31:in `__run'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:115:in `run'
      	from /Users/senny/Projects/rails/.bundle/gems/minitest-5.0.8/lib/minitest.rb:46:in `block in autorun'
      ```
      
      /cc @tenderlove
      93899335
  5. 28 9月, 2013 1 次提交
  6. 19 9月, 2013 4 次提交
  7. 12 9月, 2013 1 次提交
    • R
      Check if the SQL is not a prepared statement · f13b2785
      Rafael Mendonça França 提交于
      When the adapter is with prepared statement disabled and the binds array
      is not empty the connection adapter will try to set the binds values and
      will fail. Now we are checking if the adapter has the prepared statement
      disabled.
      
      Fixes #12023
      f13b2785
  8. 01 9月, 2013 4 次提交
  9. 31 8月, 2013 3 次提交
  10. 12 8月, 2013 1 次提交
  11. 08 8月, 2013 2 次提交
  12. 07 8月, 2013 1 次提交
    • Y
      skip `test_unicode_column_name` for `MysqlAdapter`. · da49e9a9
      Yves Senn 提交于
      This commit fixes the build but we need to further investigate the root cause,
      to see if it can be fixed.
      
      The test fails under `MysqlAdapter` with:
      
      ```
      ActiveRecord::UnknownAttributeError: unknown attribute: なまえ
      ```
      
      The root cause is that the returned column names from the adapter
      have the wrong encoding:
      
      ```ruby
      columns = Weird.columns_hash.keys
      columns # => ["id", "a$b", "\xE3\x81\xAA\xE3\x81\xBE\xE3\x81\x88", "from"]
      columns.map(&:encoding) # => [#<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>]
      columns.map {|c| c.dup.force_encoding "utf-8"} # => ["id", "a$b", "なまえ", "from"]
      ```
      
      From what I can tell the MySQL variables are fine:
      
      ```
      ActiveRecord::Base.connection.execute("show variables")
      
      ...
      character_set_client utf8
      character_set_connection utf8
      character_set_database utf8
      character_set_filesystem binary
      character_set_results utf8
      character_set_server utf8
      character_set_system utf8
      character_sets_dir /usr/local/Cellar/mysql/5.5.29/share/mysql/charsets/
      collation_connection utf8_general_ci
      collation_database utf8_unicode_ci
      collation_server utf8_general_ci
      ...
      ```
      da49e9a9
  13. 06 8月, 2013 1 次提交
  14. 09 7月, 2013 1 次提交
  15. 02 6月, 2013 1 次提交
  16. 01 6月, 2013 1 次提交
  17. 22 5月, 2013 3 次提交
  18. 18 5月, 2013 1 次提交
  19. 02 5月, 2013 1 次提交
  20. 13 4月, 2013 1 次提交
    • X
      hides the per thread registry instance, and caches singleton methods · e5ef3abd
      Xavier Noria 提交于
      Existing code was delegating to the instance with delegate
      macro calls, or invoking the instance method to reach
      the object and call its instance methods.
      
      But the point is to have a clean class-level interface where
      the thread local instance is hidden in the implementation.
      
      References #11c69738.
      References #10198.
      e5ef3abd
  21. 10 4月, 2013 1 次提交
  22. 09 4月, 2013 1 次提交
  23. 04 4月, 2013 1 次提交
  24. 28 3月, 2013 1 次提交
  25. 27 3月, 2013 1 次提交
  26. 26 3月, 2013 1 次提交
  27. 22 3月, 2013 1 次提交
  28. 20 3月, 2013 1 次提交
  29. 18 3月, 2013 1 次提交