Closes #3104.

Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.

Fix problem with loading polymorphic associations which have been defined in an abstract superclass. Fixes #552.

Rename Reflection#through_reflection_chain and #through_options to Reflection#chain and Reflection#options as they now no longer relate solely to through associations.

Push source_type and polymorphic conditions out of ThroughAssociation and JoinDependency::JoinAssociation and into the reflection instead.

Construct an actual ActiveRecord::Relation object for the association scope, rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.

Implement deprecated version of AssociationReflection#primary_key_name, which has been renamed to #foreign_key. Also bumping the deprecation_horizon in Active Support to 3.1.

Rename AssociationReflection#primary_key_name to foreign_key, since the options key which it relates to is :foreign_key

Improved strategy for updating a belongs_to association when the foreign key changes. Rather than resetting each affected association when the foreign key changes, we should lazily check for 'staleness' (where fk does not match target id) when the association is accessed.

Fix problem where wrong keys are used in JoinAssociation when an association goes :through a belongs_to [#2801 state:resolved]

[#4945 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: Nwycats <wycats@gmail.com>

Moved the validation logic to the association reflection and refactored autosave_association.rb a bit.

Add AssociationReflection#collection_association? which returns true if it's for a has_many or has_and_belongs_to_many association.

Changed ActiveRecord::Base.store_full_sti_class to be true by default reflecting the previously announced Rails 3 default [DHH]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Move validator, human_name and human_attribute_name to ActiveModel, remove deprecated error messages and add i18n_scope and lookup_ancestors.
Signed-off-by: NCarl Lerche <carllerche@mac.com>

Make has_one with :conditions hash scope build or creation of the associated object with those conditions
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#3088 state:committed]

Fix has_one with foreign_key and primary_key association bug which caused the associated object being lost when saving the owner. [#1756 state:resolved]

Mixed in a bit from patch by ransom-briggs. [#2813 state:resolved]
Signed-off-by: NEloy Duran <eloy.de.enige@gmail.com>

Explicitely setting `autosave => false' should override new_record autosaving. [#2214 state:resolved]

Original author is Jacob.

[#2934 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

[#765 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Revert "Revert "Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [#2118 state:resolved]""

This reverts commit 80f1f863.

The feature doesn't work on Postgres, so don't test it on Postgres.
Also, Postgres compatibility is irrelevant to the ticket/patch in question.

This gives you 'Post comment' rather than 'Postcomment' by default.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#2120 state:committed]

Revert "Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [#2118 state:resolved]"

This reverts commit 4851ca9e.

The tests do not pass for postgresql.

Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [#2118 state:resolved]
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>