- 23 3月, 2017 34 次提交
-
-
由 claudiob 提交于
The "-j" option was added 5 years ago (https://github.com/rails/rails/commit/d9c39c3a) when we wanted to support prototype-rails and jquery-rails. Prototype is not as popular and jQuery is not a requirement anymore. Still the "-j" option can be used to install *any* gem that ends in "-rails". This "might" open security issues and does not bring great benefits anymore. If you know which "-rails"-ending gem you want to install, you can manually add it to the Gemfile just like any other gem.
-
由 Kasper Timm Hansen 提交于
Fix duplicable? for Rational and Complex on ruby master, since they are now duplicable
-
由 Vipul A M 提交于
-
由 Vipul A M 提交于
Move comment to inside the method [ci skip]
-
由 Fumiaki MATSUSHIMA 提交于
Because this comment is not document for `supports_ranges?` ref: https://github.com/rails/rails/pull/27636#discussion_r107560081
-
由 Rafael França 提交于
Remove `CollectionProxy#uniq`
-
由 Ryuta Kamizono 提交于
Since #28473 `uniq` is delegated to `records`, so `CollectionProxy#uniq` is unnecessary.
-
由 Rafael França 提交于
Document AC::Connection::Authorization#reject_unauthorized_connection
-
由 Rafael França 提交于
List options for `rails new --webpack=WEBPACK`
-
由 T.J. Schuck 提交于
This method is repeatedly used throughout the docs (in the [AC::Connection docs](https://github.com/rails/rails/blob/12b684985837bc8ee9ad15c174cf4e07ca82d7c4/actioncable/lib/action_cable/connection/base.rb#L28), the [AC README](https://github.com/rails/rails/blob/12b684985837bc8ee9ad15c174cf4e07ca82d7c4/actioncable/README.md#a-full-stack-example), the [AC Guides](https://github.com/rails/rails/blob/12b684985837bc8ee9ad15c174cf4e07ca82d7c4/guides/source/action_cable_overview.md#connection-setup)), but not actually documented itself and seemingly not supported for public use based on its current `private` status. This actually makes the method public and documents it. The actual behavior that’s documented here is implemented [here](https://github.com/rails/rails/blob/12b684985837bc8ee9ad15c174cf4e07ca82d7c4/actioncable/lib/action_cable/connection/base.rb#L213-L219), via [this rescuing of the UnauthorizedError](https://github.com/rails/rails/blob/3dd1de8ba4d5862b01e7f5dd3878b21fd98b443b/actioncable/lib/action_cable/connection/base.rb#L172). The method is [already tested here](https://github.com/rails/rails/blob/25473baf409185638073fe2f016f4b9dda284e50/actioncable/test/connection/authorization_test.rb#L17-L29).
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael França 提交于
Change AD::ParamsParser::ParseError deprecation so it can be rescued
-
由 Rafael França 提交于
Correctly reset ARGV for "rails runner `CODE' arg arg arg..."
-
由 Rafael França 提交于
CLI arg "host" has precedence over ENV var "host"
-
由 Rafael França 提交于
Fix `LogSubscriber` to allow legacy `binds`
-
由 Rafael França 提交于
Don't add a dummy API key to every new Rails app
-
由 claudiob 提交于
When you type `rails new -h`, the `--database=DATABASE` options display this useful message: > Preconfigure for selected database (options: mysql/postgresql/sqlite3/oracle/frontbase/ibm_db/sqlserver/jdbcmysql/jdbcsqlite3/jdbcpostgresql/jdbc) However, the `--webpack=WEBPACK` option only displays this: > Preconfigure for app-like JavaScript with Webpack so it's hard to know *which* values are valid for `WEBPACK`. This commit improves the help message to display: > Preconfigure for app-like JavaScript with Webpack (options: react/vue/angular) The implication of this commit is that the list needs to be manually updated whenever rails/webpacker adds support for a new framework. However, I don't imagine this list to change very frequently, and I think that the benefit of display the list to the users is greater than the hustle of updating the list when needed.
-
由 Matthew Draper 提交于
Fix `assert_logged` failure
-
由 Jon Moss 提交于
[ci skip]
-
由 Matthew Draper 提交于
Don't comment out config.file_watcher during Rails upgrade
-
由 Matthew Draper 提交于
Suppress `WARNING: nonstandard use of \\ in a string literal` warning
-
由 Jon Moss 提交于
Tried to make the sentence read more clearly. [ci skip]
-
由 claudiob 提交于
Every new Rails app is currently generated with `Rails.application.secrets[:api_key]` set to `123`. This comes from a line in `config/secrets.yml` that, in my opinion, should be left commented out to only serve as a syntax example, rather than being actually set in every Rails app. Additionally, we might want to give a better example than `123`, since in the same file we are suggesting to > Make sure the secret is at least 30 characters and all random, > no regular words or you'll be exposed to dictionary attacks. The result of this commit is that `config/secrets.yml` will include something like: ```yaml # Shared secrets are available across all environments. # shared: # api_key: f56930851993982510d5bd9236f4108f6fe7c15448f1c6923a51872e0dbae1a24d274b318abb6518b540dfb51079c61640885f607467e5ed1053849be7587d61 ``` rather than this: ```yaml # Shared secrets are available across all environments. shared: api_key: 123 ```
-
由 Matthew Draper 提交于
These tests double-stub connection.pubsub, so we need to ensure the first call's completed before we set up for the second.
-
由 Yasuo Honda 提交于
by setting `escape_string_warning = off`
-
由 Ryuta Kamizono 提交于
Follow up of #27939.
-
由 Ryuta Kamizono 提交于
`'#{name}' file doesn't exist, so no dependencies` was removed in bb048147.
-
由 Matthew Draper 提交于
[PostgreSQL] Replace deprecated PG constants.
-
由 Matthew Draper 提交于
-
由 David Heinemeier Hansson 提交于
Stop complaining about not being able to digest dynamic template partial names and simplify error logging to a single line when not
-
由 Robert Thau 提交于
-
由 Dominic Cleal 提交于
Fixes #28525
-
由 Dominic Cleal 提交于
An alternative to DeprecatedConstantProxy which works more transparently with exceptions because it returns the object that the new constant refers to rather than a proxy. This is then compatible with `rescue OldException`.
-
由 Robert Thau 提交于
The code itself should not be in the ARGV vector. Fixes #28515
-
- 22 3月, 2017 6 次提交
-
-
由 yuuji.yaginuma 提交于
This is necessary only when updating to Rails 5.0, it is not necessary for updating to 5.1. Related #24243
-
由 Lars Kanis 提交于
The old top level classes PGconn, PGresult and PGError were deprecated since pg-0.13.0: https://github.com/ged/ruby-pg/blob/master/History.rdoc#v0130-2012-02-09-michael-granger-gedfaeriemudorg
-
由 Xavier Noria 提交于
[docs] fix ActionDispatch documentation
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
由 Jon Moss 提交于
This is a regression from when the server command switched to its own argument parser, as opposed to Rack's. Rack's argument parser, when provided with a "host" argument, gives that value precedence over environment variables.
-