This can be an issue when TZInfo::TimeZone#current_period is refreshed
due to timezone period transition, but it's not reflected in
ActiveSupport::TimeZone object.

For example, on Sun, 26 Oct 2014 22:00 UTC, Moscow changed its TZ from
MSK +04:00 to MSK +03:00 (-1 hour). If ActiveSupport::TimeZone['Moscow']
happens to be initialized just before the timezone transition, it will
cache its stale utc_offset even after the timezone transition.

This commit removes cache and fixes this issue.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

Move remaining current_savepoint_name to savepoints module

Change valid_type? from abstract adapter

Others adapters need to perform a check for validity.
Add coverage for mysql2 db type validation

Add require of mattr_accessor since Compatibility relies on it.

Follow up to
https://github.com/rails/rails/commit/c9c5788a527b70d7f983e2b4b47e3afd863d9f48

remove unnessary option setting from test runner

To suppress warning ('warning: method redefined; discarding old sum')
remove the method before override it.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

In order to prevent `OptionParser::ParseError` when specify the rake options to
`routes` task.

If run the test over the `rake` command, because of the test patterns is passed
via `rake_run` method, do not need to be obtained from the argv.

This probably fixes #24372.

Refactor handling of :action default in routing

Example:

    create_table :users do |t|
      t.string :name
      t.index 'lower(name) varchar_pattern_ops'
    end

Fixes #19090.
Fixes #21765.
Fixes #21819.
Fixes #24359.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

There is no need to fetch all table indexes in remove_index if name is specified. If name is wrong, then StatementInvalid will be raised.
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

- Rename max to statement_limit
- Remove magic number 1000 from everywhere
- Defined StatementPool::DEFAULT_STATEMENT_LIMIT and started using it everywhere
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>

This alternative flows better.

[Richard Schneeman & Xavier Noria]

`railtie` is already a string!

Adapters override `#supports_savepoints?` to return `true` if they
support transaction savepoints. Defaults to `false`.

Awaken waiting threads even if the current thread (the previously
exclusive thread) hadn't taken a share lock.

This only happens in code that wasn't run within an executor, since that
always take an outermost share lock.

:nodoc: internal StatementPool class

 [ci skip]

Add #23461 to release notes

[ci skip]

Fix broken build, channel files are also included in `bin/rails stats` now

- Followup of https://github.com/rails/rails/pull/24709.

add channels files in `stats` task

Add prepared statements support for `Mysql2Adapter`

Deprecate `request_via_redirect` method.

Move `select_rows` implementation to super class

Add `:nodoc:` to `insert_versions_sql` [ci skip]

Remove in the doc about MySQL versions below 5 [ci skip]

Move `require 'ipaddr'` in `postgresql/oid/cidr.rb`

`IPAddr` is used in `OID::Cidr`.

Follow up to #23458.
Active Record supports MySQL >= 5.0 now.

Follow up to #24685. `insert_versions_sql` is not public API.

- Followup of https://github.com/rails/rails/issues/18693.
- I think we missed deprecating `request_via_redirect` in that pull
  request.
- Originally requested by DHH here
  https://github.com/rails/rails/issues/18333.

Fix typo in ActiveJob #retry_job doc