- 21 4月, 2018 11 次提交
-
-
由 Yoshiyuki Hirano 提交于
* Rewrite with Vanilla JS * Confirmed with Chrome, Safari, Firefox
-
由 Rafael Mendonça França 提交于
Preloading through polymorphic associations (still raises for typos on regular associations)
-
由 Dana Sherson 提交于
-
由 Rafael França 提交于
Add `touch_all` method to `ActiveRecord::Relation`
-
由 Rafael Mendonça França 提交于
Create MissingExactTemplate exception with separate template
-
由 Rafael França 提交于
[ci skip] belongs_to in self join association needs optional: true, if it's over 5.0 ver of rails
-
由 Guillermo Iguaran 提交于
-
由 Rafael França 提交于
[ci skip] Improve Rails::SourceAnnotationExtractor documentation
-
由 Rafael França 提交于
Allow `primary_key` argument to `empty_insert_statement_value`
-
由 Alberto Almagro 提交于
After renaming and deprecation of SourceAnnotationExtractor documentation has been updated to reflect the new name Rails::SourceAnnotationExtractor
-
由 Alberto Almagro 提交于
The previous documentation version listed only the default registered extensions. This was misleading because if more extensions get registered with <tt>SourceAnnotationExtractor::Annotation.register_extensions</tt>, they would be also taken into account. By saying that we consider all registered extensions we document what happens in reality.
-
- 20 4月, 2018 29 次提交
-
-
由 Rafael França 提交于
Fix typos related to ActionDispatch::Http::FilterParameters
-
由 Rafael França 提交于
Introduce ActionDispatch::DebugExceptions interceptors
-
由 Vinicius Stock 提交于
-
由 Yasuo Honda 提交于
to support Oracle database support identity data type Oracle database does not support `INSERT .. DEFAULT VALUES` then every insert statement needs at least one column name specified. When `prefetch_primary_key?` returns `true` insert statement always have the primary key name since the primary key value is selected from the associated sequence. However, supporting identity data type will make `prefetch_primary_key?` returns `false` then no primary key column name added. As a result, `empty_insert_statement_value` raises `NotImplementedError` To address this error `empty_insert_statement_value` can take one argument `primary_key` to generate insert statement like this. `INSERT INTO "POSTS" ("ID") VALUES(DEFAULT)` It needs arity change for the public method but no actual behavior changes for the bundled adapters. Oracle enhanced adapter `empty_insert_statement_value` implementation will be like this: ``` def empty_insert_statement_value(primary_key) raise NotImplementedError unless primary_key "(#{quote_column_name(primary_key)}) VALUES(DEFAULT)" end ``` [Raise NotImplementedError when using empty_insert_statement_value with Oracle](https://github.com/rails/rails/pull/28029) [Add support for INSERT .. DEFAULT VALUES](https://community.oracle.com/ideas/13845)
-
由 Andrew White 提交于
2.6 warning: ambiguous first argument
-
由 Alberto Almagro 提交于
-
由 Genadi Samokovarov 提交于
Plugins interacting with the exceptions caught and displayed by ActionDispatch::DebugExceptions currently have to monkey patch it to get the much needed exception for their calculation. With DebugExceptions.register_interceptor, plugin authors can hook into DebugExceptions and process the exception, before being rendered. They can store it into the request and process it on the way back of the middleware chain execution or act on it straight in the interceptor. The interceptors can be play blocks, procs, lambdas or any object that responds to `#call`.
-
由 Alberto Almagro 提交于
Fixes two documentation typos found at ActionDispatch::Http::FilterParameters
-
由 utilum 提交于
-
由 Andrew White 提交于
Fix name of the test added by #32613
-
由 yuuji.yaginuma 提交于
As of now, `HTMLElement.nonce` seems to work only in Chrome. So, it should not be used now. https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/nonce#Browser_compatibility Fixes #32577.
-
由 Rafael França 提交于
guides/testing: Pluralize controller and helper class names.
-
由 Rafael França 提交于
Return back "/" to the end of RAILS_GEM_ROOT
-
由 Rafael França 提交于
Rails-ujs: Info about stoppable events
-
由 Rafael Mendonça França 提交于
This reverts commit 78ff47f3, reversing changes made to daffe033. That changelog entry should only be on 5-2-stable
-
由 Guillermo Iguaran 提交于
Create a .ruby-version compatible with MRI/JRuby by default
-
由 Ryuta Kamizono 提交于
The extracted method is used for `CollectionCacheAssociationLoading`, still not public API. [ci skip]
-
由 Ryuta Kamizono 提交于
Suppress `warning: ambiguous first argument`
-
由 Yasuo Honda 提交于
-
由 Ryuta Kamizono 提交于
Add missing changelog entry [ci skip]
-
由 bogdanvlviv 提交于
https://github.com/rails/rails/pull/32593 was backported to `5-2-stable` but since 5.2.0 is released the changelog entry should be in Rails 6.0.0 too. [ci skip]
-
由 bogdanvlviv 提交于
- The "/" was removed in 40bdbce1 during refactoring. It may cause regression since looks like was added intentionaly because it is possible that a name of any another gem can start with /rails/, so slash was added to ensure that it is "rails" gem. I would like to backport this to `5-2-stable` too. - Use `__dir__` instead of `__FILE__`. Follow up #29176.
-
由 Rafael Mendonça França 提交于
Fix relation merging with skip_query_cache!
-
由 Guillermo Iguaran 提交于
-
由 Rafael França 提交于
Allow rubocop check more files
-
由 bogdanvlviv 提交于
This commit fix pattern of filenames for `CustomCops/AssertNot` and `CustomCops/RefuteNot`. rubocop should check every file under `test/`. Related to #32441, #32605
-
由 Rafael França 提交于
`#ordinal` and `#ordinalize` now support I18n
-
由 Rafael França 提交于
Improve css in guide
-
由 Rafael França 提交于
Improve redundancy in line tasks
-