- 24 2月, 2014 1 次提交
-
-
由 Godfrey Chan 提交于
conflicting private method defined on its ancestors. The problem is that `method_defined_within?(name, klass, superklass)` only works correclty when `klass` and `superklass` are both `Class`es. If both `klass` and `superklass` are both `Class`es, they share the same inheritance chain, so if a method is defined on `klass` but not `superklass`, this method must be introduced at some point between `klass` and `superklass`. This does not work when `superklass` is a `Module`. A `Module`'s inheritance chain contains just itself. So if a method is defined on `klass` but not on `superklass`, the method could still be defined somewhere upstream, e.g. in `Object`. This fix works by avoiding calling `method_defined_within?` with a module while still fufilling the requirement (checking that the method is defined withing `superclass` but not is not a generated attribute method). 4d8ee288 is likely an attempted partial fix for this problem. This unrolls that fix and properly check the `superclass` as intended. Fixes #11569.
-
- 23 2月, 2014 10 次提交
-
-
由 Yves Senn 提交于
Dynamically define PostgreSQL Range OIDs
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
The Ruby Range object does not support excluding beginnings. We currently support excluding beginnings for some subtypes using manually by incrementing them (now using the `#succ` method). This is approach is flawed as it's not equal to an excluding beginning. This commit deprecates the current support for excluding beginnings. It also raises an `ArgumentError` for subtypes that do not implement the `succ` method. This is a temporary solution to get rid of the broken state. We might still add complete support for excluding beginnings afterwards. (Probably with a new `PGRange` object, which acts like a `Range` but has excluding beginnings.
-
由 Yves Senn 提交于
This gets AR working with custom defined range types. It also removes the need for subtype specific branches in `OID::Range`. This expands the interface of all `OID` types with the `infinity` method. It's responsible to provide a value for positive and negative infinity.
-
由 Jon Leighton 提交于
See #13875
-
由 Godfrey Chan 提交于
Added warning when user tried to create model with pluralize name.
-
由 Kuldeep Aggarwal 提交于
1. Generate model with correct_name. 2. It will help new users to avoid mistakes when tried to create model with wrong name.
-
由 Guillermo Iguaran 提交于
Fixed typo in comment about MAX_ID.
-
由 Vajrasky Kok 提交于
-
由 Jeremy Kemper 提交于
Distinguish ConnectionNotEstablished messages: no conn pool for the class, or no conn available from the pool
-
- 21 2月, 2014 13 次提交
-
-
由 Carlos Antonio da Silva 提交于
Prevent foreign_key_for? from evaluating all attributes
-
由 Guillermo Iguaran 提交于
This reverts commit e0a521cf. Conflicts: railties/CHANGELOG.md We expect loggers to quack like stdlib logger. If log4r needs different level= assignment, using a Logger-quacking wrapper is the way to do it. Fixes #14114.
-
由 Wojtek Kruszewski 提交于
-
由 Xavier Noria 提交于
GitHub is now able to notify tag creation, I have configured the webhook for the docs server to receive that event. Therefore, we no longer need to trigger docs generation manually when releasing.
-
由 Arthur Nogueira Neves 提交于
update guides to new version of rails 3.2.x, i.e. 3.2.17 [skip ci]
-
由 Kuldeep Aggarwal 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
This reverts commit 5e3d466d.
-
由 Carlos Antonio da Silva 提交于
Fix `render_to_string` when called via manually instantiated controllers
-
由 Joan Karadimov 提交于
closes #14125
-
由 Arthur Nogueira Neves 提交于
Fix the javascript path in guide for asset modules [skip ci]
-
由 Aaron Patterson 提交于
Fix collection proxy exists? regression
-
由 Vijay Dev 提交于
-
- 20 2月, 2014 8 次提交
-
-
由 Jingwen Owen Ou 提交于
-
由 Arthur Neves 提交于
[related #14116]
-
由 Arthur Neves 提交于
This reverts commit f9e4c3c7. [fixes #14116]
-
由 Carlos Antonio da Silva 提交于
change 'assert !' to 'assert_not' in guides [ci skip]
-
由 Greg Molnar 提交于
-
由 Arun Agrawal 提交于
-
由 Xavier Noria 提交于
Add note to silence_stream and quietly. [skip ci]
-
由 Arthur Neves 提交于
State that on the doc. [fixes #11954]
-
- 19 2月, 2014 8 次提交
-
-
由 Arun Agrawal 提交于
Close the meta tag with '/>' instead of '>'
-
由 Prakash Murthy 提交于
This change fixes the 42 instances of `end tag for "meta" omitted, but OMITTAG NO was specified` error message that comes up when the full railsguides are validated. Full error list at https://gist.github.com/prakashmurthy/9086679.
-
由 Guillermo Iguaran 提交于
The errors were introduced in e220a34e
-
由 Guillermo Iguaran 提交于
Update Docs in favor to use render plain instead of text option
-
由 robertomiranda 提交于
ref #14062
-
由 Arthur Nogueira Neves 提交于
Typo fix for unscope [ci skip]
-
由 Amit Thawait 提交于
-
由 Rafael Mendonça França 提交于
Before we were calling to_sym in the mime type, even when it is unknown what can cause denial of service since symbols are not removed by the garbage collector. Fixes: CVE-2014-0082
-