- 17 4月, 2014 6 次提交
-
-
由 Rafael Mendonça França 提交于
[ci skip] Added examples for search_field_tag method
-
由 ZENATI YASSINE 提交于
-
由 Rafael Mendonça França 提交于
[ci skip] Added examples for color_field_tag method
-
由 Arthur Nogueira Neves 提交于
Reorder i18n guide
-
由 ZENATI YASSINE 提交于
-
由 Kyle Heironimus 提交于
Currently, the section called "How to store your custom translations" has several subheadings that make no sense, such as "Translations for ActiveRecord models." These make more sense under the "Overview of the I18n API Features" section. I moved the "How to store..." section down to the more appropriate sub-headings "Using Different Backends" and "Using Different Exception Handlers" and removed the "Customize your i18n setup" header.
-
- 16 4月, 2014 18 次提交
-
-
由 Yves Senn 提交于
Changed the NullRelation so that when count is called with #group it wil...
-
由 Arthur Nogueira Neves 提交于
additional note about routes in functional tests for engines [ci skip]
-
由 Eric Chahin 提交于
Changed the NullRelation so that when count is called with #group it will properly return an empty hash instead of zero. Fixes issue #14721 Conflicts: activerecord/CHANGELOG.md
-
由 Rob Gilson 提交于
Closes #14222. This is a follow up to #6104 This does not have the backwards compatibility issues brought up in implementation to break.
-
由 Rafael Mendonça França 提交于
Avoid suggesting dangerous code in i18n guide
-
由 Mike MacDonald 提交于
Calling `to_sym` on user input opens apps up to Denial of Service attacks, via the symbol table being expanded to consume vast swathes of memory. It is a fairly common configuration to have DNS configured such that all subdomains route to your Rails app, in which case an attacker visits `www1.foo.com`, `www2.foo.com`, and so on until something gives. It is far less likely to have this problem with TLDs, so that change was only for consistency.
-
由 Rafael Mendonça França 提交于
Improve tests for duplicable, remove unnecessary constant
-
由 Akshay Vishnoi 提交于
1. Improve tests 2. Remove unnecessary constant 3. Add docs for BigDecimal#duplicable?
-
由 Rafael Mendonça França 提交于
Update AC::Metal documentation example
-
由 Yury Velikanau 提交于
Include proper module since AV was extracted form AP as mentioned in #14659.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Refactor counter cache create and destroy
-
由 Rafael Mendonça França 提交于
Changed change_column in PG schema_statements.rb to make sure that the u...
-
由 Eric Chahin 提交于
Changed change_column in PG schema_statements.rb to make sure that the uuid_generate function was not being quoted.
-
由 Jean Boussier 提交于
-
由 Jean Boussier 提交于
-
由 Jean Boussier 提交于
-
- 15 4月, 2014 16 次提交
-
-
由 Rafael Mendonça França 提交于
Display diagnostics in text format for xhr request
-
由 Arthur Nogueira Neves 提交于
use YAML.load_file in database tasks example
-
由 Rafael Mendonça França 提交于
Fix count on association relation (calls to empty and size).
-
由 Robin Tweedie 提交于
rather than YAML.load(File.read(path)). YAML.load_file is also used in guides/rails_guides/helper.rb since 2011, the only other precedent I could find.
-
由 Yves Senn 提交于
[ci skip] Add missing end in one of the examples in Migrations.md.
-
由 Juanito Fatas 提交于
-
由 Yves Senn 提交于
Remove surplus period from assertion messages
-
由 Yves Senn 提交于
Fix subscriptions not being unsubscribed.
-
由 Lauro Caetano 提交于
968c581e have fixed the EagerLoadTest, but not in the correct way. The problem was when `empty?` or `size` was called on relation. It was triggering `count(:all)`, which was passing `:all` as the column name to `count` on Calculations. On the other hand, the method `calculate` on Calculations was calling `construct_relation_for_association_calculations` instead of `perform_calculation`, because `has_include?` was returning `true` since `column_name` was present. To prevent calling the wrong method to perform the calculation, we have to check if the `column_name` is present and if it is different from `:all` (which is now used to correctly do `count` with `select`). More information here: https://github.com/rails/rails/commit/968c581ea34b5236af14805e6a77913b1cb36238#commitcomment-6006135
-
由 Lauro Caetano 提交于
968c581e have introduced this bug #14744 on Association Relation when the method `empty?` or `size` was called. Example: # Given an author that does have 3 posts, but none of them with the # title 'Some Title' Author.last.posts.where(title: 'Some Title').size # => 3 It was occurring, because the Association Relation had implemented these methods based on `@association`, this way giving wrong results. To fix it, was necessary to remove the methods `empty?` and `size` from Association Relation. It just have to use these methods from Relation. Example: # Given an author that does have 3 posts, but none of them with the # title 'Some Title' Author.last.posts.where(title: 'Some Title').size # => 0 # Now it will return the correct value. Fixes #14744.
-
由 Rafael Mendonça França 提交于
Like rake tasks and runner blocks these blocks should also being shared between applications since they are stored at the classes. Fixes #14748
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
When requesting a controller with the following code with a unknown format: def my_action respond_to do |format| format.json { head :ok } format.any { render text: 'Default response' } end end we should render the default response instead of raising ActionController::UnknownFormat Fixes #14462 Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/mime/respond_with_test.rb Conflicts: actionpack/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
-
由 Richard Schneeman 提交于
[ci skip] Improve doc, fix grammatical issue
-
由 Jean Boussier 提交于
-