- 06 12月, 2016 1 次提交
-
-
由 MQuy 提交于
-
- 30 11月, 2016 1 次提交
-
-
由 MQuy 提交于
-
- 29 10月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 14 9月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
All indentation was normalized by rubocop auto-correct at 80e66cc4. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency.
-
- 02 9月, 2016 1 次提交
-
-
由 Xavier Noria 提交于
-
- 25 8月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed.
-
- 16 8月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
-
- 07 8月, 2016 3 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
-
- 06 7月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
Follow up to #24436
-
- 07 6月, 2016 1 次提交
-
-
由 Jonne Haß 提交于
SSL_set_verify(3) explains: SSL_VERIFY_FAIL_IF_NO_PEER_CERT Server mode: if the client did not return a certificate, the TLS/SSL handshake is immediately terminated with a "handshake failure" alert. This flag must be used together with SSL_VERIFY_PEER. Client mode: ignored SSL_VERIFY_CLIENT_ONCE Server mode: only request a client certificate on the initial TLS/SSL handshake. Do not ask for a client certificate again in case of a renegotiation. This flag must be used together with SSL_VERIFY_PEER. Client mode: ignored The SMTP connection here uses a OpenSSL socket in client mode, suggesting invalid/ignored flags is rather misleading.
-
- 31 5月, 2016 1 次提交
-
-
由 Rajat Bansal 提交于
-
- 16 5月, 2016 1 次提交
-
-
由 Jeremy Daer 提交于
Follows the same pattern as controllers and jobs. Exceptions raised in delivery jobs (enqueued by `#deliver_later`) are also delegated to the mailer's rescue_from handlers, so you can handle the DeserializationError raised by delivery jobs: ```ruby class MyMailer < ApplicationMailer rescue_from ActiveJob::DeserializationError do … end ``` ActiveSupport::Rescuable polish: * Add the `rescue_with_handler` class method so exceptions may be handled at the class level without requiring an instance. * Rationalize `exception.cause` handling. If no handler matches the exception, fall back to the handler that matches its cause. * Handle exceptions raised elsewhere. Pass `object: …` to execute the `rescue_from` handler (e.g. a method call or a block to instance_exec) against a different object. Defaults to `self`.
-
- 10 5月, 2016 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Pedro Adame Vergara 提交于
-
- 07 5月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 28 4月, 2016 1 次提交
-
-
由 eileencodes 提交于
-
- 26 4月, 2016 1 次提交
-
-
由 arktisklada 提交于
Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>
-
- 16 4月, 2016 1 次提交
-
-
由 Edouard CHIN 提交于
- clear_test_deliviers -> clear_test_deliveries
-
- 14 4月, 2016 1 次提交
-
-
由 Tom Kadwill 提交于
-
- 10 4月, 2016 1 次提交
-
-
由 Tom Kadwill 提交于
-
- 08 4月, 2016 1 次提交
-
-
由 Jeremy Daer 提交于
They would be lost when the delivery job is enqueued, otherwise. Prevents a common, hard-to-find bug like: ```ruby message = Notifier.welcome(user, foo) message.message_id = my_generated_message_id message.deliver_later ``` The message_id is silently lost here! *Only the mailer arguments are passed to the delivery job.* This raises an exception now. Make modifications to the message within the mailer method or use a custom Active Job to manage delivery instead of using #deliver_later.
-
- 06 4月, 2016 1 次提交
-
-
由 arktisklada 提交于
Removes `-t`
-
- 07 3月, 2016 1 次提交
-
-
由 yui-knk 提交于
After 9d378747 `ActionDispatch::IntegrationTest` class is loaded and defined in all Rails environments, not only test but also production. This is not-intended loading of a class which is only used in test environment. To prevent not-intended loading, add `ActiveSupport.run_load_hooks` to `ActionDispatch::IntegrationTest` with `action_dispatch_integration_test` name and use it in `ActionMailer`.
-
- 04 3月, 2016 1 次提交
-
-
由 Sarah A 提交于
-
- 03 3月, 2016 1 次提交
-
-
由 Santosh Wadghule 提交于
-
- 24 2月, 2016 9 次提交
-
-
由 eileencodes 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Abstract Controller is the common component between Action Mailer and Action Controller so if we need to share the caching component it need to be there.
-
由 Stan Lo 提交于
-
由 Stan Lo 提交于
Remove useless helper in ActionDispatch::Caching and fix indentation
-
由 Stan Lo 提交于
-
由 Stan Lo 提交于
Move most caching methods to ActionDispatch::Caching, and let ActionMailer and ActionController to include it
-
由 Stan Lo 提交于
-
由 Stan Lo 提交于
-
- 23 2月, 2016 2 次提交
-
-
由 Dave Gynn 提交于
the after_initialize block has been changed to use the configuration from `config.action_mailer` rather than `ActionMailer::Base` so that action mailer is not loaded before it is necessary. the mailer preview routes setup have been moved out of an `on_load(:action_mailer)` block.
-
由 Jon Moss 提交于
This is meant to provide a way for Action Cable, Sprockets, and possibly other Rack applications to mark themselves as internal, and to exclude themselves from the routing inspector, and thus `rails routes` / `rake routes`. I think this is the only way to have mounted Rack apps be marked as internal, within AD/Journey. Another option would be to create an array of regexes for internal apps, and then to iterate over that everytime a request comes through. Also, I only had the first `add_route` method set `internal`'s default to false, to avoid littering it all over the codebase.
-
- 16 2月, 2016 2 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Whenever you are sending emails in integration tests using the `:test` delivery method you need to make sure that `ActionMailer::Base.deliveries` is reset after every test. This piece of boilerplate code is present in all my applications that send emails. Let's have `ActionDispatch::IntegrationTest` reset the deliveries automatically.
-