- 30 11月, 2019 1 次提交
-
-
由 Thais Kusuki 提交于
-
- 28 11月, 2019 9 次提交
-
-
由 Carlos Antonio da Silva 提交于
Fix minor typo in pattern example for number_to_phone [ci skip]
-
由 Michael MacDonald 提交于
There is an extra closing parenthesis on the last example for `number_to_phone` which causes it to be invalid
-
由 y-yagi 提交于
Call `MonitorMixin` initializer before use methods provided by `MonitorMixin`
-
由 yuuji.yaginuma 提交于
`MonitorMixin` setup internal variables in `initialize`, so need to call that before use. `ActionController::Live::Buffer` only use methods that do not depend on those internal variables, so works expertly. But since Ruby 2.7, methods that were not originally the case also depend on internal variables. As a result, some tests fail in Ruby 2.7. https://buildkite.com/rails/rails/builds/65193#02e136eb-edea-4367-aee0-77e0a82f8531/990-1200 I'm not sure if this should be considered Ruby incompatible, but I fixed this because its usage is wrong. Related to [Feature #16255: Make `monitor.rb` built-in](https://bugs.ruby-lang.org/issues/16255)
-
由 Ryuta Kamizono 提交于
Add Rails changelog URI
-
由 Ryuta Kamizono 提交于
Bump RuboCop version to 0.77
-
由 Anthony Ross 提交于
Prior to this change, exponentially_longer had adverse consequences during system-wide downstream failures. This change adds a random value to the back off calculation in order to prevent the thundering herd problem, whereby all retry jobs would retry at the same time. Specifically this change adds a jitter option to retry_on to enable users of it to scope the randomness calculation to a reasonable amount. The default is 15% of the exponential back off calculation.
-
由 Yasuo Honda 提交于
https://github.com/rubocop-hq/rubocop/releases/tag/v0.77.0 * Update cop names to changed as follows: ``` $ bundle exec rubocop Error: The `Layout/IndentFirstArgument` cop has been renamed to `Layout/FirstArgumentIndentation`. (obsolete configuration found in .rubocop.yml, please update it) The `Layout/TrailingBlankLines` cop has been renamed to `Layout/TrailingEmptyLines`. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/StringConversionInInterpolation` cop has been renamed to `Lint/RedundantStringCoercion`. (obsolete configuration found in .rubocop.yml, please update it) $ ``` * Auto correct these offenses: ``` $ bundle exec rubocop -a ... snip ... Offenses: activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:104:11: C: [Corrected] Style/RedundantReturn: Redundant return detected. return true ^^^^^^ activerecord/lib/active_record/reflection.rb:622:15: C: [Corrected] Style/RedundantReturn: Redundant return detected. return inverse_name ^^^^^^ activerecord/lib/active_record/table_metadata.rb:48:9: C: [Corrected] Style/RedundantReturn: Redundant return detected. return self ^^^^^^ 2812 files inspected, 3 offenses detected, 3 offenses corrected $ ```
-
由 Orien Madgwick 提交于
-
- 27 11月, 2019 3 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Ryuta Kamizono 提交于
Easy to show `bundle exec rubocop` output at GitHub Actions
-
由 Yasuo Honda 提交于
When pull requests have RuboCop offenses they need to click "Build and run RuboCop" section and scroll about 200 lines to skip `bundle install` output. This change splits "Build and run RuboCop" into two parts. then "Run RuboCop" section only shows `bundle exec rubocop --parallel` output
-
- 26 11月, 2019 2 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix making an extra db file after testing for sqlite3
-
由 Takayuki Nakata 提交于
Testing for sqlite3 makes an extra db file `primary.sqlite3` as below. ``` $ bundle exec rake test:sqlite3 (snip) $ git status On branch test Untracked files: (use "git add <file>..." to include in what will be committed) db/ ```
-
- 25 11月, 2019 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
Prevent generating tests with non-existent routes
-
由 Eileen M. Uchitelle 提交于
Fix actions order in the comment
-
由 Patrik Bóna 提交于
The order of performed actions changed in 07ecaa61 but the comment stayed the same.
-
由 Ryuta Kamizono 提交于
fix(test): only test reaper with fork when fork is available
-
由 Ryuta Kamizono 提交于
Update to listen 3.2
-
由 Daniel Ritz 提交于
-
- 24 11月, 2019 9 次提交
-
-
由 Benoit Daloze 提交于
* https://github.com/guard/listen/releases/tag/v3.2.0 * https://github.com/guard/listen/issues/465 * `listen` removed the unmaintained `ruby_dep` dependency, which incorrectly shows warnings when running on TruffleRuby.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Sync style with Basic Authentication and Digest Authentication headers.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
PostgreSQL: Make detection of invalid plan locale-independent
-
由 Lars Kanis 提交于
The text of error messages from a PostgreSQL server depend on the setting "lc_messages" in postgresql.conf. The current detection of the particular error condition of an invalid plan therefore works with English language setting on the server only. Other locale settings result in a wrong exception type, which lead to two test failures: HotCompatibilityTest#test_cleans_up_after_prepared_statement_failure_in_a_transaction [test/cases/hot_compatibility_test.rb:75]: [ActiveRecord::PreparedStatementCacheExpired] exception expected, not Class: <ActiveRecord::StatementInvalid> Message: <"PG::FeatureNotSupported: FEHLER: gecachter Plan darf den Ergebnistyp nicht ändern\n"> Here the German message wasn't recognized, so that an StatementInvalid is raised instead of PreparedStatementCacheExpired. Using the PG_DIAG_SOURCE_FUNCTION is independent of the locale setting. It is not guarantied to be stable, but it has been unchanged since PostgreSQL-9.2. On the other hand the text to be matched isn't guarantied to be stable either.
-
- 23 11月, 2019 4 次提交
-
-
由 Jonathan Hefner 提交于
* Refactor generator `route` action tests Add `assert_routes` helper, which verifies that routes are always added to the `Rails.application.routes.draw` block, are always indented, and are always terminated with a newline. This "fixes" one test that was not testing something it claimed to, and obsoletes another test. Also, add a test case for indentation of multi-line routing code. * Add :namespace option to generator `route` action
-
由 Jonathan Hefner 提交于
This ensures generated tests are not broken by default when invoking the controller generator with one or more actions and "--skip-routes".
-
由 Rafael Mendonça França 提交于
Modify respond_to behaviour always setting the response's content type based on the request format
-
由 Rafael França 提交于
Eager load translations during initialization
-
- 22 11月, 2019 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix connection pools not shared between writer -> replica during tests:
-
由 Eileen M. Uchitelle 提交于
Fix IRB deprecation warning on tab-completion on Ruby <= 2.5:
-
由 Eileen M. Uchitelle 提交于
Modify ActiveRecord::TestFixtures to not rely on AS::TestCase:
-
由 Eugene Kenny 提交于
Update fragment caching doc [ci skip]
-
由 BelenRemedi 提交于
-
由 Edouard CHIN 提交于
- Similar fix as https://github.com/rails/rails/pull/37100/ which solved the issue only for ruby 2.6. Fix #37775
-