- 30 8月, 2016 2 次提交
-
-
由 Andrew White 提交于
[ci skip] Update branch version in Contributing Guide
-
由 Alex Kitchens 提交于
Since only Rails 4 and above are currently supported, this updates a 3-2-stable example to be consistent with the support standard.
-
- 29 8月, 2016 6 次提交
-
-
由 Ryo Hashimoto 提交于
The PR #20940 enabled the use of multiple roots with different constraints at the top level but unfortunately didn't work when those roots were inside a namespace and also broke the use of root inside a namespace after a top level root was defined because the check for the existence of the named route used the global :root name and not the namespaced name. This is fixed by using the name_for_action method to expand the :root name to the full namespaced name. We can pass nil for the second argument as we're not dealing with resource definitions so don't need to handle the cases for edit and new routes. Fixes #26148.
-
由 Rafael Mendonça França 提交于
This is the intended behavior. You should not do more than one request in a controller test.
-
由 Kasper Timm Hansen 提交于
use `inspect` for show `from` value
-
由 Jon Moss 提交于
Add .gitignore to "files & purpose" list - getting started docs
-
由 Rasmus Kjellberg 提交于
-
由 yuuji.yaginuma 提交于
If `from` is nil, in order to avoid the blank is showed.
-
- 28 8月, 2016 8 次提交
-
-
由 Kasper Timm Hansen 提交于
Switch back to `Hash.dup`
-
由 Kasper Timm Hansen 提交于
Remove "Under Ruby 1.9" [ci skip]
-
由 Ryuta Kamizono 提交于
Rails dropped Ruby 1.9 support, but this comment still true.
-
由 Ryuta Kamizono 提交于
Follow up to #26301.
-
由 Guillermo Iguaran 提交于
NumericalityValidator#validate_each is never called when allow_nil is true and the value is nil because it is already skipped in EachValidator#validate.
-
由 Nicolai Reuschling 提交于
Signed-off-by: NGuillermo Iguaran <guilleiguaran@gmail.com>
-
由 Guillermo Iguaran 提交于
Switch back to `Hash.dup`
-
由 Jon Moss 提交于
The performance difference between `Hash[]` and `Hash.dup` looks to have been narrowed by @tenderlove via this commit --> https://github.com/ruby/ruby/commit/b3803cc49ad382e23291d75ce57ffb2b74bb9577#diff-eff9999082c8ce7d8ba1fc1d79f439cf. Since this commit first appeared in Ruby 2.0.0, and since Rails now requires a minimum Ruby version of 2.2.2, this performance boost should be available for all users. Relevant links: - This behavior was originally added via https://github.com/rails/rails/commit/02174a3efc6fa8f2e5e6f114e4cf0d8a06305b6a - The conversation on the Ruby issue tracker lives here --> https://bugs.ruby-lang.org/issues/7166
-
- 27 8月, 2016 7 次提交
-
-
由 Vipul A M 提交于
Fix typo in Delegation#delegate_missing_to doc [ci skip]
-
由 Anton Davydov 提交于
-
由 Vijay Dev 提交于
Errors#add_on_blank: Fix typo in deprecation message
-
由 Georg Ledermann 提交于
This fixes a copy-and-paste-issue slipped in by #18996
-
由 Guillermo Iguaran 提交于
Move Rails' custom assertion method `assert_nothing_raised` to its proper place.
-
由 Santosh Wadghule 提交于
ActiveSupport::Testing::Assertions. We have a separate module in which have defined Rails' own custom assertions. So it would be good to keep all custom Rails' assertions in one place i.e. in this module.
-
由 eileencodes 提交于
It should not throw a NameError, but should throw a KeyError. Fixes #26278
-
- 26 8月, 2016 8 次提交
-
-
由 Guillermo Iguaran 提交于
Update `Rails.configuration` documentation
-
由 Jon Moss 提交于
[ci skip]
-
由 Jon Moss 提交于
[ci skip]
-
由 Jon Moss 提交于
Move `assert_nothing_raised` method to Rails Specific Assertions section [ci skip]
-
由 Santosh Wadghule 提交于
section [ci skip] - Method `assert_nothing_raised` is Rails' own custom assertion method and not a part of Minitest. So move it from Minitest assertions section to Rails Specific Assertions section.
-
由 Guillermo Iguaran 提交于
Fix "warning: assigned but unused variable - task"
-
由 Ryuta Kamizono 提交于
-
- 25 8月, 2016 7 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed.
-
由 Aaron Patterson 提交于
We can eliminate a conditional by calling a different instrumentation method depending on the situation. In this case, we'll call the special case "!render_template" instrumentation method and eliminate the case / when clause from the `instrument` method.
-
由 Aaron Patterson 提交于
Ruby already does this freeze for us.
-
由 Aaron Patterson 提交于
CacheHelper is mixed in to Helpers, Helpers is mixed in to AV::Base. This means we can count on instances of AV::Base to have the "cache hit" method on them, and we can stop setting an ivar for cache logging and just ask the view if it was a cache hit.
-
由 Guillermo Iguaran 提交于
Test that AR query cache isn't busted when types are not same object
-
由 Sean Griffin 提交于
Allow the `integration_sesion` to be set early on ActionDispatch::Integration::Runner.
-
- 24 8月, 2016 2 次提交
-
-
由 James Coleman 提交于
This is fixed in 5.0 as an ancillary part of 574f2556 but here I also add a test for the condition. I'd previously backported the fix (and added a test) in the below commit; this brings the fix back up to master. (cherry picked from commit fce3dbf3)
-
由 Rafael França 提交于
Rename the title of comand_line.md in index
-