- 12 4月, 2020 3 次提交
-
-
由 Ryuta Kamizono 提交于
Allow extra scoping in callbacks when create on association relation
-
由 Ryuta Kamizono 提交于
Remove dead code in tests
-
由 Kir Shatrov 提交于
-
- 11 4月, 2020 6 次提交
-
-
由 Kasper Timm Hansen 提交于
Add subsec to `ActiveSupport::TimeWithZone#inspect`
-
由 akinomaeni 提交于
Time.at(1498099140).in_time_zone.inspect => "Thu, 22 Jun 2017 02:39:00.000000000 UTC +00:00" Time.at(1498099140, 123456780, :nsec).in_time_zone.inspect => "Thu, 22 Jun 2017 02:39:00.123456780 UTC +00:00" Time.at(1498099140 + Rational("1/3")).in_time_zone.inspect => "Thu, 22 Jun 2017 02:39:00.333333333 UTC +00:00"
-
由 akinomaeni 提交于
-
由 Eugene Kenny 提交于
Remove ActiveRecord::DefineCallbacks module
-
由 Eileen M. Uchitelle 提交于
Fix db object to not return deprecated variable
-
由 eileencodes 提交于
Calling `db_config.config` was deprecated in #37185 in favor of `db_config.configuration_hash`. When returning the objects from `configurations` we should ensure the object returns the non-deprecated method. Before: ``` <ActiveRecord::DatabaseConfigurations::HashConfig:0x00007ff0f61696a0 @env_name="development", @name="primary", @config={:adapter=>"mysql2", :database=>"recipes_development"}> ``` After: ``` <ActiveRecord::DatabaseConfigurations::HashConfig:0x00007ff0f61696a0 @env_name="development", @name="primary", @configuration_hash={:adapter=>"mysql2", :database=>"recipes_development"}> ``` Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
- 10 4月, 2020 4 次提交
-
-
由 Ryuta Kamizono 提交于
#37523 has a regression that ignore extra scoping in callbacks when create on association relation. It should respect `klass.current_scope` even when create on association relation to allow extra scoping in callbacks. Fixes #38741.
-
由 Eugene Kenny 提交于
This module was added in 16ae3db5 to allow `ActiveRecord::AttributeMethods::Dirty` to define callbacks and still have its `_update_record` method wrapped by the version defined in `ActiveRecord::Callbacks`, so that updates in `before_update` callbacks are taken into account for partial writes. The callbacks that created this circular dependency were removed in 34f075fe, so we can move the callback definitions back to the `Callbacks` module.
-
由 Ryuta Kamizono 提交于
Reduce loops in head route matching
-
由 Vinicius Stock 提交于
-
- 09 4月, 2020 12 次提交
-
-
由 Nick Soracco 提交于
From #38142 [Rafael Mendonça França + Nick Soracco]
-
由 Rafael França 提交于
`ActionView::Base.annotate_template_file_names` only annotates HTML
-
由 Rafael França 提交于
Add attribute_names method on errors
-
由 Rafael França 提交于
Update the Active Model error treated as hash deprecation warning
-
由 Adam Hess 提交于
This method replaces the `keys` method on `errors` as a way to get the error attribute names from the errors object without treating `errors` like a hash.
-
由 Adam Hess 提交于
This message more clearly communicates how to access the attribute and message keys that you would expect to get when using the previous API. before you might iterate over errors like, errors.each do |attribute, message| # My error code here end This message helps the user find the methods on error that match the previous API.
-
由 Rafael Mendonça França 提交于
-
由 Joel Hawksley 提交于
In testing https://github.com/rails/rails/pull/38848 in the GitHub monolith, we realized that we probably should only be annotating HTML output with these comments, at least in their current format. By passing `format` to `erb_implementation`, we set ourselves up to eventually support annotations for other formats as well.
-
由 Rafael Mendonça França 提交于
While using perform_enqueued_jobs enqueued jobs must be stored as well
-
由 Rafael França 提交于
Clarify how broadcastings are named [ci skip]
-
由 Rafael França 提交于
Build Journey::Path::Pattern ast in a single loop
-
由 Vinicius Stock 提交于
-
- 08 4月, 2020 6 次提交
-
-
-
由 John Hawthorn 提交于
-
由 John Hawthorn 提交于
Deprecate rendering templates with . in the name
-
由 Eugene Kenny 提交于
Adding a route for Mandrill's url check.
-
由 eileencodes 提交于
Testing that when you set a symbol for an enum type, you get a string back and that when you set a string you also get a string back.
-
由 Rafael Mendonça França 提交于
This method is only used internally and it being public it was being retorned in the `action_methods` list.
-
- 07 4月, 2020 5 次提交
-
-
由 Bill Cromie 提交于
Mandrill's Inbound API checks to see if a URL exists before it creates the webhook. It sends a HEAD request, to which we now return a 200 OK response to indicate that the route exists. Now we can generate inbound API calls with ease on Mandrill, without having to shuffle around tokens in production. Fixes #37609.
-
由 Ryuta Kamizono 提交于
Fix random CI fail due to auto-updating timestamp
-
由 Jonathan Hefner 提交于
Example failure: https://buildkite.com/rails/rails/builds/68074#0fe7ca54-fcce-4a47-85db-a784275c8f51/1115-1125 Each time a job is serialized, `enqueued_at` is updated. Thus, separate serializations of the same job can have different `enqueued_at` timestamps if the serializations do not occur within the same second.
-
由 alimi 提交于
* Fix EagerLoadPolyAssocsTest setup * EagerLoadPolyAssocsTest includes a Remembered module in multiple test ActiveRecord classes. The module is supposed to keep track of records created for each of the included classes individually, but it collects all records for every class. This happens because @@remembered is defined on the Remembered module and shared between the ActiveRecord classes. This only becomes an issue for databases (like CockroachDB) that use random primary keys instead of sequential ones by default. * To fix the bug, we can make the remembered collection name unique per ActiveRecord class. * Update EagerLoadPolyAssocsTest test setup * Instead of defining remembered as a class variable, we can define it as an instance variable that will be unique to every class that includes the Remembered module.
-
由 Kasper Timm Hansen 提交于
Heed config.force_ssl when building URL
-
- 06 4月, 2020 4 次提交
-
-
由 Eugene Kenny 提交于
Only compute :only and :except callback conditions once
-
由 Vitalii Khustochka 提交于
Ref: https://github.com/rails/rails/issues/38679 `_normalize_callback_options` mutates the options hash, but doesn't remove the `:only` and `:except` conditions. So if you call `before_action` & al with the same option hash you end up with multiple instance of identical `:if` / `:unless` procs
-
由 Eugene Kenny 提交于
Updated Active Storage configuration guide for previewers default values [ci skip]
-
由 Abhay Nikam 提交于
-