This changed in c0466603

This executor currently relies on `ActiveRecord::Base.connection` not
changing between `prepare` and `complete`. If something else returns
the current ActiveRecord connection to the pool early then this
`complete` call will fail to clear the correct query cache and restore
the original `query_cache_enabled` status.

This has for example been happening in Sidekiq:

     https://github.com/mperham/sidekiq/pull/3166

We can just keep track of the connection as part of the exector state.

There were never public API only there by mistake.

[ci skip]

Update HABTM documentation in guides [ci skip]

Ensure `#transform_values` of HWIDA to return HWIDA

On Ruby 2.4, naitive `Hash#transform_values` is implemented.
`Hash#transform_values` uses an instance of Hash (`rb_hash_new`) to
collect returned values of a block.
For ensuring `#transform_values` of HWIDA to return HWIDA, we should
define `#transform_values` on HWIDA.

Merge pull request #25432 from kamipo/polymorphic_reflection_is_not_using_methods_from_through_reflection

`PolymorphicReflection` is not using the methods from `ThroughReflection`

update kindlerb gem

This image has copyright that we are not giving so it is better to use
one image that we own the copyright.

render :html escapes the argument if not provided as html safe.

Fix small typo in ActionView API documentation [ci skip]

Fix brittle tests which were relying on the error message text from mysql2 gem

Uses queue adapter_method instead of ActiveJob::Base.queue_adapter

Change ActiveJob::Base.queue_adapter to use queue_adapter method to make test code consistent.

Use Hash#compact and Hash#compact! from Ruby 2.4

remove assets config from `new_framework_defaults` if `--skip-sprockets` is true

If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.

* Put a blank line after :call-seq: otherwise it will think the whole test
is the call seq.
* Improve some text.
* Use some rdoc formatting.
* Restores the documentation of table_name_prefix.

[ci skip]

Fix model schema doc strings

Fix typo in Upgrading Ruby on Rails Guide [ci skip]

update description of Etag [ci skip]

The document is written with "only generate weak", but it can also be used to
strong etag.
Also, add missing entory for #24387

The first release note entry mentioned #on_weekday?, but that was only
added by the second PR mentioned there. To simplify reading the notes
just merge the two, since they are related methods. [ci skip]

Small grammar fix for #26867

[ci skip]

- Followup of fda5afeb

- These tests were fixed earlier on master in https://github.com/rails/rails/commit/f13ec72664fd13d33d617103ca964a7592295854.
- They started failing in first place due to change in https://github.com/brianmario/mysql2/commit/f14023fcfee9e85e6fc1b0e568048811518f8c23.
- They will fail again when the message is changed in mysql2 so let's
  not rely on the error message.

- Ruby 2.4 has added Hash#compact and Hash#compact! so we can use it
  now.
- Reference: https://bugs.ruby-lang.org/issues/11818 and https://bugs.ruby-lang.org/issues/12863.

Add info about updating locking column value

[ci skip]
Follow #26050

This reverts commit 671eb742.

This is not a change we would like moving forward.