- 02 12月, 2016 1 次提交
-
-
由 David Heinemeier Hansson 提交于
Move node_modules, package.json, and yarn.lock file to vendor
-
- 01 12月, 2016 7 次提交
-
-
由 Matthew Draper 提交于
Prevent issue number in documentation from becoming markdown header [ci skip]
-
由 nanaya 提交于
The alternative is escaping it but moving around the text seems a bit simpler.
-
由 Jon Moss 提交于
Fixes #27202, [ci skip]
-
由 utilum 提交于
-
由 Matthew Draper 提交于
Fix arguments passing in testing isolation
-
由 Kir Shatrov 提交于
The issue affects MRI 2.2.5, MRI 2.3.3, JRuby 9.1.6.0. It can be reproduced by: ``` $ cd activemodel $ NO_FORK=1 bundle exec rake test ``` If we wrap original arguments in quotes, it will be considered as a one big single argument. Later, [`rake/rake_test_loader.rb`](https://github.com/ruby/rake/blob/7863b97/lib/rake/rake_test_loader.rb#L15) will iterate over ARGS and try to require that huge single "argument" (which is a list of multiple .rb files). This leads to an exception: ``` /Users/kir/Project s/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:15:in `require': cannot load such file -- /Users/kir/Projects/opensource/rails/activemodel/test/cases/ attribute_assignment_test.rb [stripped] /Users/kir/Projects/opensource/rails/activemodel/test/cases/validations/with_validation_test.rb /Users/kir/Projects/opensource/rails/activemodel/test/cases/validations_test .rb (LoadError) from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:15:in `block in <main>' from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:4:in `select' from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:4:in `<main>' ``` Originally quotes were introduced in https://github.com/rails/rails/pull/19819 to fix MRI 2.2.2. The fix solves issue on all affected platforms: MRI 2.2.5, MRI 2.3.3, JRuby 9.1.6.0.
-
由 Sean Griffin 提交于
While working on updating Paper Trail for 5.1 compatibility, I noticed that I was required to pass a second argument to `attribute`. I didn't intend for this to be the case, as `attribute :foo` is totally reasonable shorthand for "I want `attr_accessor :foo`, but also have it work with things like `.attributes` and `ActiveRecord::Dirty`"
-
- 30 11月, 2016 16 次提交
-
-
由 Sean Griffin 提交于
I had pointed the messages at the new behavior, not the old.
-
由 Rafael França 提交于
use `Gem.win_platform?` to check windows Ruby platforms
-
由 Matthew Draper 提交于
reactor_running? will be true just after the thread enters EventMachine.run; reactor_thread only gets set after the internal initialize_event_machine method has been called, the C extension is set up, and it is entering its run loop.
-
由 yuuji.yaginuma 提交于
`Gem.win_platform?` check if it is Windows more accurately. Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952
-
由 Matthew Draper 提交于
Make sure the file doesn't exist until we've finished writing it.
-
由 Matthew Draper 提交于
removed `@current` as it is not used
-
由 phoet 提交于
-
由 Kasper Timm Hansen 提交于
fix typo in changelog
-
由 Robert Glaser 提交于
-
由 Akira Matsuda 提交于
-
由 Rafael França 提交于
Fix typo in Rails 5.0 release notes – “when when”
-
由 Rory O’Kane 提交于
[ci skip]
-
由 Sean Griffin 提交于
Explicitly document 'false' as value for 'action_on_unpermitted_parameters'
-
由 Daniel Carral 提交于
[ci skip]
-
由 Sean Griffin 提交于
Prior to this commit, `3.months - 3.months` would result in a duration that has the "parts" of `[[:months, 3], [:months, -3]]`. This would mean that it was subtly different than `2.months - 2.months`. When applied to a time, the date might actually change if the resulting day doesn't exist however many months in the future, even though in both cases we just wanted to add `0`, which should always be an identity operation. With this change, we now store the parts as a hash, so `3.months - 3.months` is simply stored as `{ months: 0 }`.
-
由 Rafael França 提交于
Fix that unsigned with zerofill is treated as signed
-
- 29 11月, 2016 11 次提交
-
-
由 Guillermo Iguaran 提交于
-
由 Liceth Ovalles 提交于
-
由 Guillermo Iguaran 提交于
Add Yarn support in new apps using --yarn option
-
由 Guillermo Iguaran 提交于
-
由 Jon Moss 提交于
Add note about step needed to get tests to pass if you implemented basic auth [ci skip]
-
由 JessRudder 提交于
-
由 Liceth Ovalles 提交于
-
由 Liceth Ovalles 提交于
-
由 Liceth Ovalles 提交于
-
由 Liceth Ovalles 提交于
-
由 Rafael França 提交于
Add rubocop to Gemfile
-
- 28 11月, 2016 5 次提交
-
-
由 Kir Shatrov 提交于
-
由 Santiago Pastorino 提交于
use public Module#include instead of send :include
-
由 Santiago Pastorino 提交于
I found this issue and wanted to give the fix.
-
由 Santiago Pastorino 提交于
fixing update_all and delete_all when chained with left_joins
-
由 Diego Plentz 提交于
-