1. 21 8月, 2020 2 次提交
  2. 20 8月, 2020 5 次提交
  3. 19 8月, 2020 7 次提交
  4. 18 8月, 2020 7 次提交
  5. 17 8月, 2020 6 次提交
    • E
    • E
      Merge pull request #39886 from... · 6508a5f2
      Eileen M. Uchitelle 提交于
      Merge pull request #39886 from lanzhiheng/append-some-description-about-advance-constraints-in-block-form
      
       [ci skip] Append some description about advance constraints
      6508a5f2
    • E
      Merge pull request #39939 from Shopify/link-preload-headers · 443c8470
      Eileen M. Uchitelle 提交于
      Automatically set Link header for each stylesheet and script
      443c8470
    • R
      Merge pull request #39999 from kamipo/fix_eager_loading_with_explicit_non_select · 9078abc0
      Ryuta Kamizono 提交于
      Fix eager loading that non-select columns will be loaded
      9078abc0
    • R
      Merge pull request #40056 from kamipo/fix_preloader_associate_by_default · 4aa6559b
      Ryuta Kamizono 提交于
      Fix preloader to associate preloaded records by default
      4aa6559b
    • R
      Fix eager loading that non-select columns will be loaded · 46393182
      Ryuta Kamizono 提交于
      Related to #35210.
      
      We sometimes use `select` to limit unused columns for performance.
      
      For example, `GET /posts/1` (post detail) usually use (almost) all
      columns, but `GET /posts` (post list) does not always use all columns
      (e.g. use `id` and `title` for the list view, but `body` is not used).
      
      If an association is eager loaded, the limited `select` doesn't works as
      expected, eager loading will load all columns on the model, plus also
      load the `select` columns additionally. It works differently with
      natural load and preload. It means that changing natural load or preload
      to eager load (or vice versa) is unsafe.
      
      This fixes eager loading that always load all columns (plus extra
      `select` columns), to respect the `select` columns like as others.
      
      ```ruby
      post = Post.select("UPPER(title) AS title").first
      post.title # => "WELCOME TO THE WEBLOG"
      post.body  # => ActiveModel::MissingAttributeError
      
      # Rails 6.0 (ignore the `select` values)
      post = Post.select("UPPER(title) AS title").eager_load(:comments).first
      post.title # => "Welcome to the weblog"
      post.body  # => "Such a lovely day"
      
      # Rails 6.1 (respect the `select` values)
      post = Post.select("UPPER(title) AS title").eager_load(:comments).first
      post.title # => "WELCOME TO THE WEBLOG"
      post.body  # => ActiveModel::MissingAttributeError
      ```
      46393182
  6. 16 8月, 2020 3 次提交
  7. 15 8月, 2020 10 次提交