Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.

Undo performances regressions I introduced in bbe0a507 and add test for an edge case. Add comments to explain the intent of the code.

Remove unnecessary code from define_read_method and add assertion to make sure the underscored version is actually generated

After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.

It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.

There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.

Fix before_type_cast for timezone aware attributes by caching converted value on write. Also remove read method reload arg on timezone attributes.

previously serialized_attributes were kept as class attribute of ActiveRecord::Base - if some attribute was defined as serialized in one subclass then it was serialized in all other subclasses as well (if it had the same name)

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

[#3973 state:committed]
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Work around a strange piece of Syck behaviour where it checks Model#respond_to? before initializing the object.

Things like YAML.load(YAML.dump(@post)) won't work without this.

As currently string_to_time method is not doing time zone conversion to database time zone

to relevant files.

Number of assertions before refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors

Number of assertions after refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

[#4645 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Modified ActiveRecord::AttributeMethods to allow classes to specify attribute method prefixes and/or suffixes. Previously only suffixes were allowed.
Signed-off-by: NJoshua Peek <josh@joshpeek.com>