- 10 1月, 2017 1 次提交
-
-
由 Jonas Nicklas 提交于
Closes #27614 Previously when calling `now` on a subclass of e.g. `Time` it would return an instance of `Time` instead of returning an instance of the subclass. This way, we always return the correct class.
-
- 09 1月, 2017 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Update increment! documentation [ci skip]
-
由 Kasper Timm Hansen 提交于
Merge pull request #27604 from prathamesh-sonpatki/dont-generate-erb-views-for-api-scaffold-controller Don't generate HTML/ERB templates for scaffold controller with --api flag
-
- 08 1月, 2017 3 次提交
-
-
由 Santiago Pastorino 提交于
Fix random failure related to migration environment
-
由 Santiago Pastorino 提交于
Followup of #27596, test output of "run" method as well
-
由 Sean Griffin 提交于
Fix bug with symbolized keys in .where with nested join
-
- 07 1月, 2017 7 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Fixes #27591.
-
由 Prathamesh Sonpatki 提交于
- Reference: https://travis-ci.org/rails/rails/jobs/189764676 - Reproduction command: MTB_VERBOSE=2 bundle exec minitest_bisect --seed 33328 -Itest "test/cases/migration_test.rb" "test/cases/tasks/database_tasks_test.rb" - You need to also add minitest_bisect gem to the Gemfile to reproduce this failure.
-
由 Prathamesh Sonpatki 提交于
- #27596 Updated "run" and "migrate" method for returning correct value but only added test for "migrate" method. This commit adds a test for "run" as well.
-
由 Richard Schneeman 提交于
Preserve `up` and `down` return type
-
由 Nick LaMuro 提交于
Avoids a NoMethodError when table_name is a symbol instead of a string.
-
由 Nick LaMuro 提交于
This will cause a failure with the changes from 8e2e5f9e: https://github.com/rails/rails/commit/8e2e5f9e3d1f434e265dc104ea9b00ff75702fc3 With the `singularize` call that is being done in that method when there is multiple nestings of associations (JOIN calling a JOIN) and the `stringify_keys!` is only called once here: https://github.com/rails/rails/blob/21e5fd4/activerecord/lib/active_record/relation/where_clause_factory.rb#L16 And not in the subsequent recursion in `.predicate_builder`
-
由 schneems 提交于
In Rails 4.2 calling `ActiveRecord::Migrator.migrate` would return an array of results. Without realizing that this return type was expected I accidentally introduced a change in https://github.com/rails/rails/commit/4d60e93174a3d6d90b1a06fc7515cb5cd749a6f3 This PR preserves the previous behavior and adds a test on the return type. This will need a backport to 5.0 branch.
-
- 06 1月, 2017 8 次提交
-
-
由 Sean Griffin 提交于
ensure `#compact` of HWIDA to return HWIDA
-
由 Rafael Mendonça França 提交于
Allow to custom content type when setting mailer body
-
由 Rafael Mendonça França 提交于
-
由 MQuy 提交于
-
由 Rafael França 提交于
[documentation] ActiveRecord: Document order of Callbacks
-
由 Rafael França 提交于
Update `cookies` helper on all HTTP requests
-
由 yuuji.yaginuma 提交于
`Hash#compact` of Ruby native returns new hash. Therefore, in order to return HWIDA as in the past version, need to define own `#compact` to HWIDA. Related: #26868
-
- 05 1月, 2017 19 次提交
-
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
-
由 Akira Matsuda 提交于
And let's see if it still fails...
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
this fixes sqlite3-1.3.12/lib/sqlite3/pragmas.rb:301: warning: method redefined; discarding old integrity_check
-
由 Rafael França 提交于
Optimizing information_schema query for `foreign_keys`
-
由 Rafael Mendonça França 提交于
-
由 Ryuta Kamizono 提交于
Need `table_name` to avoid all databases scan. See https://dev.mysql.com/doc/refman/5.7/en/information-schema-optimization.html. ``` > EXPLAIN SELECT fk.referenced_table_name AS 'to_table', fk.referenced_column_name AS 'primary_key', fk.column_name AS 'column', fk.constraint_name AS 'name', rc.update_rule AS 'on_update', rc.delete_rule AS 'on_delete' FROM information_schema.key_column_usage fk JOIN information_schema.referential_constraints rc USING (constraint_schema, constraint_name) WHERE fk.referenced_column_name IS NOT NULL AND fk.table_schema = 'activerecord_unittest' AND fk.table_name = 'fk_test_has_pk' AND rc.table_name = 'fk_test_has_pk'\G *************************** 1. row *************************** id: 1 select_type: SIMPLE table: fk partitions: NULL type: ALL possible_keys: NULL key: TABLE_SCHEMA,TABLE_NAME key_len: NULL ref: NULL rows: NULL filtered: NULL Extra: Using where; Open_full_table; Scanned 0 databases *************************** 2. row *************************** id: 1 select_type: SIMPLE table: rc partitions: NULL type: ALL possible_keys: NULL key: TABLE_NAME key_len: NULL ref: NULL rows: NULL filtered: NULL Extra: Using where; Open_full_table; Scanned 1 database; Using join buffer (Block Nested Loop) 2 rows in set, 1 warning (0.00 sec) ``` Fixes #27579.
-
由 Rafael Mendonça França 提交于
We use aes-256-cbc cipher by default and it only accepts keys with 32 bytes at max. Closes #27576. [ci skip]
-
由 Rafael França 提交于
Clarify that mattr_* creates public methods
-
由 Rafael França 提交于
Add "check_parameters" option to "current_page?"
-
由 Jon Moss 提交于
Fix typo in asset_pipeline.md [ci skip]
-
由 kenta-s 提交于
-
由 Rafael França 提交于
Require "models/post" before "models/comment"
-
由 Yasuo Honda 提交于
Refer a similar pull request #26370
-
由 Rafael França 提交于
Update asset fingerprinting information
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-