- 20 6月, 2017 1 次提交
-
-
由 Pat Allan 提交于
Plus a couple of related ActionPack patches.
-
- 23 5月, 2017 1 次提交
-
-
由 bogdanvlviv 提交于
".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2
-
- 19 5月, 2017 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 07 5月, 2017 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 14 4月, 2017 1 次提交
-
-
由 Stan Lo 提交于
-
- 06 2月, 2017 1 次提交
-
-
由 kenta-s 提交于
-
- 02 2月, 2017 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Akira Matsuda 提交于
sub_template_message distracts Rails.root from its message only when Rails.root is defined, and Rails.root is defined at tools/test.rb
-
- 25 1月, 2017 1 次提交
-
-
由 Matthew Eagar 提交于
When rendering heterogeneous collection using `render @collection` or `render partial: @collection`, the expected `<partial_name>_iteration` variable is missing due to `find_template` not having the name of the iteration variable included in its cache keys.
-
- 24 1月, 2017 1 次提交
-
-
由 kenta-s 提交于
-
- 12 1月, 2017 1 次提交
-
-
由 Akira Matsuda 提交于
(I personally prefer writing one string in one line no matter how long it is, though)
-
- 06 1月, 2017 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 17 9月, 2016 1 次提交
-
-
由 Michael Grosser 提交于
assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
-
- 16 8月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
-
- 07 8月, 2016 2 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
-
- 26 7月, 2016 2 次提交
-
-
由 Steven Harman 提交于
-
由 Steven Harman 提交于
An optimization was introduced in https://github.com/rails/rails/commit/27f4ffd11a91b534fde9b484cb7c4e515ec0fe77 which tried to `#to_ary` the collection to prevent unnecessary queries for ActiveRecord scopes/relations. If the given collection did not respond to `#to_ary`, and empty collection was returned. That meant you couldn't use collections built from `Enumerator` nor `Enumerable`. With this change, `#collection_from_options` will attempt the optimization, but fall back to passing along the given collection, as-is.
-
- 22 6月, 2016 1 次提交
-
-
由 eileencodes 提交于
In PR #24929 the changelog was updated to make note that while the new template handler was changed to raw this changed the behavior when outputting plain html or js files. Previously ERB would output the files unescaped. Changing the default handler to RAW meant that these same files would be rendered as escaped rather than as js or html. Because of this change in behavior and after the discussion #24949 in we decided to change the behavior of the Raw handler to output html_safe strings by default. Now files rendered with the default handler (raw) render the file unescaped.
-
- 17 4月, 2016 1 次提交
-
-
由 Vipul A M 提交于
-
- 04 3月, 2016 1 次提交
-
-
由 Benjamin Quorning 提交于
When rendering a collection with a partial whose filename contains a dot, e.g. "customer.mobile", we would set a `locals[:'customer.mobile']` variable instead of, as in earlier versions of Rails, `locals[:customer]`. This bug was introduced in da9038ea.
-
- 20 2月, 2016 1 次提交
-
-
由 Kasper Timm Hansen 提交于
Having collection caching that wraps templates and automatically tries to infer if they are cachable proved to be too much of a hassle. We'd rather have it be something you explicitly turn on. This removes much of the code and docs to explain the previous automatic behavior. This change also removes scoped cache keys and passing cache_options.
-
- 13 2月, 2016 1 次提交
-
-
由 Vipul A M 提交于
- Changed formatted_code_for to return array of logs to be tagged for each line - Changed some render tests to match new behaviour of return Fixes #22979
-
- 23 1月, 2016 1 次提交
-
-
由 Aaron Patterson 提交于
CVE-2016-0752
-
- 06 1月, 2016 1 次提交
-
-
由 Santiago Pastorino 提交于
This fixes the case when you try to render an html you know safe and the file is named something.html. With this commit the content of the html won't be escaped anymore because AV won't use Raw handler and choose Html handler instead.
-
- 15 12月, 2015 1 次提交
-
-
由 Sam Stephenson 提交于
Introduced in e56c6354, `CacheHelper#fragment_cache_key` is a duplicate of `ActionController::Caching::Fragments#fragment_cache_key`. We now require the view to provide this method on its own (as with `view_cache_dependencies`); `ActionController::Caching::Fragments` exports its version as a `helper_method`.
-
- 13 11月, 2015 1 次提交
-
-
由 yui-knk 提交于
This commit fixes the bug convering `false` to `locals[as]` when `options[:object]` is `false` (close #22260).
-
- 03 11月, 2015 1 次提交
-
-
由 Yuki Nishijima 提交于
-
- 26 9月, 2015 1 次提交
-
-
由 Ronak Jangir 提交于
-
- 29 6月, 2015 1 次提交
-
-
由 Roque Pinel 提交于
Adds the `virtual_path` option to `cache_fragment_name` so it can be provided when needed. That allows `cache_collection_render` to get the appropriate cache key with the digest generated based on the template and prevent collision with other templates that cache the same collection.
-
- 14 5月, 2015 1 次提交
-
-
由 Henrik Nygren 提交于
When one rendered a partial template without specifying an object or a collection (e.g. <%= render partial: 'partial_name' %>), Rails would make an object called :partial_name available in local_assigns. I don't think this was the intended behavior, since no local variable called 'partial_name' gets defined in the view.
-
- 21 2月, 2015 3 次提交
-
-
由 Kasper Timm Hansen 提交于
Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ```
-
由 Franky W 提交于
The testing of error messages have been implemented wrongly a few times. This is an attempt to fix it. For example, some of these test should have failed with the new code. The reason they are not failling with the new string is the fact they were not being tested beforehand.
-
由 Kasper Timm Hansen 提交于
Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template.
-
- 06 2月, 2015 1 次提交
-
-
由 Akira Matsuda 提交于
because the partial renderer would not create an lvar per each template since c67005f2
-
- 03 2月, 2015 1 次提交
-
-
由 Vipul A M 提交于
-
- 30 12月, 2014 1 次提交
-
-
由 Angelo capilleri 提交于
before this PR IDENTIFIER_ERROR_MESSAGE could lead to misunderstand the convention of partial name. Added OPTION_AS_ERROR_MESSAGE for unvalid charter in as option.
-
- 19 12月, 2014 1 次提交
-
-
由 Nikolay Shebanov 提交于
-
- 29 11月, 2014 1 次提交
-
-
由 Erik Michaels-Ober 提交于
-
- 19 7月, 2014 1 次提交
-
-
由 Eugene Gilburg 提交于
-