- 20 6月, 2017 1 次提交
-
-
由 Pat Allan 提交于
Plus a couple of related ActionPack patches.
-
- 14 3月, 2017 1 次提交
-
-
由 Hrvoje Šimić 提交于
-
- 29 10月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 14 9月, 2016 1 次提交
-
-
由 Kir Shatrov 提交于
When the check is failed, print the actual response body if it's not too large. This could improve productivity when writing new tests. Before: ``` ThemeEditorIntegrationTest#test_whatever Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>. Expected: 200 Actual: 422 ``` After: ``` ThemeEditorIntegrationTest#test_whatever Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>. Expected: 200 Actual: 422 Response body: {"errors":["Invalid settings object for section '1'"]} ```
-
- 07 8月, 2016 1 次提交
-
-
由 Xavier Noria 提交于
The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
-
- 13 1月, 2016 1 次提交
-
-
由 Sean Collins 提交于
Also, refactor logic to convert between symbol and response code, via the AssertionResponse class
-
- 12 12月, 2015 1 次提交
-
-
由 Jon Atack 提交于
Follow-up to PR #19977, which helpfully added the redirection path to the error message of assert_response if response is a redirection, but which removed the response code, obscuring the type of redirect. This PR: - brings back the response code in the error message, - updates the tests so the new messages can be tested, - and adds test cases for the change.
-
- 07 12月, 2015 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- `assert_predicate` appends its own error message at the end of message generated by `assert_response` and because of that the error message displays the whole `response` object. - For eg. Expected response to be a <success>, but was a redirect to <http://test.host/posts>. Expected #<ActionDispatch::TestResponse:0x007fb1cc1cf6f8....(lambda)>}>> to be successful?. - Complete message can be found here - https://gist.github.com/prathamesh-sonpatki/055afb74b66108e71ded#file-gistfile1-txt-L19. - After this change the message from `assert_predicate` won't be displayed and only message generated by `assert_response` will be shown as follows: Expected response to be a <success>, but was a redirect to <http://test.host/posts>
-
- 04 12月, 2015 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- If the assert_response is checking for any non-redirect response like :success and actual response is :redirect then, the error message displayed was - Expected response to be a <success>, but was <302> - This commit adds the redirect path to the error message of assert_response if the response is :redirect. So above message is changed to - Expected response to be a <success>, but was a redirect to <http://test.host/posts/lol>
-
- 09 10月, 2015 1 次提交
- 07 10月, 2015 1 次提交
-
-
由 Ronak Jangir 提交于
-
- 14 7月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
We shouldn't depend on specific methods imlemented in the TestResponse subclass because the response could actually be a real response object. In the future, we should either push the aliased predicate methods in TestResponse up to the real response object, or remove them
-
- 07 8月, 2014 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 13 5月, 2014 1 次提交
-
-
由 Arthur Neves 提交于
`assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbab. [fixes #14691]
-
- 25 11月, 2013 1 次提交
-
-
由 Victor Costan 提交于
This commit makes it really easy to debug errors due to typos like "assert_response :succezz".
-
- 19 9月, 2013 1 次提交
-
-
由 Derek Prior 提交于
In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
-
- 01 11月, 2012 1 次提交
-
-
由 AvnerCohen 提交于
-
- 03 8月, 2012 1 次提交
-
-
由 Xavier Noria 提交于
-
- 21 5月, 2012 1 次提交
-
-
由 Andrew White 提交于
-
- 15 5月, 2012 1 次提交
-
-
由 Francesco Rodriguez 提交于
-
- 03 5月, 2012 1 次提交
-
-
由 Andy Lindeman 提交于
-
- 04 4月, 2012 1 次提交
-
-
由 Oscar Del Ben 提交于
-
- 03 4月, 2012 1 次提交
-
-
由 Jurriaan Pruis 提交于
-
- 01 4月, 2012 1 次提交
-
-
由 Erich Menge 提交于
# File lib/rack/response.rb, line 114 114: def successful?; @status >= 200 && @status < 300; end
-
- 16 3月, 2012 1 次提交
-
-
由 Brian Lopez 提交于
add tests for stripping \r\n chars since that's already happening
-
- 07 1月, 2012 5 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 14 8月, 2011 2 次提交
-
-
由 Santiago Pastorino 提交于
-
由 thoefer 提交于
refactored 'assert_redirected_to': local call to validate_request! will be called in assert_response already. changed names of local variables in order to recognize the semantics a bit easier.
-
- 27 7月, 2011 1 次提交
-
-
由 Santiago Pastorino 提交于
-
- 26 7月, 2011 1 次提交
-
-
由 thoefer 提交于
refactored 'assert_redirected_to': local call to validate_request! will be called in assert_response already. changed names of local variables in order to recognize the semantics a bit easier.
-
- 30 5月, 2011 1 次提交
-
-
由 Lee Reilly 提交于
-
- 23 5月, 2011 1 次提交
-
-
由 wycats 提交于
Also, no need to include dependencies in AS::Concerns inside included blocks.
-
- 03 5月, 2011 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 23 4月, 2011 1 次提交
-
-
由 David Heinemeier Hansson 提交于
We cant use assert_block because its buggy in MiniTest and wont actually show you the failure message you provide -- instead you just always get a "Expected block to return true"
-
- 13 4月, 2011 1 次提交
-
-
由 Prem Sichanugrist 提交于
After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
-
- 12 4月, 2011 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-