1. 20 6月, 2017 1 次提交
  2. 14 3月, 2017 1 次提交
  3. 29 10月, 2016 1 次提交
  4. 14 9月, 2016 1 次提交
    • K
      Improve assert_response helper · bc3b0e72
      Kir Shatrov 提交于
      When the check is failed, print the actual response body if it's not too large.
      This could improve productivity when writing new tests.
      
      Before:
      
      ```
      ThemeEditorIntegrationTest#test_whatever
          Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>.
      Expected: 200
        Actual: 422
      ```
      
      After:
      
      ```
      ThemeEditorIntegrationTest#test_whatever
          Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>.
      Expected: 200
        Actual: 422
      Response body: {"errors":["Invalid settings object for section '1'"]}
      ```
      bc3b0e72
  5. 07 8月, 2016 1 次提交
  6. 13 1月, 2016 1 次提交
  7. 12 12月, 2015 1 次提交
    • J
      Show redirect response code in assert_response messages · c6fe614e
      Jon Atack 提交于
      Follow-up to PR #19977, which helpfully added the redirection path to the error message of assert_response if response is a redirection, but which removed the response code, obscuring the type of redirect.
      
      This PR:
      
      - brings back the response code in the error message,
      
      - updates the tests so the new messages can be tested,
      
      - and adds test cases for the change.
      c6fe614e
  8. 07 12月, 2015 1 次提交
  9. 04 12月, 2015 1 次提交
  10. 09 10月, 2015 1 次提交
  11. 07 10月, 2015 1 次提交
  12. 14 7月, 2015 1 次提交
    • A
      use a lookup table for `assert_response` · 908bc797
      Aaron Patterson 提交于
      We shouldn't depend on specific methods imlemented in the TestResponse
      subclass because the response could actually be a real response object.
      
      In the future, we should either push the aliased predicate methods in
      TestResponse up to the real response object, or remove them
      908bc797
  13. 07 8月, 2014 1 次提交
  14. 13 5月, 2014 1 次提交
    • A
      Fix regression on `assert_redirected_to`. · 7ec66530
      Arthur Neves 提交于
      `assert_redirected_to` would fail if there is no controller set on
      a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location
      would be called on the controller to build the url.
      
      This regression was introduced after 1dacfbab.
      
      [fixes #14691]
      7ec66530
  15. 25 11月, 2013 1 次提交
  16. 19 9月, 2013 1 次提交
    • D
      Fix incorrect assert_redirected_to failure message · 1dacfbab
      Derek Prior 提交于
      In some instances, `assert_redirected_to` assertion was returning an
      incorrect and misleading failure message when the assertion failed.
      This was due to a disconnect in how the assertion computes the redirect
      string for the failure message and how `redirect_to` computes the
      string that is actually used for redirection.
      
      I made the `_compute_redirect_to_loaction` method used by `redirect_to`
      public and call that from the method `assert_redirect_to` uses to
      calculate the URL.
      
      The reveals a new test failure due to the regex used by
      `_compute_redirect_to_location` allow `_` in the URL scheme.
      1dacfbab
  17. 01 11月, 2012 1 次提交
  18. 03 8月, 2012 1 次提交
  19. 21 5月, 2012 1 次提交
  20. 15 5月, 2012 1 次提交
  21. 03 5月, 2012 1 次提交
  22. 04 4月, 2012 1 次提交
  23. 03 4月, 2012 1 次提交
  24. 01 4月, 2012 1 次提交
  25. 16 3月, 2012 1 次提交
  26. 07 1月, 2012 5 次提交
  27. 14 8月, 2011 2 次提交
  28. 27 7月, 2011 1 次提交
  29. 26 7月, 2011 1 次提交
  30. 30 5月, 2011 1 次提交
  31. 23 5月, 2011 1 次提交
  32. 03 5月, 2011 1 次提交
  33. 23 4月, 2011 1 次提交
  34. 13 4月, 2011 1 次提交
    • P
      Remove `#among?` from Active Support · 733bfa63
      Prem Sichanugrist 提交于
      After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.
      
      It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
      733bfa63
  35. 12 4月, 2011 1 次提交