- 09 4月, 2020 4 次提交
-
-
由 Joel Hawksley 提交于
In testing https://github.com/rails/rails/pull/38848 in the GitHub monolith, we realized that we probably should only be annotating HTML output with these comments, at least in their current format. By passing `format` to `erb_implementation`, we set ourselves up to eventually support annotations for other formats as well.
-
由 Rafael França 提交于
Clarify how broadcastings are named [ci skip]
-
由 Rafael França 提交于
Build Journey::Path::Pattern ast in a single loop
-
由 Vinicius Stock 提交于
-
- 08 4月, 2020 6 次提交
-
-
-
由 John Hawthorn 提交于
-
由 John Hawthorn 提交于
Deprecate rendering templates with . in the name
-
由 Eugene Kenny 提交于
Adding a route for Mandrill's url check.
-
由 eileencodes 提交于
Testing that when you set a symbol for an enum type, you get a string back and that when you set a string you also get a string back.
-
由 Rafael Mendonça França 提交于
This method is only used internally and it being public it was being retorned in the `action_methods` list.
-
- 07 4月, 2020 5 次提交
-
-
由 Bill Cromie 提交于
Mandrill's Inbound API checks to see if a URL exists before it creates the webhook. It sends a HEAD request, to which we now return a 200 OK response to indicate that the route exists. Now we can generate inbound API calls with ease on Mandrill, without having to shuffle around tokens in production. Fixes #37609.
-
由 Ryuta Kamizono 提交于
Fix random CI fail due to auto-updating timestamp
-
由 Jonathan Hefner 提交于
Example failure: https://buildkite.com/rails/rails/builds/68074#0fe7ca54-fcce-4a47-85db-a784275c8f51/1115-1125 Each time a job is serialized, `enqueued_at` is updated. Thus, separate serializations of the same job can have different `enqueued_at` timestamps if the serializations do not occur within the same second.
-
由 alimi 提交于
* Fix EagerLoadPolyAssocsTest setup * EagerLoadPolyAssocsTest includes a Remembered module in multiple test ActiveRecord classes. The module is supposed to keep track of records created for each of the included classes individually, but it collects all records for every class. This happens because @@remembered is defined on the Remembered module and shared between the ActiveRecord classes. This only becomes an issue for databases (like CockroachDB) that use random primary keys instead of sequential ones by default. * To fix the bug, we can make the remembered collection name unique per ActiveRecord class. * Update EagerLoadPolyAssocsTest test setup * Instead of defining remembered as a class variable, we can define it as an instance variable that will be unique to every class that includes the Remembered module.
-
由 Kasper Timm Hansen 提交于
Heed config.force_ssl when building URL
-
- 06 4月, 2020 9 次提交
-
-
由 Eugene Kenny 提交于
Only compute :only and :except callback conditions once
-
由 Vitalii Khustochka 提交于
Ref: https://github.com/rails/rails/issues/38679 `_normalize_callback_options` mutates the options hash, but doesn't remove the `:only` and `:except` conditions. So if you call `before_action` & al with the same option hash you end up with multiple instance of identical `:if` / `:unless` procs
-
由 Eugene Kenny 提交于
Updated Active Storage configuration guide for previewers default values [ci skip]
-
由 Abhay Nikam 提交于
-
由 Jonathan Hefner 提交于
`url_for` will now use "https://" as the default protocol when `Rails.application.config.force_ssl` is set to true. Action Mailer already behaves this way, effectively. This commit extends that behavior application-wide. Closes #23543.
-
由 Eugene Kenny 提交于
The tasks are called db:rollback:[NAME], not db:migrate:rollback:[NAME].
-
由 Kasper Timm Hansen 提交于
Remove :rdoc Rake task in generated plugin
-
由 Kasper Timm Hansen 提交于
Clarify database.yml DATABASE_URL instructions
-
由 Eugene Kenny 提交于
Add description to db:rollback command for multiple databases [ci skip]
-
- 05 4月, 2020 3 次提交
-
-
由 Faruk AYDIN 提交于
rails -T command omits rake tasks that do not have a task description, so I added a description to `db:rollback` command for multiple databases and updated the documentation accordingly
-
由 Jonathan Hefner 提交于
From the instructions in database.yml, it is not clear that Rails will automatically use ENV['DATABASE_URL'] if it is present. This commit rewords the instructions to clarify that Rails will do so.
-
由 Jonathan Hefner 提交于
The `rdoc lib` command produces nearly the same output as `rake rdoc`. The `rdoc lib` command also has the benefit of being standard, whereas Rake subcommands can vary from project to project. Since the purpose of either command is to support local development, as opposed to generating official docs for consumption by e.g. rubygems, the standard command seems preferable. Note that the `rdoc` command outputs to the doc/ directory by default, so this commit also adds that directory to the plugin .gitignore file.
-
- 04 4月, 2020 4 次提交
-
-
由 Eugene Kenny 提交于
These were removed in 74201c38 when the template for the 6.0 new framework defaults initializer was deleted. While we no longer generate the file, upgrading applications will still have it, so it's still important to check that these options can be set.
-
由 Eugene Kenny 提交于
I introduced this pattern of referencing a constant to trigger lazy load hooks in 458a5502, and it arrived at its current form via c98a641f and c24be369. I now realise autoloading doesn't need to be involved at all; we can require the files that trigger the lazy load hooks directly.
-
由 Eugene Kenny 提交于
Merge pull request #38863 from eugeneius/utc_to_local_returns_utc_offset_times_new_framework_defaults Allow utc_to_local_returns_utc_offset_times to be set in new_framework_defaults_6_1.rb
-
由 Eugene Kenny 提交于
Enabling this option in new_framework_defaults_6_1.rb didn't work before, as railtie initializers run before application initializers.
-
- 03 4月, 2020 3 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add S3 example using server-side encryption
-
由 Rafael França 提交于
Update the Rails mailing list URLs to new discuss discourse URL
-
由 Abhay Nikam 提交于
-
- 01 4月, 2020 3 次提交
-
-
由 John Hawthorn 提交于
Allowing templates with "." introduces some ambiguity. Is index.html.erb a template named "index" with format "html", or is it a template named "index.html" without a format? We know it's probably the former, but if we asked ActionView to render "index.html" we would currently get some combination of the two: a Template with index.html as the name and virtual path, but with html as the format. This deprecates having "." anywhere in the template's name, we should reserve this character for specifying formats. I think in 99% of cases this will be people specifying `index.html` instead of simply `index`. This was actually once deprecated in the 3.x series (removed in 6c57177f) but I don't think we can rely on nobody having introduced this in the past 8 years.
-
由 David Heinemeier Hansson 提交于
* Add a way to deliver inbound emails by source Great for testing when you get an eml file and can just paste it in. * Test updates * Fix tests * Fix spacing
-
由 George Claghorn 提交于
-
- 31 3月, 2020 3 次提交
-
-
由 Eileen M. Uchitelle 提交于
Allow logs to be tagged without a block
-
由 Eugene Kenny 提交于
Calling `#tagged` without a block now returns a new logger with the tags applied. This is useful for when you want to tag an individual log line, rather than an entire request.
-
由 Eileen M. Uchitelle 提交于
Document working with association and checkboxes in a form
-