- 27 8月, 2018 2 次提交
-
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
This commit is the next work after #33523. Also, this commit removes mention about hidden `utf8` input. Since form helpers don't generate this input by default since #32125. Note that I also had created PR #31972 with improvements to "Action View Form Helpers" guide, but I'll rebase it after merging the current PR.
-
- 25 8月, 2018 3 次提交
-
-
由 Ryuta Kamizono 提交于
Format respond_to method as code in doc [ci skip]
-
由 Rob Zolkos 提交于
This updates the `respond_to` method to be code formatted rather than plain text (as it refers to the method)
-
由 yuuji.yaginuma 提交于
Because there are tests that fail due to the influence of the `async_exec` deprecate message. https://travis-ci.org/rails/rails/jobs/420345370 Related to #33188.
-
- 24 8月, 2018 7 次提交
-
-
由 George Claghorn 提交于
Handle only specifically relevant Azure HTTPErrors ActiveStorage::Service::AzureStorageService#upload and #delete
-
由 Cameron Bothner 提交于
The Azure gem uses `Azure::Core::Http::HTTPError` for everything: checksum mismatch, missing object, network unavailable, and many more. (https://www.rubydoc.info/github/yaxia/azure-storage-ruby/Azure/Core/Http/HTTPError). Rescuing that class obscures all sorts of configuration errors. We should check the type of error in those rescue blocks, and reraise when needed.
-
由 George Claghorn 提交于
This reverts commit b204d167, reversing changes made to de6a200f.
-
由 George Claghorn 提交于
Handle only specifically relevant Azure HTTPErrors in ActiveStorage::Service::AzureStorageService
-
由 Cameron Bothner 提交于
The Azure gem uses `Azure::Core::Http::HTTPError` for everything: checksum mismatch, missing object, network unavailable, and many more. (https://www.rubydoc.info/github/yaxia/azure-storage-ruby/Azure/Core/Http/HTTPError). Rescuing that class obscures all sorts of configuration errors. We should check the type of error in those rescue blocks, and reraise when needed.
-
由 Aaron Patterson 提交于
[ci skip] change all instances of blacklist and whitelist to denylist…
-
由 Matthew Draper 提交于
Prevent deadlocks when waiting for connection from pool.
-
- 23 8月, 2018 26 次提交
-
-
由 George Claghorn 提交于
Follow up #33659
-
由 Ryuta Kamizono 提交于
`Topic` isn't loaded in this test file.
-
由 Matthew Draper 提交于
Use string lengths instead of regexp to extract path
-
由 Matthew Draper 提交于
The regexp was introduced in 186ac4cd, and looks cosmetic. While they should be functionally identical in theory, in practice, case insensitive (but preserving) filesystems can give results that are differently-cased from the pattern we supplied. I don't know how to force the filesystem to do the surprising thing, even when running in an environment that _could_, so no new test.
-
由 Matthew Draper 提交于
Omit BEGIN/COMMIT statements for empty transactions
-
由 bogdanvlviv 提交于
Test `assert_no_broadcasts` failure
-
由 bogdanvlviv 提交于
See `git grep "= Logger.new(nil)"`
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
Remove extra `:nodoc:` comment since private methods doesn't require that.
-
由 Kasper Timm Hansen 提交于
Use `say`/`error` instead of `puts`/`$stderr.puts`
-
由 George Claghorn 提交于
Fail more gracefully from ActiveStorage missing file exceptions
-
由 Mina Slater 提交于
[ci skip] corrects more grammar awkwardness, replacing denylist with restricted list and consistently use permitted
-
由 Nick Schwaderer 提交于
* Include form_with in form_helpers rails guide * Include form_tag and form_for footnote * Id and class attributes are not wrapped anymore * Include note that all form_with forms are remote:true by default * Underline most common use case of form_with is with arguments * Form_with no longer accepts multiple hashes in form helper calls * Review final sections * Revert extra documentation * Remove unnecessary link
-
由 Rafael França 提交于
Remove extra execution of `uniq!` on action_methods
-
由 Rafael França 提交于
Update ParameterFilter to yield original parameters
-
由 bogdanvlviv 提交于
Execution of `to_set` below should remove duplicated elements. Follow up #33693
-
由 Richard Schneeman 提交于
Two fewer array allocations on action_methods
-
由 Rafael França 提交于
Fix `rails initializers --help` and `rails dev:cache --help`
-
由 Peter Zhu 提交于
-
由 bogdanvlviv 提交于
Follow up 44007c07
-
由 bogdanvlviv 提交于
- `rails initializers --help` should show description set by `desc` See railties/lib/rails/command/base.rb:27 - Fix `rails dev:cache --help` ``` Traceback (most recent call last): 10: from bin/rails:4:in `<main>' 9: from bin/rails:4:in `require' 8: from /work/rails/railties/lib/rails/commands.rb:18:in `<top (required)>' 7: from /work/rails/railties/lib/rails/command.rb:46:in `invoke' 6: from /work/rails/railties/lib/rails/command/base.rb:65:in `perform' 5: from /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch' 4: from /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command' 3: from /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run' 2: from /work/rails/railties/lib/rails/command/base.rb:150:in `help' 1: from /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor.rb:170:in `command_help' /home/vagrant/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.0/lib/thor/base.rb:497:in `handle_no_command_error': Could not find command "dev". (Thor::UndefinedCommandError) ``` Context https://github.com/rails/rails/pull/33694#issuecomment-415127304 Would be great to set a description to other commands.
-
由 Rafael França 提交于
Added explanation about new_framework_defaults.rb file [ci skip]
-
由 Rafael França 提交于
Remove `rake initializers` from rake tasks list
-
-
由 Kasper Timm Hansen 提交于
Stop using Mocha
-
由 schneems 提交于
Instead of creating new arrays for `uniq` and `map` we can instead modify the array in place.
-
- 22 8月, 2018 2 次提交
-
-
由 Ryuta Kamizono 提交于
This was introduced at 24f6bf0d.
-
由 Matthew Draper 提交于
Add database configuration to disable advisory locks.
-