- 16 1月, 2017 15 次提交
-
-
由 Eileen M. Uchitelle 提交于
Allow SQLServerAdapter To Opt Into A Few Tests
-
由 Kasper Timm Hansen 提交于
Update comment for Scrubber usage [ci skip]
-
由 Ken Collins 提交于
-
由 David Heinemeier Hansson 提交于
Added test to ensure that we dont break #to_h again when trying to restore the speed-up from 26dd9b26 (cc: @fxn)
-
由 David Heinemeier Hansson 提交于
Revert "significant speedup of AC::Parameters#permit" [26dd9b26] as it broke Parameters#to_h on at least fields_for-style nested params.
-
由 David Heinemeier Hansson 提交于
This was preventing the test suite from being run in isolation
-
由 kenta-s 提交于
-
由 Akira Matsuda 提交于
-
由 Kasper Timm Hansen 提交于
Add test for update_counters with empty touch array
-
由 Kasper Timm Hansen 提交于
`timestamp_attributes_for_updates_in_model` returns an empty array when a model has no `updated_at` or `updated_on`. So my previously thought uncommon case is a lot more likely now. This reverts commit a0a1ede8.
-
由 Kasper Timm Hansen 提交于
Make all rails commands work in engine
-
由 Kasper Timm Hansen 提交于
Fix UUID primary key with default nil in legacy migration
-
由 Kasper Timm Hansen 提交于
The exact inspect output of a BigDecimal is out of scope for what we're trying to communicate about `dup` and `duplicable?` here. Adding two examples distracts is disctracting, so keep the docs from before since our minimal version is Ruby 2.2.2. [ Koichi ITO, Jon Moss, Kasper Timm Hansen ] This reverts commit 2163874d, reversing changes made to 46fdbc52.
-
由 Kasper Timm Hansen 提交于
Closes #27683. Seeing a code sample that leads to what we're guarding against: ```ruby Topic.update_counters(1, replies_count: 1, touch: []) ``` It doesn't look like a case people would ever intentionally end up with. Thus we're better off sparing the conditional. Note: it could happen if a method returns an empty array that's then passed to `update_counters` and its touchy friends. But `[].presence` can fix that once people see their query blow up. [ Eugene Kenny & Kasper Timm Hansen ]
-
由 Kasper Timm Hansen 提交于
remove unused require
-
- 15 1月, 2017 21 次提交
-
-
由 Jon Moss 提交于
Several representation of BigDecimal has changed in Ruby 2.4.0+ [ci skip]
-
由 Akira Matsuda 提交于
This reverts commit 66e5b9d3. We're seeing some test failures in AR postgresql tests
-
由 Akira Matsuda 提交于
I see no reason not to use the newest stable version.
-
由 Andrew White 提交于
In #26672 we blocked use of Ruby keywords as identifiers for view locals but inadvertently broke the use of instance variable names as identifiers. Whilst not explicitly documented this behavior has been around for a long time and there's no need to break it now. Fixes #27480.
-
由 Kasper Timm Hansen 提交于
remove unnecessary addition of `lib`
-
由 Ryuta Kamizono 提交于
Fix broken sample code in action_view/helpers/output_safety_helper.rb…
-
由 yuuji.yaginuma 提交于
`InlineAdapter` is not used from 1f8558fa.
-
由 kenta-s 提交于
-
-
由 yuuji.yaginuma 提交于
`TestTask` add `lib` directory by default. Ref: https://github.com/ruby/rake/blob/master/lib/rake/testtask.rb#L39..L41
-
由 Eugene Kenny 提交于
This is a regression test for a fix included in https://github.com/rails/rails/commit/bad9bfbea6d6af9dc28583e08a49492668087393. Without that change, this test would fail with: ActiveRecord::StatementInvalid: SQLite3::SQLException: near "WHERE": syntax error: UPDATE "topics" SET "replies_count" = COALESCE("replies_count", 0) - 1, WHERE "topics"."id" = ?
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
instead, rewrite them to no-op
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
in case String or any other ancestor class' respond_to_missing? was defined.
-
由 Akira Matsuda 提交于
-
由 Kasper Timm Hansen 提交于
Add the touch option to ActiveRecord#increment! and decrement!
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
in case Array or any other ancestor class' respond_to_missing? was defined.
-
由 Kasper Timm Hansen 提交于
`type_condition` should be overwritten by `create_with_value` in `scope_for_create`
-
由 Ryuta Kamizono 提交于
`type_condition` should be overwritten by `create_with_value`. So `type` in `create_with_value` should be a string because `where_values_hash` keys are converted to string. Fixes #27600.
-
- 14 1月, 2017 4 次提交
-
-
由 Arthur Nogueira Neves 提交于
Small spelling error
-
由 Lachlan Priest 提交于
existing_acrnoyms -> existing_acronyms
-
由 eileencodes 提交于
If a process is forked more than once, the pool was grabbing the oldest spec, not the most recent spec. This wasn't noticed before because most folks are lilely forking the process only once. If you're forking the process multiple times however the wrong spec name will be returned and an incorrect connection will be used for the process. This fixes the issue by reversing the list of spec names so we can grab the most recent spec rather than the oldest spec.
-
由 Eileen M. Uchitelle 提交于
CI against JRuby 9.1.7.0
-