- 13 11月, 2012 6 次提交
-
-
由 Carlos Antonio da Silva 提交于
Simplify code by taking advantage of latest mocha (v0.13.0).
-
由 Aaron Patterson 提交于
-
由 Carlos Antonio da Silva 提交于
`#as_json` isolates options when encoding a hash. Closes #8182
-
由 Aaron Patterson 提交于
-
由 Xavier Noria 提交于
voloko/sdoc seems to be maintained again, in particular the issues that made us fork it are resolved.
-
由 Carlos Antonio da Silva 提交于
Merge and add tests related to #5215
-
- 12 11月, 2012 5 次提交
-
-
由 Santiago Pastorino 提交于
-
由 Yves Senn 提交于
Setting options in a custom `#as_json` method had side effects. Modifications of the `options` hash leaked outside and influenced the conversion of other objects contained in the hash.
-
由 Vipul A M 提交于
-
由 James Mead 提交于
This only works with mocha v0.13.0 or later. Note that this also fixes a few subtle bugs present in the current implementation :- * Mocha was raising a `MiniTest::Assertion` instead of a `Mocha::ExpectationError` as intended. The latter is not recognized by MiniTest as an assertion failure and so it is recorded as a test *error*, not a test *failure* as it ought to. This leads to potentially confusing output in the test results. * Mocha verification should happen as part of the test. The verification of expectations is equivalent to a set of assertions. These assertions should happen as *part of* the test so that they have a chance to cause the test to fail, and not just as part of the teardown. Also if an assertion fails during the test, then there is no need to verify expectations, because only the first assertion failure is normally reported and all subsequent bets are off. * Expectation verification should be counted as an assertion. Mocha cannot record each expectation verification as an assertion, because we weren't passing in an assertion counter to `#mocha_verify`.
-
- 11 11月, 2012 9 次提交
-
-
由 Carlos Antonio da Silva 提交于
Match classes without to_s conversions.
-
由 Nikita Afanasenko 提交于
There is no need in `value_under_case.class.to_s` conversion since case already matches classes with `Class === value_under_case`.
-
由 Santiago Pastorino 提交于
Test Hash#diff deprecation, also prevent deprecation message in AS tests
-
由 Santiago Pastorino 提交于
Removing warning : ambiguous first argument
-
由 Nikita Afanasenko 提交于
-
由 Arun Agrawal 提交于
-
由 Jon Leighton 提交于
Two threads may be in method_missing at the same time. If so, they might both try to define the same delegator method. Such a situation probably wouldn't result in a particularly spectacular bug as one method would probably just be overridden by an identical method, but it could cause warnings to pop up. (It could be worse if method definition is non-atomic in a particular implementation.) (We will also need this mutex shortly anyway, see #8127.)
-
由 Vijay Dev 提交于
-
由 Vijay Dev 提交于
-
- 10 11月, 2012 9 次提交
-
-
由 Carlos Antonio da Silva 提交于
Removing warning : assigned but unused variable
-
由 Carlos Antonio da Silva 提交于
Remove unwanted transaction when has one association is built
-
由 Bogdan Gusiev 提交于
-
由 Arun Agrawal 提交于
-
由 Carlos Antonio da Silva 提交于
Keep the code related to serialization in Serialization module.
-
由 Nikita Afanasenko 提交于
We should not need any `serialized_attributes` checks outside `ActiveRecord::AttributeMethods::Serialization` module.
-
由 Rafael Mendonça França 提交于
Trivial documentation fix for ActiveModel::Naming comment [ci skip]
-
由 Dennis Taylor 提交于
-
由 Carlos Antonio da Silva 提交于
get is the most common usage, and match without an explicit verb was disallowed in 56cdc81c. [ci skip]
-
- 09 11月, 2012 11 次提交
-
-
由 Andrew White 提交于
Most apps upgrading from 3.x will have options for mass assigment in their application.rb and environments/*.rb config files. Rather than just raising a NoMethodError when copying the config, this commit adds a warning message until either the protected_attributes gem is installed or the relevant config options are removed.
-
由 Carlos Antonio da Silva 提交于
Deprecate Hash#diff.
-
由 Steve Klabnik 提交于
It's no longer used in Rails any more. See https://github.com/rails/rails/pull/8142\#issuecomment-10227297 for more
-
由 Carlos Antonio da Silva 提交于
These were removed with ActiveRecord::Model in https://github.com/rails/rails/commit/9e4c41c903e8e58721f2c41776a8c60ddba7a0a9#L15L156
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
Rather than just changing it and hoping for the best. Requested by @jeremy: https://github.com/rails/rails/commit/ba1544d71628abff2777c9c514142d7e9a159111#commitcomment-2106059
-
由 Rafael Mendonça França 提交于
Removing duplication in callback normalization.
-
由 Steve Klabnik 提交于
These two things were 100% identical.
-
由 Jon Leighton 提交于
:counter_cache option for to support custom named counter caches
-
由 Jon Leighton 提交于
So that the scope may be a NullRelation and return a result without executing a query. Fixes #7928
-
由 Jon Leighton 提交于
Fixes #8102. I couldn't find a nicer way to deal with this than delegate the call to #scope, which will be a NullRelation when we want it to be.
-