- 27 6月, 2018 10 次提交
-
-
由 alpaca-tc 提交于
-
由 Prem Sichanugrist 提交于
Add changelog entry for allow passing multiple exceptions to retry_on/discard_on (3110caec) [ci skip]
-
由 bogdanvlviv 提交于
Since it is changes of the public API, it seems valuable to add a mention about it to the changelog file. Follow up 3110caec
-
由 Aaron Patterson 提交于
Speed up homogeneous AR lists / reduce allocations
-
由 Aaron Patterson 提交于
-
由 Rafael França 提交于
Enable TESTOPTS in railties tests
-
由 Aaron Patterson 提交于
Now that `allocate` is removed, we need to define attribute methods in all "init" methods.
-
由 Aaron Patterson 提交于
* master: Call initialize after allocate Remove `ActiveSupport::Concern` from `ActiveRecord::Aggregations` Add example for no_touching? in active_record/no_touching for api docs [ci skip] Generate a new key for each service test
-
由 Aaron Patterson 提交于
Call initialize after allocate
-
由 Aaron Patterson 提交于
If someone calls allocate on the object, they'd better also call an initialization routine too (you can't expect allocate to do any initialization work). Before this commit, AR objects that are instantiated from the database would call `define_attribute_methods` twice.
-
- 26 6月, 2018 11 次提交
-
-
由 utilum 提交于
Unlike the other components' test suites, railties' currently ignores such useful options as `"--verbose"` or `"--name"`. This patch allows us to use them.
-
由 Ryuta Kamizono 提交于
`include Aggregations` no longer needs to invoke `extend Aggregations::ClassMethods` since 657060b5.
-
由 Ryuta Kamizono 提交于
Add example for no_touching? for api docs [ci skip]
-
由 Michael Munroe 提交于
There was no example code for ActiveRecord::NoTouching#no_touching?. This PR adds an example for the API docs.
-
由 Aaron Patterson 提交于
This commit speeds up allocating homogeneous lists of AR objects. We can know if the result set contains an STI column before initializing every AR object, so this change pulls the "does this result set contain an STI column?" test up, then uses a specialized instantiation function. This way we only have to check for an STI column once rather than N times. This change also introduces a new initialization function that is meant for use when allocating AR objects that come from the database. Doing this allows us to eliminate one hash allocation per AR instance. Here is a benchmark: ```ruby require 'active_record' require 'benchmark/ips' ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:" ActiveRecord::Migration.verbose = false ActiveRecord::Schema.define do create_table :users, force: true do |t| t.string :name t.timestamps null: false end end class User < ActiveRecord::Base; end 2000.times do User.create!(name: "Gorby") end Benchmark.ips do |x| x.report("find") do User.limit(2000).to_a end end ``` Results: Before: ``` [aaron@TC activerecord (master)]$ be ruby -I lib:~/git/allocation_tracer/lib speed.rb Warming up -------------------------------------- find 5.000 i/100ms Calculating ------------------------------------- find 56.192 (± 3.6%) i/s - 285.000 in 5.080940s ``` After: ``` [aaron@TC activerecord (homogeneous-allocation)]$ be ruby -I lib:~/git/allocation_tracer/lib speed.rb Warming up -------------------------------------- find 7.000 i/100ms Calculating ------------------------------------- find 72.204 (± 2.8%) i/s - 364.000 in 5.044592s ```
-
由 George Claghorn 提交于
Sidestep Google Cloud Storage's restrictive per-object rate limit.
-
由 Aaron Patterson 提交于
Lazily add `Aggregations` to `composed_of` models
-
由 George Claghorn 提交于
-
由 Aaron Patterson 提交于
`composed_of` is a fairly rare method to call on models. This commit adds the `Aggregations` module to models that call `composed_of` so that models that *don't* call `composed_of` don't need to instantiate the `aggregation_cache` hash. This saves one hash allocation per model instance that doesn't use `composed_of`
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
The "join" affix in `table_alias_for` was added 12 years ago at 02d34440 to address poor alias tracking. `AssociationScope` no longer uses the "join" suffixed alias since 0408e212 and had been removed at a1ec8b5b. `table_alias_for` is the last place that using the useless legacy suffixed alias, but we can't remove the suffix since some test cases directly refers the alias name by `where` with string literal, so at least removing the suffix would break our test cases. (e.g. https://github.com/rails/rails/blob/b2eb1d1c55a59fee1e6c4cba7030d8ceb524267c/activerecord/test/cases/associations/has_and_belongs_to_many_associations_test.rb#L699-L731).
-
- 25 6月, 2018 2 次提交
-
-
由 yuuji.yaginuma 提交于
This reverts commit 691addbf. Reason: v10.5.0 has been released, and it seems that the issue is fixed. Ref: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#10.5.0
-
由 George Claghorn 提交于
Changes Rails Welcome image on localhost:3000
-
- 24 6月, 2018 6 次提交
-
-
由 yuuji.yaginuma 提交于
-
由 Ryuta Kamizono 提交于
Update service.rb [ci skip]
-
由 ishanray 提交于
-
由 yuuji.yaginuma 提交于
-
由 Yuji Yaginuma 提交于
Update raabro to latest version
-
由 utilum 提交于
[v 1.1.6](https://github.com/floraison/raabro/blob/master/CHANGELOG.md#raabro-116--released-2018-06-22) fixes a warning we see on [Rails CI](https://travis-ci.org/rails/rails/jobs/395177524#L3763).
-
- 23 6月, 2018 3 次提交
-
-
由 Xavier Noria 提交于
[Jon Moss & Xavier Noria]
-
由 George Claghorn 提交于
Active Storage: Explicit form field in basic example
-
由 Henrik Nyh 提交于
Also fix syntax highlighting in the more advanced JS example.
-
- 22 6月, 2018 4 次提交
-
-
由 bogdanvlviv 提交于
Note that I used https://www.base64-image.de/ in order to convert the image to Base64 with enabled optimization status. Closes #33181. Closes #33186. Follow up #32735.
-
由 Prem Sichanugrist 提交于
Add to docs mention about `:year_format` option of date select
-
由 bogdanvlviv 提交于
Follow up #32190 [ci skip]
-
由 Ryuta Kamizono 提交于
-
- 21 6月, 2018 4 次提交
-
-
由 George Claghorn 提交于
-
由 Yuji Yaginuma 提交于
Update fugit to latest version
-
由 utilum 提交于
[fugit 1.1.3](https://github.com/floraison/fugit/commit/03a3ee86f3cd5d929442dd25896b99acbd151947) fixes warnings that show up in ActiveJob tests. See [CI](https://travis-ci.org/rails/rails/jobs/394107740#L3764-L3778).
-
由 Ryuta Kamizono 提交于
Add `use_year_names` option to date_select tag
-