- 29 8月, 2014 18 次提交
-
-
由 Robin Dupret 提交于
-
Asserting that the message contains "QUERY PLAN" is enough for the adapter's test. The plan may vary according to number of tuples etc. but that's out of our concern.
-
由 Yves Senn 提交于
[ActiveJob] extract JobBuffer from helper
-
由 Abdelkader Boudih 提交于
-
由 Yves Senn 提交于
This reverts commit 16fe1983, reversing changes made to 4c81c8ce. The call to `Model.reset_column_information` was to express the intent of the test. `reset_column_information` itself can trigger SQL queries because it checks for a tables existance. Let's move it outside of the block. /cc @sgrif
-
由 Yves Senn 提交于
[ci skip] Fix example code of ActiveRecord::FixtureSet.context_class
-
由 Yves Senn 提交于
Don't rescue IPAddr::InvalidAddressError
-
由 Peter Suschlik 提交于
IPAddr::InvalidAddressError does not exist in Ruby 1.9.3 and fails for JRuby in 1.9 mode. As IPAddr::InvalidAddressError is a subclass of ArgumentError (via IPAddr::Error) just rescuing ArgumentError is fine.
-
由 yuuji.yaginuma 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Aaron Patterson 提交于
Fix the router ignoring constraints when used together with a redirect route
-
由 Godfrey Chan 提交于
Using heredoc would enforce line wrapping to whatever column width we decided to use in the code, making it difficult for the users to read on some consoles. This does make the source code read slightly worse and a bit more error-prone, but this seems like a fair price to pay since the primary purpose for these messages are for the users to read and the code will not stick around for too long.
-
- 28 8月, 2014 21 次提交
-
-
由 Akira Matsuda 提交于
-
由 Yves Senn 提交于
[ci skip]
-
由 Akira Matsuda 提交于
This test would fail when executed after any test that calls fixtures(:binaries)
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
There exists some other test files that load :minivans fixtures but don't load :speedometers. Loading :speedometers here prevents the following error when this test was run after such test: CalculationsTest#test_should_group_by_association_with_non_numeric_foreign_key: ActiveRecord::RecordNotFound: Couldn't find all Speedometers with 'speedometer_id': (ABC, s1) (found 1 results, but was looking for 2)
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
Dir.glob result must be already sorted anyway
-
由 Akira Matsuda 提交于
This actually was testing test everything, so why not do it simpler?
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Rafael Mendonça França 提交于
Add language directive to .travis.yml
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
the ERB has already been compiled to Ruby code by the time we're calling module_eval. Nothing that module eval raises will be caught by a blank `rescue`, so I think we can remove this
-
由 Hiro Asari 提交于
Currently, Travis CI assumes that the project is in Ruby in the absence of the `language` key. This behavior may change in the future. (For example, switch to a "blank" image which *may* be created.)
-
由 Guillermo Iguaran 提交于
Refactor out Dir.glob from ActionDispatch::Static
-
由 schneems 提交于
Dir.glob can be a security concern. The original use was to provide logic of fallback files. Example a request to `/` should render the file from `/public/index.html`. We can replace the dir glob with the specific logic it represents. The glob {,index,index.html} will look for the current path, then in the directory of the path with index file and then in the directory of the path with index.html. This PR replaces the glob logic by manually checking each potential match. Best case scenario this results in one less file API request, worst case, this has one more file API request. Related to #16464 Update: added a test for when a file of a given name (`public/bar.html` and a directory `public/bar` both exist in the same root directory. Changed logic to accommodate this scenario.
-
由 Zachary Scott 提交于
[ci skip] mention assert_select in release notes
-
- 27 8月, 2014 1 次提交
-
-
由 Sam Ruby 提交于
-