- 14 8月, 2012 5 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Let Rake control the cache directories. If the directory already exists, rake will skip creating it (vs the previous task which would always try to mkdir_p)
-
由 Rafael Mendonça França 提交于
Add start_hour and end_hour options for select_hour helper
-
由 Evan Tann 提交于
Updated documentation to demonstrate start_hour and end_hour options
-
- 13 8月, 2012 5 次提交
-
-
由 Aaron Patterson 提交于
Evented notifications should take priority over Timed
-
由 Rafael Mendonça França 提交于
Grammar fix in ActionView Form Tag Helper docs/comments
-
由 Edward Ocampo-Gooding 提交于
-
由 Xavier Noria 提交于
Missing closing tag
-
由 Ellis Berner 提交于
-
- 12 8月, 2012 7 次提交
-
-
由 Rafael Mendonça França 提交于
Restore state on create when ActiveRecord::RecordInvalid is raised
-
由 Dave Yeu 提交于
This fixes issue #3217.
-
由 Eric Saxby 提交于
In cases where a notification subscriber includes methods to support both Evented and Timed events, Evented should take priority over Timed. This allows subscribers to be backwards compatible (older Rails only allows Timed events) while defaulting to newer behavior.
-
由 Carlos Antonio da Silva 提交于
We can avoid creating extra hashes with #merge, and use #merge! instead.
-
由 Carlos Antonio da Silva 提交于
Further simplify the option_html_attributes method after the changes introduced in dacbcbe5 to not escape the html options here (since they're going to be escaped down the chain in content tag).
-
由 Carlos Antonio da Silva 提交于
Under a "private" call, class methods are not real private methods, they're public just like any other method. Make model_name_from_record_or_class a private class method, and nodoc it.
-
由 Rafael Mendonça França 提交于
-
- 11 8月, 2012 23 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Vijay Dev 提交于
Added changelog entry for table name prefix fix [ci skip]
-
由 Wojciech Wnętrzak 提交于
-
由 Piotr Sarnacki 提交于
-
由 Carlos Antonio da Silva 提交于
Closes #6290
-
由 Carlos Antonio da Silva 提交于
Always merge I18n format values, namespaced or not, over the default ones, to ensure I18n format defaults will have precedence over our namespaced values. Precedence should happen like this: default :format default :namespace :format i18n :format i18n :namespace :format Because we cannot allow our namespaced default to override a I18n :format config - ie precision in I18n :format should always have higher precedence than our default precision for a particular :namespace. Also simplify default format options logic.
-
由 Carlos Antonio da Silva 提交于
Action Pack already comes with a default locale fine for :en, that is always loaded. We can just fallback to this locale for defaults, if values for the current locale cannot be found. Closes #4420, #2802, #2890.
-
由 Carlos Antonio da Silva 提交于
Removed in 0228a73b, pull request #7310.
-
由 Rafael Mendonça França 提交于
Check for Blank Record in form_for
-
由 Rafael Mendonça França 提交于
Move AD default_headers configurations to railtie
-
由 schneems 提交于
if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem.
-
由 Guillermo Iguaran 提交于
Add documentation for config.action_dispatch.default_headers to Rails Configuring guide.
-
由 Carlos Antonio da Silva 提交于
Return the conditions from the keep_if call, and ignore the value argument since it's not being used.
-
由 Guillermo Iguaran 提交于
ActionDispatch railtie is a better place for config.action_dispatch.default_headers settings, users can continue overriding those settings in their configuration files if needed.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
Method compilation provides better performance and I think the code comes out cleaner as well. A knock on effect is that methods that get redefined produce warnings. I think this is a good thing. I had to deal with a bunch of warnings coming from our tests, though.
-
由 Piotr Sarnacki 提交于
When you mount your application at a path, for example /myapp, server should set SCRIPT_NAME to /myapp. With such information, rails application knows that it's mounted at /myapp path and it should generate routes relative to that path. Before this patch, rails handled SCRIPT_NAME correctly only for regular apps, but it failed to do it for mounted engines. The solution was to hardcode default_url_options[:script_name], which is not the best answer - it will work only when application is mounted at a fixed path. This patch fixes the situation by respecting original value of SCRIPT_NAME when generating application's routes from engine and the other way round - when you generate engine's routes from application. This is done by using one of 2 pieces of information in env - current SCRIPT_NAME or SCRIPT_NAME for a corresponding router. This is because we have 2 cases to handle: - generating engine's route from application: in this situation SCRIPT_NAME is basically SCRIPT_NAME set by the server and it indicates the place where application is mounted, so we can just pass it as :original_script_name in url_options. :original_script_name is used because if we use :script_name, router will ignore generating prefix for engine - generating application's route from engine: in this situation we already lost information about the SCRIPT_NAME that server used. For example if application is mounted at /myapp and engine is mounted at /blog, at this point SCRIPT_NAME is equal /myapp/blog. Because of that we need to keep reference to /myapp SCRIPT_NAME by binding it to the current router. Later on we can extract it and use when generating url Please note that starting from now you *should not* use default_url_options[:script_name] explicitly if your server already passes correct SCRIPT_NAME to rack env. (closes #6933)
-
由 Santiago Pastorino 提交于
RouteSet: refactor internals
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
Well, not all of them, but some of them. I don't think there's much reason for these methods to be private.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
We don't need the complexity of to_sentence, and it shouldn't be a bang method.
-