1. 12 8月, 2015 1 次提交
    • J
      Make disable_with default in submit_tag · 3822a322
      Justin Schiff 提交于
      Prevents double submission by making disable_with the default.
      
      Default disable_with option will only be applied if user has not
      specified her/his own disable_with option, whether that is in the
      `data-disable-with` string form or the
      `:data => { :disable_with => "Saving..." }` hash form. disable_with
      will default to the value attribute.
      
      A configuration option was added to opt out of this functionality if
      the user so desires.
      `config.action_view.automatically_disable_submit_tag = false`
      3822a322
  2. 29 7月, 2015 1 次提交
  3. 17 7月, 2015 1 次提交
  4. 14 7月, 2015 1 次提交
  5. 30 6月, 2015 1 次提交
    • R
      integration_tool defaults to :test_unit · be0b218c
      Ryan Bigg 提交于
      As per railties/lib/rails/test_unit/railtie.rb, where it sets it explicitly.
      
      This can be confirmed by starting a new Rails console session in a new app and running this code:
      
      Rails.application.config.app_generators.rails[:integration_tool]
      
      I also beefed up the documentation slightly to be more explicit about what this configuration setting does.
      be0b218c
  6. 09 6月, 2015 1 次提交
  7. 07 6月, 2015 2 次提交
  8. 04 6月, 2015 1 次提交
  9. 03 6月, 2015 1 次提交
  10. 01 6月, 2015 1 次提交
  11. 28 5月, 2015 1 次提交
  12. 21 5月, 2015 1 次提交
  13. 18 5月, 2015 2 次提交
  14. 17 5月, 2015 1 次提交
  15. 11 5月, 2015 1 次提交
  16. 28 4月, 2015 1 次提交
  17. 15 4月, 2015 1 次提交
    • J
      Fix typos and improve the documentation · 6345f31f
      Jon Atack 提交于
      This is a squash of the following commits, from first to last:
      
      -
      
      Fix minor, random things I’ve come across lately that individually
      did not seem worth making a PR for, so I saved them for one commit.
      
      One common error is using “it’s” (which is an abbreviation of “it is”)
      when the possessive “its” should be used for indicating possession.
      
      -
      
      Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
      
      -
      
      Line wrap the changes at 80 chars and add one more doc fix.
      
      -
      
      Add a missing line wrap in the Contributing to Ruby on Rails Guide.
      
      -
      
      Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
      
      Rendering the guide locally with `bundle exec rake guides:generate` did
      not show any change in on-screen formatting after adding the line wrap.
      
      The HTML generated is (extra line added to illustrate where the line
      wrap takes place):
      
          <div class="info"><p>Please squash your commits into a single commit
      when appropriate. This
      
          simplifies future cherry picks and also keeps the git log
      clean.</p></div>
      
      -
      
      Squash commits.
      6345f31f
  18. 10 4月, 2015 1 次提交
  19. 01 4月, 2015 1 次提交
  20. 27 3月, 2015 1 次提交
  21. 18 3月, 2015 1 次提交
  22. 07 3月, 2015 1 次提交
  23. 05 3月, 2015 1 次提交
  24. 04 3月, 2015 2 次提交
  25. 22 2月, 2015 2 次提交
  26. 17 2月, 2015 2 次提交
  27. 15 1月, 2015 1 次提交
  28. 14 1月, 2015 1 次提交
  29. 07 1月, 2015 1 次提交
  30. 06 1月, 2015 1 次提交
  31. 03 1月, 2015 1 次提交
    • C
      Add config to halt callback chain on return false · 9c65c539
      claudiob 提交于
      This stems from [a comment](rails#17227 (comment)) by @dhh.
      In summary:
      
      * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning.
      * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning.
      
      For this purpose, this commit introduces a Rails configuration option:
      
      ```ruby
      config.active_support.halt_callback_chains_on_return_false
      ```
      
      For new Rails 5.0 apps, this option will be set to `false` by a new initializer
      `config/initializers/callback_terminator.rb`:
      
      ```ruby
      Rails.application.config.active_support.halt_callback_chains_on_return_false = false
      ```
      
      For existing apps ported to Rails 5.0, the initializers above will not exist.
      Even running `rake rails:update` will not create this initializer.
      
      Since the default value of `halt_callback_chains_on_return_false` is set to
      `true`, these apps will still accept `return true` as a way to halt callback
      chains, displaying a deprecation warning.
      
      Developers will be able to switch to the new behavior (and stop the warning)
      by manually adding the line above to their `config/application.rb`.
      
      A gist with the suggested release notes to add to Rails 5.0 after this
      commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
      9c65c539
  32. 30 12月, 2014 1 次提交
  33. 29 12月, 2014 1 次提交
  34. 24 12月, 2014 1 次提交
  35. 22 12月, 2014 1 次提交