- 21 7月, 2012 2 次提交
-
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
This code is broken (it should say association_scope.uniq_value rather than options[:uniq]) but the tests still pass. I think it is designed to uniq-ify associations using finder_sql. However, I am about to remove that anyway.
-
- 20 7月, 2012 2 次提交
-
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
This fixes active_record_deprecated_finders.
-
- 19 7月, 2012 3 次提交
-
-
由 Carlos Antonio da Silva 提交于
Lets stick with a symbol in join table name, it was removed in 993e1643 and broke the build.
-
由 José Valim 提交于
-
由 Aleksey Magusev 提交于
-
- 18 7月, 2012 6 次提交
-
-
由 Dave Kroondyk 提交于
Commit 3dbedd28 added NOT NULL constraints to timestamps. Commit fcef7289 started to revert this, but was incomplete. With this commit, 3dbedd28 should be fully reverted and timestamps will no longer default to NOT NULL.
-
由 José Valim 提交于
-
由 John Firebaugh 提交于
Integration's definition of #to_param must override Conversion's. Otherwise, there is a regression from 3.1 in the behavior of a non-persisted AR::Base instance which nevertheless has an id.
-
由 Aleksey Magusev 提交于
For instance, running rails g migration CreateMediaJoinTable artists musics:uniq will create a migration with create_join_table :artists, :musics do |t| # t.index [:artist_id, :music_id] t.index [:music_id, :artist_id], unique: true end
-
由 kennyj 提交于
-
由 kennyj 提交于
-
- 17 7月, 2012 1 次提交
-
-
由 beerlington 提交于
Fixes issue with overrding ActiveRecord reader methods with a composed object and using that attribute as the scope of a validates_uniqueness_of validation.
-
- 16 7月, 2012 1 次提交
-
-
由 Kang Wen 提交于
-
- 15 7月, 2012 2 次提交
- 14 7月, 2012 16 次提交
-
-
由 kennyj 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Conflicts: activerecord/test/cases/query_cache_test.rb
-
由 Jeremy Cole 提交于
Conflicts: activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
-
由 Jeremy Cole 提交于
Prepared statements (prepare/execute/close) were being used unnecessarily when no bind variables were present, and disabling prepared statement using prepared_statements:false was principally broken. While bind variables were correctly substituted with prepared_statements:false, the prepared statement interface was still used, costing an extra two round trips per query. In addition to making this behavioral change, I also cleaned up the internals of exec_stmt and exec_without_stmt so that they behave the same (calling log and constructing the ActiveRecord::Result in the same way). Moving the check for binds.empty? to exec_query also will mean that several code paths explicitly calling exec_without_stmt could be cleaned up to once again call exec_query instead. I have also left the check for binds.empty? in exec_stmt, since it is not a private method and could be called directly with an empty binds array. For the sake of clarity in this patch, I have not made those changes. = The previous behavior = When issuing a Foo.find(1) with prepared_statements:true, the bind variable is present in the prepared query, and execute shows a value passed: Connect root@localhost on rails_test Query SET SQL_AUTO_IS_NULL=0 Statistics Query SHOW FULL FIELDS FROM `foos` Query SHOW TABLES LIKE 'foos' Query SHOW CREATE TABLE `foos` Prepare SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = ? LIMIT 1 Execute SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Close stmt Quit When issuing a Foo.find(1) with prepared_statements:false, the bind variable has already been removed and substituted with the value, but the prepared statement interface is used anyway: Connect root@localhost on rails_test Query SET SQL_AUTO_IS_NULL=0 Statistics Query SHOW FULL FIELDS FROM `foos` Query SHOW TABLES LIKE 'foos' Query SHOW CREATE TABLE `foos` Prepare SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Execute SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Close stmt Quit = With this patch applied = When issuing a Foo.find(1) with prepared_statements:true, the bind variable is present in the prepared query, and execute shows a value passed: Connect root@localhost on rails_test Query SET SQL_AUTO_IS_NULL=0 Statistics Query SHOW FULL FIELDS FROM `foos` Query SHOW TABLES LIKE 'foos' Query SHOW CREATE TABLE `foos` Prepare SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = ? LIMIT 1 Execute SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Close stmt Quit When issuing a Foo.find(1) with prepared_statements:false, the bind variable has been removed and substituted with the value, and the query interface is used instead of the prepared statement interface: Connect root@localhost on rails_test Query SET SQL_AUTO_IS_NULL=0 Statistics Query SHOW FULL FIELDS FROM `foos` Query SHOW TABLES LIKE 'foos' Query SHOW CREATE TABLE `foos` Query SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Quit
-
由 Jon Leighton 提交于
-
由 kennyj 提交于
-
由 kennyj 提交于
-
由 Xavier Noria 提交于
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 kennyj 提交于
-
由 Katrina Owen 提交于
-
由 Katrina Owen 提交于
-
由 Katrina Owen 提交于
The instructions about configuration covered only rails-specific usage.
-
由 Jon Leighton 提交于
-
- 13 7月, 2012 4 次提交
-
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
- 11 7月, 2012 1 次提交
-
-
由 Robb Kidd 提交于
Dry up reseting the renamed table after each test. Also made use of the AR::Base.connection object already available from AR::MigrationTest#connection.
-
- 09 7月, 2012 1 次提交
-
-
由 Aleksey Magusev 提交于
AddXXXToYYY/RemoveXXXFromYYY migrations are produced with references statements, for instance rails g migration AddReferencesToProducts user:references supplier:references{polymorphic} will generate the migration with: add_reference :products, :user, index: true add_reference :products, :supplier, polymorphic: true, index: true
-
- 08 7月, 2012 1 次提交
-
-
由 Oscar Del Ben 提交于
-