This is both faster and more correct, added tests to make sure this is not reverted again.

so that it is consistent with the error thrown for +find+ without an
inverse_of association.

inverse_of option. I've also refactored the code for raising a
RecordNotFound exception when searching for records with ids.

deprecated

Fixes activerecord-deprecated_finders build.

https://travis-ci.org/rails/activerecord-deprecated_finders/builds/5964703

enum includes text or blob or ... hooked by wrong regex

This way the available options are only built for actually fetching the
algorithm in case the option is given.

The options are going to be necessary a second time only in case the option
is given but does not exist, which is supposed to be due to a typo or
something like that, so no problem.

When building the indexes list in PostgreSQL, IndexDefinition objects
are only created if the query for the related attributes really returns
something matching the attributes.

In case it does not, the variables for building the definition objects were
being created but not used.

The file name should be name_scoping_test.rb and the class should be
`NamedScopingTest` according to ActiveRecord::Scoping::Name

The scoping/default.rb and scoping/named.rb got moved under scoping/ in
commit 2b22564c,
but the tests never did.

This seems to be a legacy file, I cannot find any place where it is used.

added comments to test_invalid_type in sqlite3 adapter test and added valid_type? method to abstract_adapter.rb and removed unnecessary method from sqlite3 adapter