- 28 5月, 2018 2 次提交
-
-
由 yuuji.yaginuma 提交于
Because the same method is defined in `FormWithTest` of the parent class. https://github.com/rails/rails/blob/fe9547b6fb60d92af181c8613166fa4322f8e307/actionview/test/template/form_helper/form_with_test.rb#L19..L26
-
由 Ryuta Kamizono 提交于
Since `parse_raw_value_as_a_number` may not always parse raw value from database as a number without type casting (e.g. "$150.55" as money format). Fixes #32531.
-
- 27 5月, 2018 3 次提交
-
-
由 Ryuta Kamizono 提交于
Since #31405, using `#increment!` with touch option instead of `#touch` to touch belongs_to association if counter cache is enabled. It caused the regression since `#increment!` won't invoke after_touch callbacks even if touch option is given. To fix the regression, make `#increment!` invokes after_touch callbacks if touch option is given. Fixes #31559. Fixes #32408.
-
由 Ryuta Kamizono 提交于
On belongs_to with `touch: true` association, unassigned object is caused touching, but assigned object is not touched. And also, if primary key is customized, it will touch against the wrong target looked up by the customized key as primary key. This change ensures correctly touching consistently between assigning and unassigning.
-
由 Ryuta Kamizono 提交于
-
- 26 5月, 2018 3 次提交
-
-
由 Ryuta Kamizono 提交于
Since UPDATE with a subquery doesn't work on MySQL.
-
由 Ryuta Kamizono 提交于
If belongs_to primary key is customized, the callback will update counters against the wrong target looked up by the customized key as primary key. We need to convert the customized key into an object that can be referred to as primary key.
-
由 Ryuta Kamizono 提交于
-
- 25 5月, 2018 6 次提交
-
-
由 Ryuta Kamizono 提交于
Since #31575, `BelongsToAssociation#target=` replaces owner record's foreign key to fix an inverse association bug. But the method is not only used for inverse association but also used for eager loading/preloading, it caused some public behavior changes (#32338, #32375). To avoid any side-effect in loading associations, I reverted the overriding `#target=`, then introduced `#inversed_from` to replace foreign key in `set_inverse_instance`. Closes #32375.
-
由 Ryuta Kamizono 提交于
Since #26074, introduced force equality checking to build a predicate consistently for both `find` and `create` (fixes #27313). But the assumption that only array/range attribute have subtype was wrong. We need to make force equality checking more strictly not to allow serialized attribute. Fixes #32761.
-
由 George Claghorn 提交于
Improve grammar for DateAndTime before? and after? calculations [ci skip]
-
由 Aaron Sumner 提交于
-
由 Ryuta Kamizono 提交于
Update stale issue comment to mention 5-2-stable
-
由 Eugene Kenny 提交于
5-2-stable is the release series that currently receives bug fixes.
-
- 24 5月, 2018 12 次提交
-
-
由 Guillermo Iguaran 提交于
update README link: md instead rdoc
-
由 Oscar Amado 提交于
-
由 Guillermo Iguaran 提交于
correct link to activejob readme [ci skip]
-
由 Oscar Amado 提交于
-
由 George Claghorn 提交于
Avoid 2.6 warning: shadowing outer local variable - list
-
由 utilum 提交于
-
由 Rafael Mendonça França 提交于
Minimize Spring.watch calls
-
由 Rafael França 提交于
Enable warnings in all test tasks
-
由 utilum 提交于
Also normalize AJ task use t, like all other Rails test tasks.
-
由 Samuel Cochran 提交于
* Eager autoload mail gem when eager load is true We had a production issue where our Sidekiq worker threads all became deadlocked while autoloading a file within the mail gem, required via ActionMailer, despite setting our Rails applicaiton to eager load. `Mail.eager_autoload!` exists and works great, ActionMailer just doesn't call it during eager loading. Adding it to the ActionMailer Railtie's eager_load_namespaces takes care of calling `Mail.eager_autoload!` during the `eager_load!` initializer. * 'Mail' isn't defined yet, use before_eager_load instead * Make sure mail is loaded * Move eager load of Mail into ActionMailer.eager_load! [Samuel Cochran + Rafael Mendonça França]
-
由 Javan Makhmali 提交于
Change Active Storage’s video preview format from PNG to JPG
-
由 Javan Makhmali 提交于
-
- 23 5月, 2018 14 次提交
-
-
由 Eileen M. Uchitelle 提交于
remove unnecessary mocking in ActionCable tests
-
由 yuuji.yaginuma 提交于
Follow up of #32958.
-
由 Rafael França 提交于
Clearer error message in assert_changes
-
由 Rafael França 提交于
Respect NODE_ENV when running `rails yarn:install`
-
由 Rafael França 提交于
Document require_dependency [ci skip]
-
由 George Claghorn 提交于
Add ActiveStorage::Service::DiskService#url_for_direct_upload test
-
由 Rafael França 提交于
Indicate `true` in a doc comment is code-like.
-
由 Corey Farwell 提交于
-
由 Guillermo Iguaran 提交于
Thor 0.18 is causing failures in all the generator tests.
-
由 Rafael França 提交于
FIX: tt.eclosure is not needed for the GTG
-
由 Guillaume Malette 提交于
* Rollback parent transaction when children fails to update Rails supports autosave associations on the owner of a `has_many` relationship. In certain situation, if the children of the association fail to save, the parent is not rolled back. ```ruby class Employee < ActiveRecord::Base end class Company < ActiveRecord::Base has_many(:employees) end company = Company.new employee = company.employees.new company.save ``` In the previous example, if the Employee failed to save, the Company will not be rolled back. It will remain in the database with no associated Employee. I expect the `company.save` call to be atomic, and either create all or none of the records. The persistance of the Company already starts a transaction that nests it's children. However, it didn't track the success or failure of it's children in this very situation, and the outermost transaction is not rolled back. This PR makes the change to track the success of the child insertion and rollback the parent if any of the children fail. * Change the test to reflect what we expect Once #32862 is merged, rolling back a record will rollback it's state to match the state before the database changes were applied * Use only the public API to express the tests * Refactor to avoid reassigning saved for nested reflections [Guillaume Malette + Rafael Mendonça França]
-
由 utilum 提交于
Introduced in rails/journey@a806beb [ci skip]
-
由 Rafael França 提交于
Fix locale selector to email preview
-
由 Rafael França 提交于
Disable foreign keys during `alter_table` for sqlite3 adapter
-