- 04 4月, 2014 1 次提交
-
-
由 Arthur Neves 提交于
Add tests to make sure scopes cannot be create with names such as: private, protected, public. Make sure enum values don't collide with those methods too.
-
- 03 4月, 2014 4 次提交
-
-
由 Lauro Caetano 提交于
It was causing error when using `with_options` passing a lambda as its last argument. class User < ActiveRecord::Base with_options dependent: :destroy do |assoc| assoc.has_many :profiles, -> { where(active: true) } end end It was happening because the `option_merger` was taking the last argument and checking if it was a Hash. This breaks the HasMany usage, because its last argument can be a Hash or a Proc. As the behavior described in this test: https://github.com/rails/rails/blob/master/activesupport/test/option_merger_test.rb#L69 the method will only accept the lambda, this way it will keep the expected behavior. See 9eaa0a34
-
由 Dmitry Lavrov 提交于
-
由 Guo Xiang Tan 提交于
-
由 Matthew Draper 提交于
This is all about the case where we have a `DATABASE_URL`, and we have a `database.yml` present, but the latter doesn't contain the key we're looking for. If the key is a symbol, we'll always connect to `DATABASE_URL`, per the new behaviour in 283a2ede. If the key is a string, on the other hand, it should always be a URL: the ability to specify a name not present in `database.yml` is new in this version of Rails, and that ability does not stretch to the deprecated use of a string in place of a symbol. Uncovered by @guilleiguaran while investigating #14495 -- this actually may be related to the original report, but we don't have enough info to confirm.
-
- 02 4月, 2014 7 次提交
-
-
-
由 Matthew Draper 提交于
Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll change to the absolute-path interpretation in 4.2. The current "correct" spellings for in-memory, relative, and absolute URLs, respectively, are: sqlite3::memory: sqlite3:relative/path sqlite3:/full/path Substantially reverses/defers fbb79b51. Uncovered by @guilleiguaran while investigating #14495, though that sounds like a different issue.
-
由 Rajarshi Das 提交于
connection.
-
由 Dave Lee 提交于
Expand the query used in #table_exists? to include materialized views in the kinds of relations it searches.
-
由 Yves Senn 提交于
Also do not use transactional fixtures. We drop the type and the table after every run, so there is nothing for the transaction to clean up.
-
由 Guo Xiang Tan 提交于
Creating and dropping similar tables within the same connection causes postgresql to look up old values in the cache of tables which have already been dropped.
-
- 01 4月, 2014 4 次提交
-
-
由 Yves Senn 提交于
I ran the whole test suite and compared the old to the new types. Following is the list of types that did change with this patch: ``` DIFFERENT TYPE FOR mood: NEW: enum, BEFORE: DIFFERENT TYPE FOR floatrange: NEW: floatrange, BEFORE: float ``` The `floatrange` is a custom type. The old type `float` was simply a coincidence form the name `floatrange` and our type-guessing.
-
由 eileencodes 提交于
set assert_sql to reuse the capture_sql method from above instead of repeating the code in response to comments on issue #14546
-
由 eileencodes 提交于
delete_all sql if an association is not loaded should behave the same as if the association is loaded. This test ensures the SQL statements are exactly the same.
-
由 eileencodes 提交于
Other methods compare specific patterns, this method outputs the actual sql query that is generated.
-
- 31 3月, 2014 3 次提交
-
-
由 thedarkone 提交于
The new method relies on AR::Associations::Association knowing about both reflection and a model class. AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
-
由 thedarkone 提交于
Defer to Association#klass instead of having a custom/duplicate code.
-
由 Luke Steensen 提交于
fixes #10613
-
- 30 3月, 2014 1 次提交
-
-
由 Guo Xiang Tan 提交于
Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
-
- 29 3月, 2014 2 次提交
-
-
由 Godfrey Chan 提交于
460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
-
- 28 3月, 2014 6 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-
由 Rafael Mendonça França 提交于
Swap Timestamp/Callbacks order in ActiveRecord::Base
-
由 chrisfinne 提交于
custom primary_key that didn't save due to validation error
-
由 Henrik Nyh 提交于
It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
-
- 27 3月, 2014 5 次提交
-
-
由 Yves Senn 提交于
When the tests are executed in order, the dependency is loaded at the right time. However this makes it impossible to execute a single test later down the line. Let's require the dependecy at the beginning to get them working independent of the order. This resolves the following error: ``` $ ARCONN=postgresql ruby -Itest /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb -n test_to_xml Using postgresql Run options: -n test_to_xml --seed 51819 E Finished in 0.081320s, 12.2971 runs/s, 0.0000 assertions/s. 1) Error: DatabaseConnectedXmlSerializationTest#test_to_xml: NameError: uninitialized constant DatabaseConnectedXmlSerializationTest::REXML /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb:226:in `test_to_xml' ``` /cc @tgxworld fyi
-
由 Yves Senn 提交于
This will keep the test suite passing with older PG installations.
-
由 Lauro Caetano 提交于
It is supposed to raise ActiveRecord::InvalidForeignKey when the database has a fk constraint.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
- 26 3月, 2014 4 次提交
-
-
由 Steve Rice 提交于
Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
-
由 Cody Cutrer 提交于
This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit 6e3ab3e1, reversing changes made to 39e07b64. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
-
- 25 3月, 2014 2 次提交
-
-
由 Aaron Patterson 提交于
arel methods are not supposed to be public API for ActiveRecord
-
由 Aaron Patterson 提交于
This abstracts us from the actual construction of the nodes
-
- 23 3月, 2014 1 次提交
-
-
由 Guo Xiang Tan 提交于
Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
-