- 18 9月, 2017 8 次提交
-
-
由 Ryuta Kamizono 提交于
Class level `update` and `destroy` are using `find` in the internal, so it will raise `RecordNotFound` if given ids cannot find an object even though the method already affect (update or destroy) to any objects. These methods should return affected objects even in that case.
-
由 Ryuta Kamizono 提交于
The docs are obviously for class level `update`, `destroy`, and `delete`. It should be placed in `Persistence::ClassMethods` rather than `Relation`. And also, these methods are not dependent on relation. So it is not needed to delegate to `all` (plus, `klass.find` is faster than `relation.find`).
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Related 2b5f5cdd. If `reflection.scope` isn't given, `reflection_scope` is always empty scope. It is unnecessary to merge it.
-
由 Ryuta Kamizono 提交于
Related 2b5f5cdd. If `through_scope` is empty scope, it is unnecessary to merge it. And also, comparing relations is a little expensive (will cause `build_arel`). It is enough to use `empty_scope?` to determine whether empty scope.
-
由 Ryuta Kamizono 提交于
`through_scope` is not empty scope if `options[:source_type]` is given.
-
由 Ryuta Kamizono 提交于
Add missing round bracket in "Ruby on Rails 5.1 Release Notes" guide [ci skip]
-
由 bogdanvlviv 提交于
[ci skip]
-
- 17 9月, 2017 14 次提交
-
-
由 Ryuta Kamizono 提交于
Add `mini_magick` to default `Gemfile` as comment
-
由 Ryuta Kamizono 提交于
Fix docs describing rollback [ci skip]
-
由 Yoshiyuki Hirano 提交于
* If we want to transform image on ActiveStorage, we should bundle `mini_magick`. * I've added comment block to default `Gemfile` to be easier to install this.
-
由 dixpac 提交于
* `rails db:migrate STEP = 2` will not rollback the migrations, instead `rails db:rollback STEP = 2` will do the rollback. * Also, rewritten `rails db:migrate VERSION` => `rails db:rollback VERSION` for consistency.
-
由 Ryuta Kamizono 提交于
Update plugins.md [ci skip]
-
由 Ryuta Kamizono 提交于
Add local option to Message form [ci skip]
-
由 Yauheni Dakuka 提交于
-
由 Kasper Timm Hansen 提交于
Fix file missing in activestorage's example code [ci skip]
-
由 Yoshiyuki Hirano 提交于
* File.open("~/face.jpg") raise error: `Errno::ENOENT: No such file or directory @ rb_sysopen - ~/face.jpg`
-
由 Kasper Timm Hansen 提交于
Add tests for credentials command
-
由 Yoshiyuki Hirano 提交于
* MessagesController redirects to `GET /message/:id`. * It looks it don't expect XHR request. * `form_with` behaves for XHR by default. * I've added `local: true` option to `form_with`.
-
由 Ryuta Kamizono 提交于
Remove frozen_string_literal magic comment from templates
-
由 yuuji.yaginuma 提交于
Follow up of #30348
-
由 George Claghorn 提交于
Don't expose Active Storage routes
-
- 16 9月, 2017 3 次提交
-
-
由 Ryuta Kamizono 提交于
Fix typo: `credentails` -> `credentials` [ci skip]
-
由 yuuji.yaginuma 提交于
Follow up of ca18922a
-
由 yuuji.yaginuma 提交于
These routes are only used internally in Active Storage, and it seems that there is no need for the user to directly use them. Therefore, I think that routes should not be exposed to users.
-
- 15 9月, 2017 9 次提交
-
-
由 Kasper Timm Hansen 提交于
Update Getting Started with Rails [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Yoshiyuki Hirano 提交于
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
Most interesting to us, 2.4.2 and 2.3.5 include the fix for https://bugs.ruby-lang.org/issues/13632
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Do not add master key and credentials when `pretend` option is specified
-
由 Kasper Timm Hansen 提交于
Make master key added to gitignore the same value as when creating appplication
-
- 14 9月, 2017 6 次提交
-
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
It is only used `primary_key` and `connection` in the internal, so it is not needed to delegate others to `klass` explicitly. This doesn't change public behavior because `relation` will delegate missing method to `klass`.
-
由 Ryuta Kamizono 提交于
Because `collection.table_name` doesn't respect table alias. Use `collection.arel_attribute` instead.
-
由 Ryuta Kamizono 提交于
Update Active Job Basics [ci skip]
-
由 Ryuta Kamizono 提交于
Because `quoted_table_name` doesn't respect table alias. We should use `arel_attribute` for that, so I added `column_name_from_arel_node` to generate column name from an arel node.
-
由 Yoshiyuki Hirano 提交于
* Add Sneakers link to documentation list.
-