- 20 2月, 2019 18 次提交
-
-
由 Ryuta Kamizono 提交于
This is a follow-up of #35310. Currently `Topic.find_by(id: "not-a-number")` matches to a `id = 0` record. That is considered as silently leaking information. If non numeric string is given to find by an integer column, it should not be matched to any record. Related #12793.
-
由 Ryuta Kamizono 提交于
Fix reset of the source association when through association is loaded
-
由 Ryuta Kamizono 提交于
-
由 Bogdan Gusiev 提交于
The special case happens when through association has a custom scope that is applied to the source association when loading. In this case, the soucre association would need to be reset after main association is loaded. See tests. The special case exists when a through association has
-
由 Ryuta Kamizono 提交于
Merge pull request #35325 from abhaynikam/add-query-method-delegation-test-for-destory-by-and-delete-by Added delegation tests for delete_by and destroy_by methods
-
由 Abhay Nikam 提交于
-
由 Aaron Patterson 提交于
Deprecate LookupContext#rendered_format
-
由 Xavier Noria 提交于
Let Zeitwerk integration unhook AS::Dependencies
-
由 Aaron Patterson 提交于
We no longer depend on `rendered_format` side effects, so we can remove this method now.
🎉 -
由 Aaron Patterson 提交于
Return rendered template objects from renderers
-
由 Xavier Noria 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
This commit introduces "rendered template" and "rendered collection" objects. The template renderers can now return a more complex object than just strings. This allows the framework to get more information about the templates that were rendered. In this commit we use the rendered template object to set the "rendered_format" on the lookup context in the controller rather than all the way in the template renderer. That means we don't need to check the "rendered_format" every time we render a template, we just do it once after all templates have been rendered.
-
由 Aaron Patterson 提交于
This commit is to remove direct access to the "rendered_format" attribute on the lookup context. "rendered_format" is an implementation detail that we shouldn't test directly.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Pass the template format to the digestor
-
由 Gannon McGibbon 提交于
Reset column info after making Topic tz-aware
-
- 19 2月, 2019 12 次提交
-
-
由 Ryuta Kamizono 提交于
Introduce delete_by and destroy_by methods to ActiveRecord::Relation
-
由 Ryuta Kamizono 提交于
This reverts commit 6b69ae51, reversing changes made to 84bd9ada. Reason: We already use "happen" a lots for callbacks and validations. https://github.com/rails/rails/pull/35324#issuecomment-465096483 [ci skip]
-
由 Abhay Nikam 提交于
-
由 Vipul A M 提交于
Update active_record_callbacks.md [ci skip]
-
由 Sharang Dashputre 提交于
Change 'happen' to a more technical term
-
由 Ryuta Kamizono 提交于
Don't allow `where` with invalid value matches to nil values
-
由 Shodai Suzuki 提交于
-
由 Shodai Suzuki 提交于
-
由 Gannon McGibbon 提交于
In AttributeMethodsTest, we make the global Topic class time zone-aware which changes instance date time attribute casting behaviour. We need to reset column info after the test because future tests don't expect Topic date time columns to be time zone-aware.
-
由 Ryuta Kamizono 提交于
Actionpack typo fix [ci skip]
-
由 alkesh26 提交于
-
由 George Claghorn 提交于
When reloading is disabled, after_initialize hooks run after to_prepare hooks have already run for the last time. Since to_prepare hooks always run after application initializers, we don't need need to use an after_initialize hook.
-
- 18 2月, 2019 8 次提交
-
-
由 Ryuta Kamizono 提交于
That is considered as silently leaking information. If type casting doesn't return any actual value, it should not be matched to any record. Fixes #33624. Closes #33946.
-
由 Ryuta Kamizono 提交于
Return correct date in ActiveModel for time to date conversions
-
由 Ryuta Kamizono 提交于
Since `serialize` is passed user input args (from `where`, schema default, etc), a helper should provide `serialize` if the helper also provide `cast`. Related #32624, 34cc301f, a741208f.
-
由 Ryuta Kamizono 提交于
This is covered by `test_update_all_with_order_and_limit_updates_subset_only` and `test_update_all_with_order_and_limit_and_offset_updates_subset_only`.
-
由 Aaron Patterson 提交于
-
由 Ryuta Kamizono 提交于
`value_from_multiparameter_assignment` defined by `AcceptsMultiparameterTime` helper requires `default_timezone` method which is defined at `TimeValue` helper. Since `Date` type doesn't include `TimeValue`, I've extracted `Timezone` helper to be shared by `Date`, `DateTime`, and `Time` types.
-
由 Xavier Noria 提交于
-
由 Ryuta Kamizono 提交于
Before: ``` SELECT "comments".* FROM "comments" WHERE "comments"."type" IN ('VerySpecialComment') AND "comments"."post_id" = ? LIMIT ? [["post_id", 4], ["LIMIT", 1]] ``` After: ``` SELECT "comments".* FROM "comments" WHERE "comments"."type" = ? AND "comments"."post_id" = ? LIMIT ? [["type", "VerySpecialComment"], ["post_id", 4], ["LIMIT", 1]] ```
-
- 17 2月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
This fixes a bug that the `foreign_key` and the `foreign_type` are separated as different table conditions if a polymorphic association has a scope that joins another tables.
-
由 Ryuta Kamizono 提交于
-