- 27 12月, 2014 11 次提交
-
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
I'm attempting to remove `klass` as a dependency of the predicate builder, in favor of an object that better represents what we're using it for. The only part of this which doesn't fit nicely into that picture is the check for an association being polymorphic. Since I'm not yet sure what that is going to look like, I've moved this logic into another class in an attempt to separate things that will change from things that won't.
-
由 Sean Griffin 提交于
This reduces the number of places which will need to care about single value or range specific logic as we introduce type casting. The array handler is only responsible for producing `in` statements. /cc @mrgilman [Sean Griffin & Melanie Gilman]
-
由 Sean Griffin 提交于
This will allow us to pass the predicate builder into the constructor of these handlers. The procs had to be changed to objects, because the `PredicateBuilder` needs to be marshalable. If we ever decide to make `register_handler` part of the public API, we should come up with a better solution which allows procs. /cc @mrgilman [Sean Griffin & Melanie Gilman]
-
由 Sean Griffin 提交于
We're accidentally documenting `PredicateBuilder` and `ArrayHandler` since there's a constant which is missing `# :nodoc:`
-
由 Sean Griffin 提交于
Construction of relations can be a hotspot, we don't want to create one of these in the constructor. This also allows us to do more expensive things in the predicate builder's constructor, since it's created once per AR::Base subclass
-
由 Sean Griffin 提交于
We don't memoize the relation instance
-
由 Sean Griffin 提交于
-
由 brainopia 提交于
-
由 Sean Griffin 提交于
I think we should deprecate this behavior and just error if you tell us to do a case insensitive comparison for types which are not case sensitive. Partially reverts 35592307 Fixes #18195
-
由 Robin Dupret 提交于
With rails/coffee-rails#61 (and #17241), the `.coffee` extension is favoured over `.js.coffee`. Respectively, with rails/sass-rails#271 `.scss` and `.sass` are favoured over `.css.scss` and `.css.sass`. Let's update the documentation to reflect that. [ci skip]
-
- 26 12月, 2014 12 次提交
-
-
由 Yves Senn 提交于
Dump the default `nil` for PostgreSQL UUID primary key.
-
由 Ryuta Kamizono 提交于
-
由 Guillermo Iguaran 提交于
Fixed warning `possible reference to past scope` from railties
-
由 Vipul A M 提交于
-
由 Guillermo Iguaran 提交于
Fixed AR warning on ruby 2.2
-
由 Guillermo Iguaran 提交于
Targeting 2.2
-
由 Guillermo Iguaran 提交于
Remove unnecessary double space
-
由 Guillermo Iguaran 提交于
Remove ActionController::ModelNaming
-
由 Kenta Okamoto 提交于
-
由 Kyle Decot 提交于
-
由 Zachary Scott 提交于
-
由 Vipul A M 提交于
-
- 25 12月, 2014 11 次提交
-
-
由 Matthew Draper 提交于
Check for Rails.env instead of Rails
-
由 Pavel Penkov 提交于
`Rails` constant is added by rails-html-sanitizer leading to bugs in non-Rails apps using ActiveRecord and ActionMailer
-
由 claudiob 提交于
The methods in these modules are not used anywhere. They used to be invoked in polymorphic_routes.rb but their usage was removed in e8210450. What is your opinion about removing these methods? They do belong to the public API, but in reality their code has already been duplicated to ActionView::ModelNaming, since they are used by methods like `dom_id` and `dom_class` to associated records with DOM elements (in ActionView). Please tell me if you think that removing this module is a good idea and, in that case, if the PR is okay as it is, or you'd rather start by showing a deprecation message, and remove the module in Rails 5.1.
-
由 Zachary Scott 提交于
List the Active Support Instrumentation guide in the index (as WIP)
-
由 Zachary Scott 提交于
-
由 Zachary Scott 提交于
Fix grammar in Caching with Rails docs
-
由 Elaine Fang 提交于
-
由 Robin Dupret 提交于
-
由 Ivan Tkalin 提交于
-
由 Arun Agrawal 提交于
Fix bug in ActionMailer guide.
-
由 Dan Bernier 提交于
When setting a mailer's default from address, you have to pass a hash with a `:from` key; you can't pass just an email address.
-
- 24 12月, 2014 6 次提交
-
-
由 Sean Griffin 提交于
Add support for Reply-To field in mail_to helper
-
由 Sean Griffin 提交于
Removed unused parameter to cookie serialize method
-
由 Vipul A M 提交于
-
由 Sean Griffin 提交于
Describe full behaviour of Active Record's attribute query methods
-
由 Michael D.W. Prendergast 提交于
Clarify that query methods have a custom definition of whether a numeric value is present. [ci skip] The way Active Record query methods handle numeric values is a special case, and is not part of Rails's standard definition of present. This update attempts to make this more clear in the docs, so that people don't expect Object#present? to return false if used on a number that is zero.
-
由 Xavier Noria 提交于
-