- 02 11月, 2016 1 次提交
-
-
由 Bouke van der Bijl 提交于
-
- 29 10月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 25 10月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.
-
- 21 10月, 2016 1 次提交
-
-
由 José Gomes Júnior 提交于
-
- 27 9月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
29f0fbd5 has changed that always call `Minitest.autorun` in `active_support/testing/autorun`. Therefore, when used directly `Minitest.run`, tests are performed twice.
-
- 17 9月, 2016 1 次提交
-
-
由 Michael Grosser 提交于
assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
-
- 14 9月, 2016 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 yuuji.yaginuma 提交于
Follow up to 92703a9e
-
- 16 8月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
-
- 14 8月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
Related to #26146
-
- 13 8月, 2016 1 次提交
-
-
由 Brian Cardarella 提交于
Closes #26145
-
- 07 8月, 2016 6 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
-
- 27 7月, 2016 1 次提交
-
-
由 Ben Pickles 提交于
-
- 21 7月, 2016 1 次提交
-
-
由 Genadi Samokovarov 提交于
I dropped the version constraint in web-console with the idea it will be easier to upgrade the console between Rails releases. However, issues like #25899 started popping up. I'm reintroducing the constraint, but this time, I don't set an upper limit to the major version. This will keep the web-console in a version that always works for the current Rails version and can be easily upgraded to the last one with `bundle update`. We may need to backport this for Rails 5.0.1. Fixes #25899.
-
- 17 7月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- By default the session store will be set to cookie store with application name as session key. - Older apps are not affected as they will have the session store initializer generated by Rails in older versions, and Rails will not overwrite the session store if it is already set or disabled. - But new apps will not have the initializer, instead the session store will be set to cookie store by default. - Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
-
- 02 7月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs.
-
- 08 6月, 2016 2 次提交
-
-
由 Wojciech Wnętrzak 提交于
Previously model file was generated first, which resulted in inheriting from `ActiveRecord::Base`, but since application_record.rb is generated as well, it should already be used.
-
由 Prathamesh Sonpatki 提交于
- Fixes #25183. - The `as: :json` feature was added in https://github.com/rails/rails/pull/21671 and recommended to use for JSON endpoints so let's use it by default for API controller tests.
-
- 07 6月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Adjusted tests instead.
-
- 04 6月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
Fix minor regression about old apps not getting per_form_csrf and request_forgery_protection configs - Earlier per_form_csrf_tokens and request_forgery_protection config files were generated for old apps upgraded to Rails 5. - But when we collapsed all initializers into one file, the entire file does not get created for old apps. - This commit fixes it and also changes values for all new defaults for old apps so that they will not break. - Also added a test for `rails app:update`.
-
- 01 6月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Adjusted tests also for this new behavior. - Based on the discussion in https://github.com/rails/rails/pull/25184#issuecomment-222454583.
-
- 29 5月, 2016 2 次提交
-
-
由 Prathamesh Sonpatki 提交于
- These initializers are new defaults for Rails 5 and newly generated apps do not need to change them. - Fixes #25181
-
由 Kasper Timm Hansen 提交于
Follow up to e45f388e.
-
- 28 5月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Fixes #25180
-
- 17 5月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application - Now we will detect what javascript engine user is using and based on that we will generate either `.js` or `.coffee` version of the channel file. - This also needs a change in coffee-rails to override the `js_template` method. Related PR https://github.com/rails/coffee-rails/pull/72. - Currently coffee-rails gem sets `config.app_generators.javascript_engine` to `:coffee` and using this information we override the `js_template` to set the extension as `.coffee` in coffee-rails gem. - Using this approach, we can keep the `channel.js` and `channel.coffee` files in the Rails repository itself. - Additionally the `js_template` method can act as public interface for coffee-rails gem to hook into and change the extension to `.coffee` without maintaining the actual asset files. [Prathamesh Sonpatki, Matthew Draper]
-
- 15 5月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
Currently, if `ApplicationMailer` does not exist, it is generated when run the mailer generator, but layouts files does not generate. However, because it uses the layouts in `ApplicationMailer`, layouts are required. Follow up to #24161
-
- 28 4月, 2016 1 次提交
-
-
由 Genadi Samokovarov 提交于
Currently, if we generate a model while `app/model/application_record.rb` isn't present, we'll end up with a model with an `ActiveRecord::Base` parent _and_ a newly generated `app/models/application_record.rb`. While the behavior for choosing an `ActiveRecord::Base` was chosen for an easier migration math to 5.0, generating the `app/model/application_record.rb` file kinda contradicts with it. In any case, I think we should decide on a behavior and stick to it. Here, I'm changing the generated parent to always be `ApplicationRecord` and to always create `app/model/application_record.rb` if it doesn't exist.
-
- 23 4月, 2016 1 次提交
-
-
由 Andrew White 提交于
In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will preserve the timezone of the receiver when converting to an instance of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we need to introduce a compatibility layer so that apps that upgrade do not break. New apps will have a config initializer file that defaults to match the new Ruby 2.4 behavior going forward. For information about the changes to Ruby see: https://bugs.ruby-lang.org/issues/12189 https://bugs.ruby-lang.org/issues/12271 Fixes #24617.
-
- 16 4月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
`cable.js` is required for other Channels.
-
- 13 4月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Before this, while generating a channel, we were not creating `cable.js` if it does not already exist. - We have similar code for application mailer here - https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4. - Based on the comment - https://github.com/rails/rails/issues/24418#issuecomment-205421995.
-
- 08 4月, 2016 1 次提交
-
-
由 Jeroen Visser 提交于
* Updated syntax * Updated tests to match syntax
-
- 25 3月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
ActiveJob jobs now inherit from ApplicationJob by default. However, when updating to Rails 5 from the old Rails, since there is a possibility that ApplicationJob does not exist.
-
- 22 3月, 2016 2 次提交
-
-
由 Arthur Neves 提交于
[related #24243]
-
由 Rafael Mendonça França 提交于
-
- 12 3月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Followup of https://github.com/rails/rails/pull/24161.
-