1. 26 9月, 2018 4 次提交
    • A
      Allow helpers to be deferred until the routes have been finalized · 338c3c45
      Aaron Patterson 提交于
      ActiveStorage::BaseController subclasses ActionController::Base.
      ActionController::Base has an "inherited" hook set that includes the
      routing helpers to any subclass of AC::Base.  Since
      ActiveStorage::BaseController is a subclass of AC::Base, it will get
      routing helpers included automatically.  Unfortunately, when the
      framework is eagerly loaded, ActiveStorage::BaseController is loaded
      *before* the applications routes are loaded which means it attempts to
      include an "in flight" module so it gets an exception.
      
      This commit allows a class that's interested in being extended with
      routing helpers register itself such that when the routes are finalized,
      it will get the helpers included.  If the routes are already finalized,
      then the helpers get included immediately.
      338c3c45
    • A
      Eagerly build the routing helper module after routes are committed · 8dc78429
      Aaron Patterson 提交于
      This commit eagerly builds the route helper module after the routes have
      been drawn and finalized.  This allows us to cache the helper module but
      not have to worry about people accessing the module while route
      definition is "in-flight", and automatically deals with cache
      invalidation as the module is regenerated anytime someone redraws the
      routes.
      
      The restriction this commit introduces is that the url helper module can
      only be accessed *after* the routes are done being drawn.
      
      Refs #24554 and #32892
      8dc78429
    • A
      Merge pull request #33974 from rails/remove-catch-all-from-am · d34bd0d2
      Aaron Patterson 提交于
      This patch removes deprecated catch-all routes from AM
      d34bd0d2
    • A
      Merge pull request #33973 from rails/remove-catch-all · 6d698fdb
      Aaron Patterson 提交于
      Remove deprecated catch-all route in the AV tests
      6d698fdb
  2. 25 9月, 2018 9 次提交
  3. 24 9月, 2018 8 次提交
  4. 23 9月, 2018 6 次提交
  5. 22 9月, 2018 5 次提交
  6. 21 9月, 2018 8 次提交