- 17 6月, 2015 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
-
- 16 6月, 2015 2 次提交
-
-
由 Aaron Patterson 提交于
People should be free to mutate the header object, but not to set a new header object. That header object may be specific to the webserver, and we need to hide it's internals.
-
由 Aaron Patterson 提交于
this way we don't have to mutate the instance (as much) when writing a rack response
-
- 23 5月, 2015 1 次提交
-
-
由 karanarora 提交于
spelling fix [ci skip] example to be consistent [ci skip] grammatical fix typo fixes [ci skip]
-
- 05 3月, 2015 1 次提交
-
-
由 Genadi Samokovarov 提交于
The bug caused a segfault and you can find more info about it at: https://bugs.ruby-lang.org/issues/10685. We did a couple of work arounds, but 2.2.1 rolled out and those aren't needed anymore. Here are the reverted commits: - Revert "Work around for upstream Ruby bug #10685", commit 707a4338. - Revert "Fix segmentation fault in ActionPack tests", commit 22e0a22d. I'm also bumping the Ruby version check to 2.2.1 to prevent future segfaults.
-
- 01 3月, 2015 1 次提交
-
-
由 Genadi Samokovarov 提交于
In f6e293ec we avoided a segfault in the tests, however I think we should try to avoid the crash, as it may happen in user code as well. Here is what I distiled the bug down to: ```ruby # Rails case - works on 2.0, 2.1; crashes on 2.2 require 'action_dispatch' ActionDispatch::Response.new(200, "Content-Type" => "text/xml") # General case - works on 2.0, 2.1; crashes on 2.2 def foo(optional = {}, default_argument: nil) end foo('quux' => 'bar') ```
-
- 26 2月, 2015 1 次提交
-
-
由 Jeremy Kemper 提交于
Fixes regression in #18423. Merge default headers for new responses, but don't merge when creating a response from the last session request. hat tip @senny
❤
-
- 04 1月, 2015 2 次提交
-
-
由 Rafael Mendonça França 提交于
These requires were added only to change deprecation message
-
由 Rafael Mendonça França 提交于
-
- 29 10月, 2014 2 次提交
-
-
由 Xavier Noria 提交于
This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention.
-
由 Xavier Noria 提交于
The current style for warning messages without newlines uses concatenation of string literals with manual trailing spaces where needed. Heredocs have better readability, and with `squish` we can still produce a single line. This is a similar use case to the one that motivated defining `strip_heredoc`, heredocs are super clean.
-
- 20 10月, 2014 2 次提交
-
-
由 Abdelkader Boudih 提交于
-
由 Prathamesh Sonpatki 提交于
- Also one minor change for documenting url_for method in ActionController::Metal. [ci skip]
-
- 07 9月, 2014 1 次提交
-
-
由 Javan Makhmali 提交于
-
- 06 9月, 2014 1 次提交
-
-
由 Jeremy Kemper 提交于
-
- 08 6月, 2014 1 次提交
-
-
由 Matthew Draper 提交于
.. even when the producer is blocked for a write.
-
- 16 5月, 2014 1 次提交
-
-
由 Christiaan Van den Poel 提交于
-
- 13 3月, 2014 2 次提交
-
-
由 Aaron Patterson 提交于
avoid freezing the headers until the web server has actually read data from the body proxy. Once the webserver has read data, then we should throw an error if someone tries to set a header
-
由 Aaron Patterson 提交于
when streaming responses, we need to make sure the cookie jar is written to the headers before returning up the stack. This commit introduces a new method on the response object that writes the cookie jar to the headers as the response is committed. The middleware and test framework will not write the cookie headers if the response has already been committed. fixes #14352
-
- 05 3月, 2014 1 次提交
-
-
由 Prem Sichanugrist 提交于
`render :body` should just not set the `Content-Type` header. By removing the header, it breaks the compatibility with other parts. After this commit, `render :body` will returns `text/html` content type, sets by default from `ActionDispatch::Response`, and it will preserve the overridden content type if you override it. Fixes #14197, #14238 This partially reverts commit 30473768.
-
- 19 2月, 2014 2 次提交
-
-
由 Prem Sichanugrist 提交于
Setting this attribute to `true` will remove the content type header from the request. This is use in `render :body` feature.
-
由 Prem Sichanugrist 提交于
This is an option for sending a raw content back to browser. Note that this rendering option will unset the default content type and does not include "Content-Type" header back in the response. You should only use this option if you are expecting the "Content-Type" header to not be set. More information on "Content-Type" header can be found on RFC 2616, section 7.2.1. Please see #12374 for more detail.
-
- 09 2月, 2014 1 次提交
-
-
由 Dan Kang 提交于
Returning `self` from within the array returned by `to_ary` caused this. Instead, we can just substitute another object. It provides the `each` behavior required by the rack spec.
-
- 01 2月, 2014 1 次提交
-
-
由 Aaron Patterson 提交于
We can just require the file rather than going through the autoload indirection
-
- 03 12月, 2013 1 次提交
-
-
由 Genadi Samokovarov 提交于
-
- 01 9月, 2013 1 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
- 16 8月, 2013 1 次提交
-
-
由 Jon Kessler 提交于
update Rails::Railtie::Configuration and ActionDispatch::Response#respond_to? to accept include_private argument
-
- 29 6月, 2013 1 次提交
-
-
由 Aaron Patterson 提交于
request thread to return up the stack before the instance variable is assigned. Synchronize so that the ivar is assigned before the other thread can activate. fixes #10984
-
- 31 5月, 2013 1 次提交
-
-
由 Steve Klabnik 提交于
After some discussion on Twitter with @skud, the documentation on ActionDispatch::Response is a bit sparse. This class is useful when you're writing tests, as often you want to assert various things about the response that's coming back. Better docs would make this easier for people new to testing in Rails. I only added some descriptions for various properties that were defined, and mostly just a sentence or two. Most of these things are familliar if you're working with HTTP, but some words is better than no words at all. Hopefully further commits will fix up things that aren't just documentation.
-
- 22 4月, 2013 1 次提交
-
-
由 Vipul A M 提交于
-
- 16 2月, 2013 1 次提交
-
-
由 wangjohn 提交于
-
- 14 2月, 2013 1 次提交
-
-
由 Santiago Pastorino 提交于
-
- 27 1月, 2013 1 次提交
-
-
由 Xavier Noria 提交于
-
- 21 1月, 2013 1 次提交
-
-
由 Matthew Stopa 提交于
-
- 16 1月, 2013 3 次提交
-
-
由 Carlos Antonio da Silva 提交于
[ci skip]
-
由 Matthew Stopa 提交于
[ci skip]
-
由 Matthew Stopa 提交于
-
- 31 12月, 2012 1 次提交
-
-
由 Yves Senn 提交于
1) Failure: test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]: Expected: "image/png" Actual: "image/png; charset=utf-8"
-
- 05 12月, 2012 1 次提交
-
-
由 Fabrizio Regini 提交于
-
- 14 8月, 2012 1 次提交
-
-
由 Aaron Patterson 提交于
-