- 14 11月, 2018 1 次提交
-
-
由 Gannon McGibbon 提交于
Change `#bind_params_length` in SQLite adapter to return the default maximum amount (999). See https://www.sqlite.org/limits.html
-
- 12 11月, 2018 6 次提交
-
-
由 Ryuta Kamizono 提交于
Remove ensure from with_transaction_returning_status
-
由 Ryuta Kamizono 提交于
Document missing supported types [ci skip]
-
由 Eugene Kenny 提交于
The test added in 12b0b26d passes even without this code since 9b8c7796, as the call to `id` in `remember_transaction_record_state` now triggers a `sync_with_transaction_state` which discards the leftover state from the previous transaction. This issue had already been fixed for `save!`, `destroy` and `touch` in caae79a3, but continued to affect `save` because the call to `rollback_active_record_state!` in that method would increment the transaction level before `add_to_transaction` could clear it, preventing the fix from working correctly. As `rollback_active_record_state!` was removed entirely in 48007d53, this code is no longer needed.
-
由 Alberto Almagro 提交于
This commit adds missing types to the supported types list, which was extended in #30941
-
由 Ryuta Kamizono 提交于
Follow up a741208f. Since a741208f, `Decimal#serialize` which is superclass of `Money` type is no longer no-op, so it consistently serialize/deserialize a value as a decimal even if schema default.
-
由 Ryuta Kamizono 提交于
Related 34cc301f. `QueryAttribute#value_for_database` calls only `type.serialize`, and `Decimal#serialize` is a no-op unlike other attribute types. Whether or not `serialize` will invoke `cast` is undefined in our test cases, but it actually does not work properly unless it does so for now.
-
- 11 11月, 2018 3 次提交
-
-
由 Ryuta Kamizono 提交于
This reverts commit ab5d5c95, reversing changes made to ef4f5ef6.
-
由 Guillermo Iguaran 提交于
Prefer assert_not instead of refute [ci skip]
-
由 Alberto Almagro 提交于
As mentioned in the contributing to Ruby on Rails guides, we should prefer `assert_not` instead of `refute`. And the best place to start giving example are our bug report templates.. See: https://github.com/rails/rails/blame/master/guides/source/contributing_to_ruby_on_rails.md#L256
-
- 10 11月, 2018 7 次提交
-
-
由 Robin Dupret 提交于
Fix typo for Action Cable Overview doc [Eileen M. Uchitelle]
-
由 Evgeny Sugakov 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Gannon McGibbon 提交于
Clarify the validation of present associations
-
由 Robin Dupret 提交于
Docs: Update Development Dependencies Install
-
- 09 11月, 2018 7 次提交
-
-
由 Ana María Martínez Gómez 提交于
I think that it is not clear what means that _an association is present_. Add that it is checking that the foreign key is not empty and that the referenced object exists to clarify it.
-
由 Viktor Fonic 提交于
* Move all the testing related stuff to the contributing guide and redirect the reader to this guide once the installation process is finished as running tests is the logical next step. * Group documentation instructions by OS, not by gem * It eases the installation process and lessen the need to scroll through the guide * There's still a list of all additional services required for each of the gems above the instructions for each OS. * Also update a bit the instructions * Update some package names * Add `yarn` to the package list for Arch Linux and FreeBSD * Use `dnf` instead of `yum` for Fedora and CentOS * Advise the user to use `brew bundle` on macOS to lessen the maintenance burden for this OS and ease the process for the user. [ci skip]
-
由 yuuji.yaginuma 提交于
Follow up #34131.
-
由 yuuji.yaginuma 提交于
Related to: #34406
-
由 Ryuta Kamizono 提交于
Use `t.index ...` instead.
-
由 Ryuta Kamizono 提交于
-
- 08 11月, 2018 14 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Since quoted `Infinity` and `NaN` are valid data for PostgreSQL.
-
由 Andrew White 提交于
Add an :if_not_exists option to create_table
-
由 Ryuta Kamizono 提交于
Remove unused argument `expected_database`
-
由 bogdanvlviv 提交于
This argument was added in fa5a028e, and #34137 but hasn't been used.
-
由 Ryuta Kamizono 提交于
Use RuboCop 0.60.0 and remove exclude files for `Style/RedundantFreeze`
-
由 fatkodima 提交于
[fatkodima & Stefan Kanev]
-
由 Yasuo Honda 提交于
Since https://github.com/rubocop-hq/rubocop/pull/6333 has been included into RuboCop 0.60.0.
-
由 yuuji.yaginuma 提交于
`Webpacker` handles testing / development packs separately by default. If do not specify `RAILS_ENV`, there is no merit to precompile.
-
由 Ryuta Kamizono 提交于
Guard Enums against definitions with blank label names
-
由 Ryuta Kamizono 提交于
And remove trailing spaces.
-
由 Christophe Maximin 提交于
-
由 Eileen M. Uchitelle 提交于
Db schema cache dump and clear multi db
-
由 Gannon McGibbon 提交于
Adds support for multiple databases to `rails db:schema:cache:dump` and `rails db:schema:cache:clear`.
-
- 07 11月, 2018 2 次提交
-
-
由 Ryuta Kamizono 提交于
Always add records to parent of nested transaction
-
由 Eugene Kenny 提交于
When a record with transactional callbacks is saved, it's attached to the current transaction so that the callbacks can be run when the transaction is committed. Records can also be added manually with `add_transaction_record`, even if they have no transactional callbacks. When a nested transaction is committed, its records are transferred to the parent transaction, as transactional callbacks should only be run when the outermost transaction is committed (the "real" transaction). However, this currently only happens when the record has transactional callbacks, and not when added manually with `add_transaction_record`. If a record is added to a nested transaction, we should always attach it to the parent transaction when the nested transaction is committed, regardless of whether it has any transactional callbacks. [Eugene Kenny & Ryuta Kamizono]
-