- 02 8月, 2016 2 次提交
-
-
由 Kasper Timm Hansen 提交于
By changing ActionController::Parameter's superclass, Rails 5 also changed the YAML serialization format. Since YAML doesn't know how to handle parameters it would fallback to its routine for the superclass, which in Rails 4.2 was Hash while just Object in Rails 5. As evident in the tags YAML would spit out: 4.2: !ruby/hash-with-ivars:ActionController::Parameters 5.0: !ruby/object:ActionController::Parameters Thus when loading parameters YAML from 4.2 in Rails 5, it would parse a hash dump as it would an Object class. To fix this we have to provide our own `init_with` to be aware of the past format as well as the new one. Then we add a `load_tags` mapping, such that when the YAML parser sees `!ruby/hash-with-ivars:ActionController::Parameters`, it knows to call our `init_with` function and not try to instantiate it as a normal hash subclass.
-
由 Sean Griffin 提交于
Remove unnecessary methods for `NullRelation`
-
- 01 8月, 2016 4 次提交
-
-
由 Santiago Pastorino 提交于
remove unnecessary require and extend
-
由 Kasper Timm Hansen 提交于
Suppress warnings
-
由 Kasper Timm Hansen 提交于
remove old links from debugging guide [ci skip]
-
由 yuuji.yaginuma 提交于
-
- 31 7月, 2016 2 次提交
-
-
由 yuuji.yaginuma 提交于
`rack/test` is require at the top of file. https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L3 In addtion, `Rack::Test::Methods` is include in class, extend is unnecessary. https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L9
-
- 30 7月, 2016 2 次提交
-
-
由 David Heinemeier Hansson 提交于
Revert "Adds `not_in?` onto Object"
-
由 David Heinemeier Hansson 提交于
-
- 29 7月, 2016 3 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Guillermo Iguaran 提交于
Reset rack.input when the environment is scrubbed for the next request
-
由 Nick Sieger 提交于
-
- 28 7月, 2016 27 次提交
-
-
由 Rafael França 提交于
`FinderMethods` uses `records` (`load_target`) when `loaded?` is true
-
由 Rafael França 提交于
Fix to `CollectionProxy#load` does `load_target`
-
由 Rafael França 提交于
Remove `prepare_binds_for_database` internal method
-
由 Rafael França 提交于
Prevent `table_comment` query if a table doesn't have a comment
-
由 Rafael França 提交于
Avoid calling `current_database` in `table_comment`
-
由 Matthew Draper 提交于
`@quoted_{column,table}_names` should cache a frozen string
-
由 Ryuta Kamizono 提交于
`current_database` executes a query and `table_comment` is called to all tables even if a table does not have a comment. Using `current_database` increases extra queries.
-
由 Ryuta Kamizono 提交于
Caching a mutable string causes the following issue. ``` Loading development environment (Rails 5.1.0.alpha) irb(main):001:0> ActiveRecord::Base.connection.quote_table_name('foo') << '!!' => "`foo`!!" irb(main):002:0> ActiveRecord::Base.connection.quote_table_name('foo') << '!!' => "`foo`!!!!" irb(main):003:0> ActiveRecord::Base.connection.quote_table_name('foo') << '!!' => "`foo`!!!!!!" ```
-
由 Ryuta Kamizono 提交于
To avoid relying on the connection adapter for type casting binds.
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
[ci skip] Add documentation for error using select with order
-
由 Rafael França 提交于
Fix accessing provider_job_id inside active jobs for sidekiq adapter
-
由 प्रथमेश Sonpatki 提交于
Updated getting_started.md guide source text to reflect the change in error message …
-
由 Rafael Mendonça França 提交于
-
-
由 Rafael França 提交于
Correctly return `associated_table` when `associated_with?` is true
-
由 Takeshi AKIMA 提交于
[Rafael Mendonça França + Takeshi AKIMA]
-
由 Azzurrio 提交于
-
由 Sean Griffin 提交于
Remove circular join references in join_dependency
-
由 Rafael França 提交于
Add rationale for checking auth_tag length for AEAD ciphers
-
由 Rafael Mendonça França 提交于
Fix keyed defaults with root
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Decouple statement cache from connection adapter
-
由 Takashi Kokubun 提交于
Fixes #25653.
-
由 Bonghyun Kim 提交于
Updated getting_started guide to reflect the change in error message for ActionController::UnknownFromat in ArticlesController#new Restored texts about XML and JS template handlers. [ci skip]
-
由 Nick Sieger 提交于
Before this change, posted parameters would leak across requests. The included test case failed like so: 1) Failure: TestCaseTest#test_multiple_mixed_method_process_should_scrub_rack_input: --- expected +++ actual @@ -1 +1 @@ -{"bar"=>"an bar", "controller"=>"test_case_test/test", "action"=>"test_params"} +{"foo"=>"an foo", "bar"=>"an bar", "controller"=>"test_case_test/test", "action"=>"test_params"} An argument could be made that this situation isn't encountered often and that one should limit the number of requests per test case, but I still think the parameter leaking is an unexpected side-effect.
-