- 05 7月, 2020 1 次提交
-
-
由 Santiago Bartesaghi 提交于
-
- 03 7月, 2020 4 次提交
-
-
由 Eugene Kenny 提交于
Records loaded from join queries are no longer automatically marked as read-only since aff928ba.
-
由 Ryuta Kamizono 提交于
-
由 Eugene Kenny 提交于
Followup to 978421abd83d45b72e299f50a4fb324fcbdb3e00.
-
由 Eugene Kenny 提交于
This reverts commit 05060ddb. Tags are per-fiber, so they can't be cached in an instance variable.
-
- 02 7月, 2020 3 次提交
-
-
由 Vipul A M 提交于
Use segment instead of fragment in docs [ci-skip]
-
由 Michael Hagar 提交于
-
由 Eugene Kenny 提交于
Refactor MemoryStore to use Hash ordering rather than key access times
-
- 01 7月, 2020 6 次提交
-
-
由 Ryuta Kamizono 提交于
Backward compatibility to work `Marshal.load(legacy_record.dump)` for MySQL
-
由 Jean Boussier 提交于
This is mainly to simplify the code and use less memory, as large hash can use quite a lot: ```ruby >> ObjectSpace.memsize_of(1000.times.map { |i| [i, i]}.to_h) => 28768 >> ObjectSpace.memsize_of(10_000.times.map { |i| [i, i]}.to_h) => 458848 ``` The performance is mostly not impacted, if not slightly better: ```ruby require 'benchmark/ips' require 'active_support/all' @store = ActiveSupport::Cache::MemoryStore.new @store.write("small", "small") Benchmark.ips do |x| x.report("read:miss") { @store.read("miss") } x.report("read:small") { @store.read("small") } x.report("write:small") { @store.write("small", "small") } end ``` 6.0.3.2: ``` Warming up -------------------------------------- read:miss 42.466k i/100ms read:small 25.315k i/100ms write:small 17.826k i/100ms Calculating ------------------------------------- read:miss 426.923k (± 1.9%) i/s - 2.166M in 5.074890s read:small 248.518k (± 2.7%) i/s - 1.266M in 5.097049s write:small 180.388k (± 1.6%) i/s - 909.126k in 5.041238s ``` This branch: ``` Warming up -------------------------------------- read:miss 42.040k i/100ms read:small 28.364k i/100ms write:small 19.361k i/100ms Calculating ------------------------------------- read:miss 417.814k (± 2.1%) i/s - 2.102M in 5.033186s read:small 278.950k (± 2.8%) i/s - 1.418M in 5.088135s write:small 193.384k (± 1.8%) i/s - 968.050k in 5.007446s ```
-
由 Jonathan Hefner 提交于
Improve the docs for ordered options [ci skip]
-
由 Haroon Ahmed 提交于
-
由 Eugene Kenny 提交于
Deduplicate some routing data
-
由 Jean Boussier 提交于
-
- 30 6月, 2020 11 次提交
-
-
由 Ryuta Kamizono 提交于
`attr_name` in `YAMLColumn` is not part of v1 YAML. Ref #27773.
-
由 Ryuta Kamizono 提交于
Context https://github.com/rails/rails/pull/39599#discussion_r445429365. Similar with #39611. Actually we never said we would keep Mashal compatibility between two versions of Rails, so we sometimes directly removed the dedicated types in the past (e.g. f1a0fa9e, #29666), but that direct removing makes cache rotation harder. Keeping the unused constant in new version at least during one version will help cache rotation easier.
-
由 Eugene Kenny 提交于
-
由 Eugene Kenny 提交于
Remove redundant Exclude in .rubocop.yml
-
由 dug 提交于
All `/tmp/` dirs are already excluded by line 11.
-
由 Eugene Kenny 提交于
Speed up railties test test_skip_webpack_install currently ~10s
-
由 Eugene Kenny 提交于
Use URI::DEFAULT_PARSER rather than instantiate a new one
-
由 Jean Boussier 提交于
-
由 Jonathan Hefner 提交于
Build running for doc pull request [ci skip]
-
由 harirajv 提交于
Adding [ci skip] in commit message, does not prevent build from running.
- 29 6月, 2020 4 次提交
-
-
由 Eugene Kenny 提交于
The error being handled here was removed in 01c9782f.
-
由 Eugene Kenny 提交于
Use LoadError#original_message if available in safe_constantize
-
由 Vipul A M 提交于
Improve docs sentence structure [ci-skip]
-
由 Jean Boussier 提交于
-
- 28 6月, 2020 2 次提交
-
-
由 Michael Hagar 提交于
-
由 Jonathan Hefner 提交于
Clarify what is not supposed to be in session in docs [ci-skip]
-
- 27 6月, 2020 2 次提交
-
-
由 Michael Hagar 提交于
-
由 Jonathan Hefner 提交于
fix active storage cors configuration [ci skip]
-
- 26 6月, 2020 1 次提交
-
-
由 Ryuta Kamizono 提交于
Fix an error for `FileStore.cleanup` when using Sprockets
-
- 25 6月, 2020 6 次提交
-
-
由 colorbox 提交于
### Summary This PR fixes `NoMethodError` for `ActiveSupport::Cache::FileStore.cleanup` when using [Sprockets](https://github.com/rails/sprockets). `FileStore.cleanup` assumes entry object is a `Cache::Entry`. An entry obejct is returned from `FileStore.read_entry` method. If `FileStore.read_entry` returns object that cannot respond to `expired?` method, `FileStore.cleanup` will fail. Sprockets generates cache file in tmp/cache/assets. If `FileStore.read_entry` gets these Sprocket's cache file, this method creates entry object which cannot respond to `expired?` method. In my project, this error occured and failed to execute `ActiveSupport::Cache::FileStore.cleanup`. This PR adds a `is_a?` checking to entry object in `read_entry` method.
-
由 Eileen M. Uchitelle 提交于
Use a subquery when filtering `information_schema.tables` by `table_name`.
-
由 Ryuta Kamizono 提交于
Restore legacy YAML compatibility for MySQL with `active_record_yaml_version: 1`
-
由 Ryuta Kamizono 提交于
We had removed the dedicated `MysqlDateTime`, `MysqlJson`, and `OID::Json` classes in the past (f1a0fa9e, #29666), so legacy YAML loading has no longer always perfectly compatiblity. Fortunately, v2 (Rails 5.1 style) YAML doesn't contain type information in almost all cases (unless serializing object using custom select), so usually removing dedicated type affects to legacy YAML older than v1 (Rails 5.0 style) YAML only. This restores legacy YAML compatibility for MySQL with v1 format by adding the class alias in YAML for `MysqlString` which is most recently reported about compatibility concern. It also affects to legacy Rails 4.2 style YAML, but 4.2 style YAML had already broken by removing `MysqlDateTime` over 4 years ago.
-
由 Manuel Meurer 提交于
-
由 Kasper Timm Hansen 提交于
[ERB] simplify conversion to BINARY
-