- 14 2月, 2019 11 次提交
-
-
由 Cory Gwin @gwincr11 提交于
Motivation: - Currently we have 2 seperate monkey patches in place for tracking enqueded time for 2 seperate workers. It seems that activejob could be a source of truth for how long an item has been enqued so that we can easily use it for consistent monitoring across workers/apps to ensure that jobs are running at an acceptable speed. Changes: - Add an enqueded at attribute and serilization tooling. - Add a method to get how long a job has been enqueded for. - Add a logging item to show how long a job was enqued prior to the perform method firing.
-
由 Ryuta Kamizono 提交于
Revert "Chaining named scope is no longer leaking to class level querying methods"
-
由 Ryuta Kamizono 提交于
This reverts #32380, since this may cause that silently leaking information when people upgrade the app. We need deprecation first before making this.
-
由 Aaron Patterson 提交于
Cached collections only work if there is one template
-
由 Aaron Patterson 提交于
Cached collections only work if there is one template. If there are more than one templates, the caching mechanism doesn't have a key.
-
由 Xavier Noria 提交于
I believe the current style does not clearly communicate that we are ignoring non-existing autoload paths altogether. Your eyes may even be looking for an else clause that is easy to miss but that does not exist. With the early `next` and code comment the loop reads better for my taste.
-
由 Rafael França 提交于
Address to useless assignment `formats = nil` after #35254
-
由 Aaron Patterson 提交于
Clean for fix done in #35229. Removed unused arguments for `build_lookup_context `
-
由 Abhay Nikam 提交于
-
由 Aaron Patterson 提交于
Convert lookup context's to a stack for fixing #35222 and #34138
-
- 13 2月, 2019 13 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix database configurations building when DATABASE_URL present
-
由 Jaap van der Plas 提交于
Since production applications typically run with log level info and email adresses should be considered as sensitive data we want to prevent them from ending up in the logs. In development mode (with log level debug) they are still logged as part of the Mail::Message object.
-
由 Ryuta Kamizono 提交于
This reverts commit eec3e28a, reversing changes made to 5588fb48. Reason: Marking as loaded without actual loading is too greedy optimization. See more context #35239. Closes #35239. [Edouard CHIN & Ryuta Kamizono]
-
由 Matthew Draper 提交于
-
由 Eileen M. Uchitelle 提交于
Add Worker Pool section to Action Cable configuration docs
-
由 Kasper Timm Hansen 提交于
Action Cable: allow multiple instances of Server::Base with different configs
-
由 Vladimir Dementyev 提交于
That allows us to create a separate, isolated Action Cable server instance within the same app.
-
由 Vladimir Dementyev 提交于
-
由 Ryuta Kamizono 提交于
Fixed the CI failure https://travis-ci.org/rails/rails/jobs/492291248#L1185-L1191.
-
由 Eileen M. Uchitelle 提交于
Fix DatabaseSelector test that fails sometimes
-
由 Ryuta Kamizono 提交于
Currently custom attributes are always qualified by the table name in the generated SQL wrongly even if the table doesn't have the named column, it would cause an invalid SQL error. Custom attributes should only be qualified if the table has the same named column.
-
由 Xavier Noria 提交于
Zeitwerk integration
-
由 eileencodes 提交于
On CI we've seen a few test failures when the DatabaseSelectorTest runs before the ConnectionHandlersMultiDbTest. This is because it's creating 2 handlers but not properly tearing them down. Example failure: ``` Failure: ActiveRecord::ConnectionAdapters::ConnectionHandlersMultiDbTest#test_connects_to_with_single_configuration [/rails/activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:241]: Expected: 1 Actual: 2 ```
-
- 12 2月, 2019 16 次提交
-
-
由 Guillermo Iguaran 提交于
Support testing of non-ActionDispatch-routed apps.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Yuji Yaginuma 提交于
If generate application without specified options,`actioncable` and `activestorage` loads by default.
-
由 Aaron Patterson 提交于
This commit keeps a stack of lookup contexts on the ActionView::Base instance. If a format is passed to render, we instantiate a new lookup context and push it on the stack, that way any child calls to "render" will use the same format information as the parent. This also isolates "sibling" calls to render (multiple calls to render in the same template). Fixes #35222 #34138
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
use ProxyPattern to match for ActiveSupport::Notifications fanout/unsubscribe
-
由 zvkemp 提交于
-
由 Rafael França 提交于
Document queue_as block arguments and their use
-
由 Olivier Lacan 提交于
Currently, we only document the use case for ActiveJob's `queue_as` block arguments in [Rails Guides][1]. It seems necessary to document them in the API docs as well considering how useful and powerful this option is. [1]: https://edgeguides.rubyonrails.org/active_job_basics.html#queues [ci skip]
-
由 Ryuta Kamizono 提交于
The implicit delegation in the migration class is to be logged. It is not intended in the migration compatibility, so it should be avoided. Fixes #35224.
-
由 Aaron Patterson 提交于
-
由 Gannon McGibbon 提交于
Allow deprecated non-symbol access to nested `config_for` hashes
-
由 Rafael França 提交于
Optimized namespaces_to_paths method.
-
由 Ufuk Kayserilioglu 提交于
The assertion from the previous PR had the expected and the actual values in the wrong order, so when a test failed the error message was confusing. This commit fixes the problem by switching the order.
-
由 Ufuk Kayserilioglu 提交于
A change to `Rails::Application.config_for` in https://github.com/rails/rails/pull/33815 and https://github.com/rails/rails/pull/33882 has altered the behaviour of the returned object in a breaking manner. Before that change, nested hashes returned from `config_for` could be accessed using non-symbol keys. After the change, all keys are recursively symbolized so non-symbol access fails to read the expected values. This is a breaking change for any app that might be relying on the nested hashes returned from `config_for` calls, and thus should be deprecated before being removed from the codebase. This commit introduces a temporary `NonSymbolAccessDeprecatedHash` class that recursively wraps any nested hashes inside the `OrderedOptions` object returned from `config_for` and issues a deprecation notice when a non-symbol based access is performed. This way, apps that are still relying on the ability to access these nested hashes using non-symbol keys will be able to observe the deprecation notices and have time to implement changes before non-symbol access is removed for good. A CHANGELOG entry is also added to note that non-symbol access to nested `config_for` hashes is deprecated.
-