- 16 3月, 2018 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Fix typo in active_job_basics.md
-
由 Jon Evans 提交于
`it's` -> `its`
-
- 15 3月, 2018 4 次提交
-
-
由 yuuji.yaginuma 提交于
It's causing a test to fail. Ref: https://travis-ci.org/rails/rails/jobs/353758855#L1433-L1501
-
由 Andrew White 提交于
Time column improvements
-
由 Sean Griffin 提交于
Don't marshal ActiveSupport::Cache::Entry objects twice
-
由 Sean Griffin 提交于
When upgrading to Rails 5.2 we're seeing `ActiveSupport::Cache::Entry#compress` and `ActiveSupport::Cache::Entry#should_compress?` as the highest usage of our CPU. At least some part of this is coming from the fact that objects are being marshaled multiple times. This memoizes the marshaled value to eliminate half the problem.
-
- 14 3月, 2018 11 次提交
-
-
由 Andrew White 提交于
Merge pull request #32250 from bogdanvlviv/add-info-about-exprity-of-siigned-cookies-to-upgrading-to-5-2 Update "Upgrading from Rails 5.1 to Rails 5.2" [ci skip]
-
由 bogdanvlviv 提交于
Add section "Expiry in signed or encrypted cookie is now embedded in the cookies values" to `master` since it should always be in the guides, not only for version 5.2. Add info about `config.action_dispatch.use_authenticated_cookie_encryption` to the "Configuring Rails Applications" guide. It was committed straight to `5-2-stable` since we don't need this functionality in 6.0. Related to b25fcbc0.
-
由 Andrew White 提交于
Fixes #32248.
-
由 Yuji Yaginuma 提交于
-
由 Kasper Timm Hansen 提交于
Fix routing inspector tests broken in https://github.com/rails/rails/commit/6629d51a2756fadf961bb09df20579cacfef2c8e * Renames grep_pattern to grep throughout. * Fixes setup not calling super by calling setup with a block. * Converts test helper method to a private one, like we have it other places. * Uses keyword arguments to get around awkward draw({ grep: "x" }, Action…) construction.
-
由 Kasper Timm Hansen 提交于
We end up with: ``` Usage: bin/rails routes [options] Options: -c, [--controller=CONTROLLER] # Filter by a specific controller, e.g. PostsController or Admin::PostsController. -g, [--grep=GREP] # Grep routes by a specific pattern. -E, [--expanded], [--no-expanded] # Print routes expanded vertically with parts explained. ``` which does miss the bit about routes being printed in order. Also: * Renames options to ease help output readability, then clarifies each option. * Fixes a bunch of indentation.
-
由 Kasper Timm Hansen 提交于
-
由 Rafael Mendonça França 提交于
We only add the header when releasing to avoid some conflicts. [ci skip]
-
由 Rafael Mendonça França 提交于
Perform email jobs in #assert_emails
-
由 Kasper Timm Hansen 提交于
Change message on the empty result of searching routes by `rails routes` with `-c` or `-g`
-
由 Kasper Timm Hansen 提交于
Update "Ruby on Rails 5.2 Release Notes" Guide [ci skip]
-
- 13 3月, 2018 10 次提交
-
-
由 bogdanvlviv 提交于
- Add a description of major features in Rails 5.2. - Add a reference to Pull Request/Commit to every entry in CHANGELOGs, note that some of them combined. - Add section "Ruby on Rails Guides" with notable changes. - Note that - Skipped this since encrypted secrets are already on the way out. ``` * Add `rails secrets:show` command. ([Pull Request](https://github.com/rails/rails/pull/29695)) ``` - Skipped this since it was backported all the way to 5-0-stable. ``` * Make Rails' test runner work better with minitest plugins. ([Pull Request](https://github.com/rails/rails/pull/29572)) ``` Thanks to everyone who has been working on Rails 5.2! <3
-
由 bogdanvlviv 提交于
- Create `Base` and inherit `Sheet` and `Expanded` in order to - prevent code duplication. - Remove trailing "\n" for components of `Expanded`. - There is no need for `Expanded#header` to return `@buffer` so return `nil` instead. - Change `no_routes` message "No routes were found for this controller" since if use `-g`, it sounds incorrect. - Display `No routes were found for this controller.` if apply `-c`. - Display `No routes were found for this grep pattern.` if apply `-g`. Related to #32130
-
由 bogdanvlviv 提交于
- Add a mention about `-g`. - Improve info about `--expanded` option of `rails routes`.
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Adam Richardson 提交于
Since `Redis#call` duck types as a Proc, we'd call `#call` on it, thinking it's a Proc. Fixed by check for the Proc explicitly instead of duck typing on `#call`. References #32233
-
由 Yuji Yaginuma 提交于
Follow up of 309bb6c4
-
由 George Claghorn 提交于
-
由 Gannon McGibbon 提交于
Perform enqueued delivery jobs in #assert_emails and #assert_no_emails.
-
由 Andrew White 提交于
The Active Storage service for Azure Storage has an option called `path` that is ambiguous in meaning. It needs to be set to the primary blob storage endpoint but that can be determined from the blobs client anyway. To simplify the configuration this commit removes the `path` option and gets the endpoint from the blobs client instead. Closes #32225.
-
- 12 3月, 2018 10 次提交
-
-
由 Kasper Timm Hansen 提交于
-
由 Andrew White 提交于
Closes #32219.
-
由 Eileen M. Uchitelle 提交于
Fix note marks
-
由 Yauheni Dakuka 提交于
-
由 Andrew White 提交于
Fix CHANGELOGs [ci skip]
-
由 bogdanvlviv 提交于
- Add missing dots. - Remove reference to itself on GitHub. Usually, we add references to fixed issues only in a changelog. Follow up #32223
-
由 Kasper Timm Hansen 提交于
Draw line of a route name to the end of row console on `rails routes --expanded`
-
由 Andrew White 提交于
In #24542, quoted_time was introduced to strip the leading date component for time columns because it was having a significant effect in mariadb. However, it assumed that the date component was always 2000-01-01 which isn't the case, especially if the source wasn't another time column.
-
由 Andrew White 提交于
For legacy reasons Rails stores time columns on sqlite as full timestamp strings. However because the date component wasn't being normalized this meant that when they were read back they were being prefixed with 2001-01-01 by ActiveModel::Type::Time. This had a twofold result - first it meant that the fast code path wasn't being used because the string was invalid and second it was corrupting the second fractional component being read by the Date._parse code path. Fix this by a combination of normalizing the timestamps on writing and also changing Active Model to be more lenient when detecting whether a string starts with a date component before creating the dummy time value for parsing.
-
由 Andrew White 提交于
In #20317, datetime columns had their precision applied on assignment but that behaviour wasn't applied to time columns - this commit fixes that. Fixes #30301.
-
- 11 3月, 2018 1 次提交
-
-
由 yuuji.yaginuma 提交于
Since Rails 6 requires Ruby 2.4.1+.
-
- 10 3月, 2018 2 次提交
-
-
由 yuuji.yaginuma 提交于
Currently, `Exiting` is showed during server startup. ``` ./bin/rails s => Booting Puma => Rails 6.0.0.alpha application starting in development => Run `rails server --help` for more startup options Exiting Puma starting in single mode... * Version 3.11.2 (ruby 2.5.0-p0), codename: Love Song ``` This is because processing at server stop is passed as a block, and `Rack::Serve#start` receives a block and executes it during startup processing. https://github.com/rack/rack/blob/50db1ffdf8b98503fb7c6e6648622b5d7d78d58e/lib/rack/server.rb#L258 In order to avoid this, stop processing is passed as argument.
-
由 Rafael França 提交于
update psych gem to 3.2 stable release
-