- 29 5月, 2015 6 次提交
-
-
由 Sean Griffin 提交于
This is a usability change to fix a quirk from our definition of partial writes. By default, we only persist changed attributes. When creating a new record, this is assumed that the default values came from the database. However, if the user provided a default, it will not be persisted, since we didn't see it as "changed". Since this is a very specific case, I wanted to isolate it with the other quirks that come from user provided default values. The number of edge cases which are presenting themselves are starting to make me wonder if we should just remove the ability to assign a default, in favor of overriding `initialize`. For the time being, this is required for the attributes API to not have confusing behavior. We had to delete one test, since this actually changes the meaning of `.changed?` on Active Record models. It now specifically means `changed_from_database?`. While I think this will make the attributes API more ergonomic to use, it is a subtle change in definition (though not a backwards incompatible one). We should probably figure out the right place to document this. (Feel free to open a PR doing that if you're reading this). /cc @rafaelfranca @kirs @senny This is an alternate implementation of #19921. Close #19921. [Sean Griffin & Kir Shatrov]
-
由 Sean Griffin 提交于
This is a variant implementation of the changes proposed in #19914. Unlike that PR, the change in behavior is isolated in its own class. This is to prevent wonky behavior if a Proc is assigned outside of the default, and it is a natural place to place the behavior required by #19921 as well. Close #19914. [Sean Griffin & Kir Shatrov]
-
由 Rafael Mendonça França 提交于
config.static_index configures directory Index "index.html" filename
-
由 Rafael Mendonça França 提交于
Remove unused package tasks
-
由 Lauro Caetano 提交于
removed erroneous line. Corrected presence validation example.
-
由 Jurnell Cockhren 提交于
Addresses #20343. Removes erroneous line of code in the sample codeblock.
-
- 28 5月, 2015 34 次提交
-
-
由 Arthur Nogueira Neves 提交于
[ci skip] Fix block parameter of assert_no_difference
-
由 Santiago Pastorino 提交于
Deprecate `:nothing` option for render method
-
由 Hiromichi Yamada 提交于
-
由 Mehmet Emin İNAÇ 提交于
`head` method works similar to `render` method with `:nothing` option
-
由 Arun Agrawal 提交于
Give credit to extra contributor for Base.reload fix
-
由 Shane Hender 提交于
-
由 Eliot Sykes 提交于
Set `config.static_index` to serve a static directory index file not named `index`. For example, to serve `main.html` instead of `index.html` for directory requests, set `config.static_index` to `"main"`.
-
由 Arun Agrawal 提交于
We are using `all:build` now.
-
由 Rafael Mendonça França 提交于
Properly append preload / includes args on Merger
-
由 Washington Luiz 提交于
Couldn't find other way to get the association name from a given class other than looping through `reflect_on_all_associations` reflections .. Noticed this one while looking at this example: ```ruby class Product < ActiveRecord::Base has_many :variants has_many :translations end class Translation < ActiveRecord::Base belongs_to :product end class Variant < ActiveRecord::Base belongs_to :product end class BugTest < Minitest::Test def test_merge_stuff product = Product.create! name: 'huhu' variant = Variant.create! product_id: product.id Translation.create! locale: 'en', product_id: product.id product_relation = Product.all .preload(:translations) .joins(:translations) .merge(Translation.where(locale: 'en')) .where(name: 'huhu') assert_equal variant, Variant.joins(:product).merge(product_relation).first end end ```
-
由 Rafael Mendonça França 提交于
Remove custom `lines` and use `/tools/line_statistics`
-
由 Rafael Mendonça França 提交于
SQLite3: Add collation support for string and text columns
-
由 Rafael Mendonça França 提交于
-
由 Jordan Raine 提交于
-
由 Akshay Vishnoi 提交于
-
由 Rafael Mendonça França 提交于
Add application/vnd.api+json alias to the JSON MIME Type.
-
由 Rafael Mendonça França 提交于
Allow the use of symbols or strings to specify enum values in test fixtures
-
由 Eduardo Bautista 提交于
-
由 Rafael Mendonça França 提交于
Cause ActiveRecord::Base::reload to also ignore the QueryCache.
-
由 Rafael Mendonça França 提交于
If specify `strict: :default` explicitly, do not set sql_mode.
-
由 George Claghorn 提交于
Currently, values for columns backing Active Record enums must be specified as integers in test fixtures: awdr: title: "Agile Web Development with Rails" status: 2 rfr: title: "Ruby for Rails" status: <%= Book.statuses[:proposed] %> This is potentially confusing, since enum values are typically specified as symbols or strings in application code. To resolve the confusion, this change permits the use of symbols or strings to specify enum values: awdr: status: :published It is compatible with fixtures that specify enum values as integers.
-
由 Rafael Mendonça França 提交于
Changed mysqldump to include sprocs and functions
-
由 Rafael Mendonça França 提交于
Fix rake method definition leaking onto Object
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This is a leftover of #19867
-
由 Rafael Mendonça França 提交于
[PoC] Stop shadowing parameters named `action`
-
由 Rafael Mendonça França 提交于
Remove redundant 'Rails' from Rails::AppRailsLoader constant
-
由 Zachary Scott 提交于
[ci-skip] Replace dead link about HttpOnly cookies.
-
由 Yoong Kang Lim 提交于
-
由 Dermot Haughey 提交于
add framework_test add another test
-
由 Rafael Mendonça França 提交于
Add assertion for get? method into test cases
-
由 Rafael Mendonça França 提交于
Fix indentation warning on active_support ordered_options
-
由 Claudio B. 提交于
Remove unnecessary reference to example Blog app in initialization guides
-
由 Jake Gavin 提交于
-